Hide Pager border if no pager exists

Chad Little · Chad Little · commit 7408483c2f02 · 2017-07-11T14:33:27.000-07:00
Summary: I guess we have this magical method that tells me if a pager is coming down the render pipe. Huzzah. Test Plan: Test Branches page in Diffusion, see no pager border. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D18202
diff --git a/src/view/phui/PHUIObjectBoxView.php b/src/view/phui/PHUIObjectBoxView.php
@@ -302,7 +302,9 @@ protected function getTagContent() {
 
     $pager = null;
     if ($this->pager) {
-      $pager = phutil_tag_div('phui-object-box-pager', $this->pager);
+      if ($this->pager->willShowPagingControls()) {
+        $pager = phutil_tag_div('phui-object-box-pager', $this->pager);
+      }
     }
 
     $content = array(

Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,9 @@ protected function getTagContent() {`
`302`	`302`
`303`	`303`	`$pager = null;`
`304`	`304`	`if ($this->pager) {`
`305`		`- $pager = phutil_tag_div('phui-object-box-pager', $this->pager);`
	`305`	`+ if ($this->pager->willShowPagingControls()) {`
	`306`	`+ $pager = phutil_tag_div('phui-object-box-pager', $this->pager);`
	`307`	`+ }`
`306`	`308`	`}`
`307`	`309`
`308`	`310`	`$content = array(`