Fix an issue where repositories with hyphens could sort improperly in typeaheads

epriestley · epriestley · commit a6f018210466 · 2017-07-03T09:28:02.000-07:00
Summary: Fixes T12894. See that task for discussion. Test Plan: - Created repositories `abcdef`, then `abcdef-a` through `abcdef-f`. - Before patch, awkward sort order. - After patch, query for `abcdef` hits `abcdef` first. - See T12894 for details and screenshots. Reviewers: chad, amckinley Reviewed By: chad Maniphest Tasks: T12894 Differential Revision: https://secure.phabricator.com/D18179
diff --git a/src/applications/diffusion/typeahead/DiffusionRepositoryDatasource.php b/src/applications/diffusion/typeahead/DiffusionRepositoryDatasource.php
@@ -54,7 +54,7 @@ public function loadResults() {
         $parts[] = $monogram;
       }
 
-      $name = implode(' ', $parts);
+      $name = implode("\n", $parts);
 
       $vcs = $repository->getVersionControlSystem();
       $vcs_type = PhabricatorRepositoryType::getNameForRepositoryType($vcs);

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public function loadResults() {`
`54`	`54`	`$parts[] = $monogram;`
`55`	`55`	`}`
`56`	`56`
`57`		`- $name = implode(' ', $parts);`
	`57`	`+ $name = implode("\n", $parts);`
`58`	`58`
`59`	`59`	`$vcs = $repository->getVersionControlSystem();`
`60`	`60`	`$vcs_type = PhabricatorRepositoryType::getNameForRepositoryType($vcs);`