Skip to content

Commit 8756d82

Browse files
joshuaspencejoshuaspence
committed
Remove @group annotations
Summary: I'm pretty sure that `@group` annotations are useless now... see D9855. Also fixed various other minor issues. Test Plan: Eye-ball it. Reviewers: #blessed_reviewers, epriestley, chad Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin, hach-que Differential Revision: https://secure.phabricator.com/D9859
1 parent 1d4b064 commit 8756d82

File tree

431 files changed

+490
-1711
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

431 files changed

+490
-1711
lines changed

‎conf/default.conf.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -798,7 +798,7 @@
798798
// '#/autobuilt/#',
799799
),
800800

801-
// If you set this to true, users can accept their own revisions. This action
801+
// If you set this to true, users can accept their own revisions. This action
802802
// is disabled by default because it's most likely not a behavior you want,
803803
// but it proves useful if you are working alone on a project and want to make
804804
// use of all of differential's features.
@@ -817,7 +817,7 @@
817817

818818
// If you set this to true, any user can reopen a revision so long as it has
819819
// been closed. This can be useful if a revision is accidentally closed or
820-
// if a developer changes his or her mind after closing a revision. If it is
820+
// if a developer changes his or her mind after closing a revision. If it is
821821
// false, reopening is not allowed.
822822
'differential.allow-reopen' => false,
823823

‎externals/balanced-php/tests/Balanced/SuiteTest.php

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@
2727
* <li>$BALANCED_URL_ROOT If set applies to \Balanced\Settings::$url_root.
2828
* <li>$BALANCED_API_KEY If set applies to \Balanced\Settings::$api_key.
2929
* </ul>
30-
*
31-
* @group suite
3230
*/
3331
class SuiteTest extends \PHPUnit_Framework_TestCase
3432
{
@@ -784,17 +782,17 @@ function testBankAccountVerificationSuccess() {
784782
}
785783

786784
function testEvents() {
787-
$prev_num_events = Marketplace::mine()->events->total();
788-
$account = self::_createBuyer();
789-
$account->debit(123);
790-
$cur_num_events = Marketplace::mine()->events->total();
791-
$count = 0;
785+
$prev_num_events = Marketplace::mine()->events->total();
786+
$account = self::_createBuyer();
787+
$account->debit(123);
788+
$cur_num_events = Marketplace::mine()->events->total();
789+
$count = 0;
792790
while ($cur_num_events == $prev_num_events && $count < 10) {
793791
printf("waiting for events - %d, %d == %d\n", $count + 1, $cur_num_events, $prev_num_events);
794792
sleep(2); // 2 seconds
795-
$cur_num_events = Marketplace::mine()->events->total();
796-
$count += 1;
797-
}
793+
$cur_num_events = Marketplace::mine()->events->total();
794+
$count += 1;
795+
}
798796
$this->assertTrue($cur_num_events > $prev_num_events);
799797
}
800798
}

‎src/aphront/AphrontController.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group aphront
5-
*/
63
abstract class AphrontController extends Phobject {
74

85
private $request;

‎src/aphront/AphrontURIMapper.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group aphront
5-
*/
63
final class AphrontURIMapper {
74

85
private $map;
@@ -49,4 +46,5 @@ final private function tryRule($rule, $value, $path) {
4946

5047
return array(null, null);
5148
}
49+
5250
}

‎src/aphront/configuration/AphrontApplicationConfiguration.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
/**
44
* @task routing URI Routing
5-
* @group aphront
65
*/
76
abstract class AphrontApplicationConfiguration {
87

@@ -228,4 +227,5 @@ final public function buildControllerForPath($path) {
228227

229228
return array($controller, $uri_data);
230229
}
230+
231231
}

‎src/aphront/configuration/AphrontDefaultApplicationConfiguration.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
* NOTE: Do not extend this!
55
*
66
* @concrete-extensible
7-
* @group aphront
87
*/
98
class AphrontDefaultApplicationConfiguration
109
extends AphrontApplicationConfiguration {

‎src/aphront/console/DarkConsoleController.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group console
5-
*/
63
final class DarkConsoleController extends PhabricatorController {
74

85
protected $op;

‎src/aphront/console/DarkConsoleCore.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group console
5-
*/
63
final class DarkConsoleCore {
74

85
private $plugins = array();

‎src/aphront/console/DarkConsoleDataController.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group console
5-
*/
63
final class DarkConsoleDataController extends PhabricatorController {
74

85
private $key;

‎src/aphront/console/plugin/DarkConsoleErrorLogPlugin.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group console
5-
*/
63
final class DarkConsoleErrorLogPlugin extends DarkConsolePlugin {
74

85
public function getName() {
@@ -98,4 +95,5 @@ public function renderPanel() {
9895
phutil_tag('pre', array('class' => 'PhabricatorMonospaced'), $details),
9996
));
10097
}
98+
10199
}

‎src/aphront/console/plugin/DarkConsoleEventPlugin.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group console
5-
*/
63
final class DarkConsoleEventPlugin extends DarkConsolePlugin {
74

85
public function getName() {
@@ -14,7 +11,6 @@ public function getDescription() {
1411
}
1512

1613
public function generateData() {
17-
1814
$listeners = PhutilEventEngine::getInstance()->getAllListeners();
1915
foreach ($listeners as $key => $listener) {
2016
$listeners[$key] = array(
@@ -95,4 +91,5 @@ public function renderPanel() {
9591

9692
return phutil_implode_html("\n", $out);
9793
}
94+
9895
}

‎src/aphront/console/plugin/DarkConsolePlugin.php

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group console
5-
*/
63
abstract class DarkConsolePlugin {
74

85
private $data;
@@ -13,9 +10,7 @@ abstract public function getName();
1310
abstract public function getDescription();
1411
abstract public function renderPanel();
1512

16-
public function __construct() {
17-
18-
}
13+
public function __construct() {}
1914

2015
public function getColor() {
2116
return null;

‎src/aphront/console/plugin/DarkConsoleRequestPlugin.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group console
5-
*/
63
final class DarkConsoleRequestPlugin extends DarkConsolePlugin {
74

85
public function getName() {

‎src/aphront/console/plugin/DarkConsoleServicesPlugin.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group console
5-
*/
63
final class DarkConsoleServicesPlugin extends DarkConsolePlugin {
74

85
protected $observations;
@@ -36,7 +33,6 @@ public static function isQueryAnalyzerRequested() {
3633
* @phutil-external-symbol class PhabricatorStartup
3734
*/
3835
public function generateData() {
39-
4036
$should_analyze = self::isQueryAnalyzerRequested();
4137

4238
$log = PhutilServiceProfiler::getInstance()->getServiceCallLog();

‎src/aphront/console/plugin/DarkConsoleXHProfPlugin.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group console
5-
*/
63
final class DarkConsoleXHProfPlugin extends DarkConsolePlugin {
74

85
protected $profileFilePHID;

‎src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group console
5-
*/
63
final class DarkConsoleErrorLogPluginAPI {
74

85
private static $errors = array();

‎src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group console
5-
*/
63
final class DarkConsoleEventPluginAPI extends PhabricatorEventListener {
74

85
private static $events = array();

‎src/aphront/console/plugin/xhprof/DarkConsoleXHProfPluginAPI.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?php
22

33
/**
4-
* @group console
54
* @phutil-external-symbol function xhprof_enable
65
* @phutil-external-symbol function xhprof_disable
76
*/

‎src/aphront/response/Aphront304Response.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group aphront
5-
*/
63
final class Aphront304Response extends AphrontResponse {
74

85
public function getHTTPResponseCode() {

‎src/aphront/response/Aphront400Response.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group aphront
5-
*/
63
final class Aphront400Response extends AphrontResponse {
74

85
public function getHTTPResponseCode() {

‎src/aphront/response/Aphront403Response.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group aphront
5-
*/
63
final class Aphront403Response extends AphrontHTMLResponse {
74

85
private $forbiddenText;

‎src/aphront/response/Aphront404Response.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group aphront
5-
*/
63
final class Aphront404Response extends AphrontHTMLResponse {
74

85
public function getHTTPResponseCode() {

‎src/aphront/response/AphrontAjaxResponse.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group aphront
5-
*/
63
final class AphrontAjaxResponse extends AphrontResponse {
74

85
private $content;

‎src/aphront/response/AphrontDialogResponse.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group aphront
5-
*/
63
final class AphrontDialogResponse extends AphrontResponse {
74

85
private $dialog;

‎src/aphront/response/AphrontFileResponse.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group aphront
5-
*/
63
final class AphrontFileResponse extends AphrontResponse {
74

85
private $content;

‎src/aphront/response/AphrontHTMLResponse.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group aphront
5-
*/
63
abstract class AphrontHTMLResponse extends AphrontResponse {
74

85
public function getHeaders() {

‎src/aphront/response/AphrontJSONResponse.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group aphront
5-
*/
63
final class AphrontJSONResponse extends AphrontResponse {
74

85
private $content;
@@ -40,4 +37,5 @@ public function getHeaders() {
4037
$headers = array_merge(parent::getHeaders(), $headers);
4138
return $headers;
4239
}
40+
4341
}

‎src/aphront/response/AphrontPlainTextResponse.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group aphront
5-
*/
63
final class AphrontPlainTextResponse extends AphrontResponse {
74

85
public function setContent($content) {

‎src/aphront/response/AphrontProxyResponse.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
* instantiating an @{class:AphrontAjaxResponse} in @{method:buildProxy}, and
88
* then constructing a real @{class:AphrontAjaxResponse} in
99
* @{method:reduceProxyResponse}.
10-
*
11-
* @group aphront
1210
*/
1311
abstract class AphrontProxyResponse extends AphrontResponse {
1412

@@ -70,5 +68,4 @@ final public function buildResponseString() {
7068
'AphrontProxyResponse must implement reduceProxyResponse().');
7169
}
7270

73-
7471
}

‎src/aphront/response/AphrontRedirectResponse.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
/**
44
* TODO: Should be final but isn't because of AphrontReloadResponse.
5-
*
6-
* @group aphront
75
*/
86
class AphrontRedirectResponse extends AphrontResponse {
97

‎src/aphront/response/AphrontReloadResponse.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
* if the action is javascript-driven but redirect if it isn't. This preserves
66
* query parameters in the javascript case. A reload response behaves like
77
* a redirect response but causes a page reload when received via workflow.
8-
*
9-
* @group aphront
108
*/
119
final class AphrontReloadResponse extends AphrontRedirectResponse {
1210

‎src/aphront/response/AphrontResponse.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group aphront
5-
*/
63
abstract class AphrontResponse {
74

85
private $request;
@@ -94,7 +91,6 @@ public static function encodeJSONForHTTPResponse(array $object) {
9491
}
9592

9693
protected function addJSONShield($json_response) {
97-
9894
// Add a shield to prevent "JSON Hijacking" attacks where an attacker
9995
// requests a JSON response using a normal <script /> tag and then uses
10096
// Object.prototype.__defineSetter__() or similar to read response data.

‎src/aphront/response/AphrontWebpageResponse.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22

3-
/**
4-
* @group aphront
5-
*/
63
final class AphrontWebpageResponse extends AphrontHTMLResponse {
74

85
private $content;

0 commit comments

Comments
 (0)