Throw instead of log for invalid properties

Summary: Continue work started at D3601.

Test Plan:
Commented declaration `AphrontController::$request`, saw exception.
Brought it back, didn't see exception.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4233

Author: vrana

src/__phutil_library_map__.php

@@ -1361,6 +1361,7 @@
     'AphrontCalendarEventView' => 'AphrontView',
     'AphrontCalendarMonthView' => 'AphrontView',
     'AphrontContextBarView' => 'AphrontView',
+    'AphrontController' => 'Phobject',
     'AphrontCrumbsView' => 'AphrontView',
     'AphrontCursorPagerView' => 'AphrontView',
     'AphrontDefaultApplicationConfiguration' => 'AphrontApplicationConfiguration',
@@ -1422,6 +1423,7 @@
     'AphrontTokenizerTemplateView' => 'AphrontView',
     'AphrontTypeaheadTemplateView' => 'AphrontView',
     'AphrontUsageException' => 'AphrontException',
+    'AphrontView' => 'Phobject',
     'AphrontWebpageResponse' => 'AphrontHTMLResponse',
     'CelerityPhabricatorResourceController' => 'CelerityResourceController',
     'CelerityResourceController' => 'PhabricatorController',

src/aphront/AphrontController.php

@@ -3,7 +3,7 @@
 /**
  * @group aphront
  */
-abstract class AphrontController {
+abstract class AphrontController extends Phobject {
 
   private $request;
   private $currentApplication;
@@ -45,9 +45,4 @@ final public function getCurrentApplication() {
     return $this->currentApplication;
   }
 
-  public function __set($name, $value) {
-    phlog('Wrote to undeclared property '.get_class($this).'::$'.$name.'.');
-    $this->$name = $value;
-  }
-
 }

src/view/AphrontView.php

@@ -1,6 +1,6 @@
 <?php
 
-abstract class AphrontView {
+abstract class AphrontView extends Phobject {
 
   protected $children = array();
 
@@ -42,9 +42,4 @@ final protected function renderSingleView($child) {
 
   abstract public function render();
 
-  public function __set($name, $value) {
-    phlog('Wrote to undeclared property '.get_class($this).'::$'.$name.'.');
-    $this->$name = $value;
-  }
-
 }