Clean up a little more Calendar display logic

Summary: Uh, non-all-day-events said 1:30 - 2:29 PM, which is real silly.

Test Plan: Looked at a non-all-day-event.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D16874

Author: epriestley

src/applications/calendar/storage/PhabricatorCalendarEvent.php

@@ -584,10 +584,12 @@ public function renderEventDate(
     $min_date = $start->newPHPDateTime();
     $max_date = $end->newPHPDateTime();
 
-    if ($show_end) {
+    if ($this->getIsAllDay()) {
       // Subtract one second since the stored date is exclusive.
       $max_date = $max_date->modify('-1 second');
+    }
 
+    if ($show_end) {
       $min_day = $min_date->format('Y m d');
       $max_day = $max_date->format('Y m d');