Change double quotes to single quotes.

Summary: Ran `arc lint --apply-patches --everything` over rP, mainly to change double quotes to single quotes where appropriate. These changes also validate that the `ArcanistXHPASTLinter::LINT_DOUBLE_QUOTE` rule is working as expected.

Test Plan: Eyeballed it.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D9431

Author: joshuaspence

resources/sql/patches/059.engines.php

@@ -24,7 +24,7 @@
   echo "Converting {$name}...\n";
   queryfx(
     $conn,
-    "ALTER TABLE %T.%T ENGINE=InnoDB",
+    'ALTER TABLE %T.%T ENGINE=InnoDB',
     $table['db'],
     $table['tbl']);
 }

resources/sql/patches/079.nametokenindex.php

@@ -7,10 +7,10 @@
 $table->beginReadLocking();
 
 $users = $table->loadAll();
-echo count($users)." users to index";
+echo count($users).' users to index';
 foreach ($users as $user) {
   $user->updateNameTokens();
-  echo ".";
+  echo '.';
 }
 
 $table->endReadLocking();

resources/sql/patches/090.forceuniqueprojectnames.php

@@ -64,9 +64,9 @@
   }
   if (count($update) == $size) {
     throw new Exception(
-      "Failed to make any progress while updating projects. Schema upgrade ".
-      "has failed. Go manually fix your project names to be unique (they are ".
-      "probably ridiculous?) and then try again.");
+      'Failed to make any progress while updating projects. Schema upgrade '.
+      'has failed. Go manually fix your project names to be unique (they are '.
+      'probably ridiculous?) and then try again.');
   }
 }
 

resources/sql/patches/102.heraldcleanup.php

@@ -24,14 +24,14 @@
     mpull($rules, 'getID'));
 }
 
-echo "This may take a moment";
+echo 'This may take a moment';
 do {
   queryfx(
     $conn_w,
     'DELETE FROM %T %Q LIMIT 1000',
     HeraldRule::TABLE_RULE_APPLIED,
     $clause);
-  echo ".";
+  echo '.';
 } while ($conn_w->getAffectedRows());
 
 $table->endReadLocking();

resources/sql/patches/117.repositorydescription.php

@@ -2,5 +2,5 @@
 
 $conn = id(new PhabricatorRepository())->establishConnection('w');
 if (queryfx_one($conn, "SHOW COLUMNS FROM `repository` LIKE 'description'")) {
-  queryfx($conn, "ALTER TABLE `repository` DROP `description`");
+  queryfx($conn, 'ALTER TABLE `repository` DROP `description`');
 }

resources/sql/patches/131.migraterevisionquery.php

@@ -5,12 +5,12 @@
 $table->beginReadLocking();
 $conn_w = $table->establishConnection('w');
 
-echo "Migrating revisions";
+echo 'Migrating revisions';
 do {
   $revisions = $table->loadAllWhere('branchName IS NULL LIMIT 1000');
 
   foreach ($revisions as $revision) {
-    echo ".";
+    echo '.';
 
     $diff = $revision->loadActiveDiff();
     if (!$diff) {

resources/sql/patches/20121209.xmacromigrate.php

@@ -1,6 +1,6 @@
 <?php
 
-echo "Giving image macros PHIDs";
+echo 'Giving image macros PHIDs';
 $table = new PhabricatorFileImageMacro();
 $table->openTransaction();
 
@@ -9,7 +9,7 @@
     continue;
   }
 
-  echo ".";
+  echo '.';
 
   queryfx(
     $macro->establishConnection('w'),

resources/sql/patches/20130201.revisionunsubscribed.php

@@ -11,7 +11,7 @@
   'SELECT id, phid, unsubscribed FROM differential_revision');
 
 foreach ($revs as $rev) {
-  echo ".";
+  echo '.';
 
   $unsubscribed = json_decode($rev['unsubscribed']);
   if (!$unsubscribed) {

resources/sql/patches/20130409.commitdrev.php

@@ -22,12 +22,12 @@
   $editor->addEdge($commit->getPHID(), $commit_drev, $revision_phid);
   $edges++;
   if ($edges % 256 == 0) {
-    echo ".";
+    echo '.';
     $editor->save();
     $editor = id(new PhabricatorEdgeEditor())->setSuppressEvents(true);
   }
 }
 
-echo ".";
+echo '.';
 $editor->save();
 echo "\nDone.\n";

resources/sql/patches/20130502.countdownrevamp2.php

@@ -1,6 +1,6 @@
 <?php
 
-echo "Giving countdowns PHIDs";
+echo 'Giving countdowns PHIDs';
 $table = new PhabricatorCountdown();
 $table->openTransaction();
 
@@ -9,7 +9,7 @@
     continue;
   }
 
-  echo ".";
+  echo '.';
 
   queryfx(
     $countdown->establishConnection('w'),