Skip to content

Commit 7761288

Browse files
committedOct 20, 2014
Diffusion - maybe fix import spam bug
Summary: Ref T6350. I just set up a repository to import secure.phabricator.com/P and saw an error in my error logs about this, creating a fatal around when we publish feed stories. this is late enough in the editor code path I could see it firing again and again and again... Test Plan: the first phabricator commit ever only had one duplicated transaction before i applied this patch. its yet to do it again. otherwise, ask some users with the issue to deploy it and see if it fixes things for them too. Reviewers: epriestley, chad Reviewed By: chad Subscribers: Korvin, epriestley Maniphest Tasks: T6350 Differential Revision: https://secure.phabricator.com/D10729
1 parent 7a163ca commit 7761288

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎src/applications/feed/PhabricatorFeedStoryPublisher.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,8 @@ public function publish() {
121121
}
122122

123123
$subscribed_phids = $this->subscribedPHIDs;
124-
$subscribed_phids = $this->filterSubscribedPHIDs($subscribed_phids);
125124
if ($subscribed_phids) {
125+
$subscribed_phids = $this->filterSubscribedPHIDs($subscribed_phids);
126126
$this->insertNotifications($chrono_key, $subscribed_phids);
127127
$this->sendNotification($chrono_key, $subscribed_phids);
128128
}

0 commit comments

Comments
 (0)
Failed to load comments.