Use new FutureIterator instead of Futures

Summary: Ref T6829. Deprecate the `Futures()` function.

Test Plan: N/A

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6829

Differential Revision: https://secure.phabricator.com/D11077

Author: joshuaspence

scripts/symbols/generate_ctags_symbols.php

@@ -30,7 +30,9 @@
   $futures[$file] = ctags_get_parser_future($file);
 }
 
-foreach (Futures($futures)->limit(8) as $file => $future) {
+$futures = id(new FutureIterator($futures))
+  ->limit(8);
+foreach ($futures as $file => $future) {
   $tags = $future->resolve();
   $tags = explode("\n", $tags[1]);
 

scripts/symbols/generate_php_symbols.php

@@ -23,7 +23,9 @@
   $futures[$file] = xhpast_get_parser_future($data[$file]);
 }
 
-foreach (Futures($futures)->limit(8) as $file => $future) {
+$futures = id(new FutureIterator($futures))
+  ->limit(8);
+foreach ($futures as $file => $future) {
   $tree = XHPASTTree::newFromDataAndResolvedExecFuture(
     $data[$file],
     $future->resolve());

src/applications/differential/parser/DifferentialChangesetParser.php

@@ -653,7 +653,7 @@ private function process() {
     );
 
     $this->highlightErrors = false;
-    foreach (Futures($futures) as $key => $future) {
+    foreach (new FutureIterator($futures) as $key => $future) {
       try {
         try {
           $highlighted = $future->resolve();

src/applications/diffusion/DiffusionLintSaveRunner.php

@@ -250,7 +250,9 @@ private function blameAuthors() {
 
     $authors = array();
 
-    foreach (Futures($futures)->limit(8) as $path => $future) {
+    $futures = id(new FutureIterator($futures))
+      ->limit(8);
+    foreach ($futures as $path => $future) {
       $queries[$path]->loadFileContentFromFuture($future);
       list(, $rev_list, $blame_dict) = $queries[$path]->getBlameData();
       foreach (array_keys($this->blame[$path]) as $line) {

src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php

@@ -129,7 +129,7 @@ protected function getSVNResult(ConduitAPIRequest $request) {
     );
     $futures = array_filter($futures);
 
-    foreach (Futures($futures) as $key => $future) {
+    foreach (new FutureIterator($futures) as $key => $future) {
       $stdout = '';
       try {
         list($stdout) = $future->resolvex();

src/applications/diffusion/conduit/DiffusionTagsQueryConduitAPIMethod.php

@@ -129,7 +129,8 @@ private function loadMessagesForTags(array $tags) {
         $tag->getName());
     }
 
-    Futures($futures)->resolveAll();
+    id(new FutureIterator($futures))
+      ->resolveAll();
 
     foreach ($tags as $key => $tag) {
       $future = $futures[$key];

src/applications/diffusion/controller/DiffusionBrowseSearchController.php

@@ -132,7 +132,9 @@ private function renderGrepResults(array $results) {
     }
 
     try {
-      Futures($futures)->limit(8)->resolveAll();
+      id(new FutureIterator($futures))
+        ->limit(8)
+        ->resolveAll();
     } catch (PhutilSyntaxHighlighterException $ex) {}
 
     $rows = array();

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

@@ -445,7 +445,9 @@ private function findGitMergeBases(array $ref_updates) {
         $ref_new);
     }
 
-    foreach (Futures($futures)->limit(8) as $key => $future) {
+    $futures = id(new FutureIterator($futures))
+      ->limit(8);
+    foreach ($futures as $key => $future) {
 
       // If 'old' and 'new' have no common ancestors (for example, a force push
       // which completely rewrites a ref), `git merge-base` will exit with
@@ -554,7 +556,9 @@ private function findGitContentUpdates(array $ref_updates) {
     }
 
     $content_updates = array();
-    foreach (Futures($futures)->limit(8) as $key => $future) {
+    $futures = id(new FutureIterator($futures))
+      ->limit(8);
+    foreach ($futures as $key => $future) {
       list($stdout) = $future->resolvex();
 
       if (!strlen(trim($stdout))) {
@@ -709,7 +713,7 @@ private function findMercurialChangegroupRefUpdates() {
 
     // Resolve all of the futures now. We don't need the 'commits' future yet,
     // but it simplifies the logic to just get it out of the way.
-    foreach (Futures($futures) as $future) {
+    foreach (new FutureIterator($futures) as $future) {
       $future->resolve();
     }
 
@@ -782,7 +786,7 @@ private function findMercurialChangegroupRefUpdates() {
         }
 
         $head_map = array();
-        foreach (Futures($dfutures) as $future_head => $dfuture) {
+        foreach (new FutureIterator($dfutures) as $future_head => $dfuture) {
           list($stdout) = $dfuture->resolvex();
           $descendant_heads = array_filter(explode("\1", $stdout));
           if ($descendant_heads) {

src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php

@@ -142,7 +142,7 @@ private function resolveMercurialRefs() {
     }
 
     $results = array();
-    foreach (Futures($futures) as $ref => $future) {
+    foreach (new FutureIterator($futures) as $ref => $future) {
       try {
         list($stdout) = $future->resolvex();
       } catch (CommandException $ex) {

src/applications/diviner/workflow/DivinerGenerateWorkflow.php

@@ -333,7 +333,9 @@ private function resolveAtomizerFutures(array $futures, array $file_hashes) {
     $atom_cache = $this->getAtomCache();
     $bar = id(new PhutilConsoleProgressBar())
       ->setTotal(count($futures));
-    foreach (Futures($futures)->limit(4) as $key => $future) {
+    $futures = id(new FutureIterator($futures))
+      ->limit(4);
+    foreach ($futures as $key => $future) {
       try {
         $atoms = $future->resolveJSON();
 

src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php

@@ -70,7 +70,7 @@ public function pullRefs(array $refs) {
 
     $results = array();
     $failed = array();
-    foreach (Futures($futures) as $key => $future) {
+    foreach (new FutureIterator($futures) as $key => $future) {
       try {
         $results[$key] = $future->resolve();
       } catch (Exception $ex) {

src/applications/doorkeeper/bridge/DoorkeeperBridgeJIRA.php

@@ -57,7 +57,7 @@ public function pullRefs(array $refs) {
 
     $results = array();
     $failed = array();
-    foreach (Futures($futures) as $key => $future) {
+    foreach (new FutureIterator($futures) as $key => $future) {
       try {
         $results[$key] = $future->resolveJSON();
       } catch (Exception $ex) {

src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php

@@ -234,7 +234,7 @@ protected function resolveFuture(
     HarbormasterBuildTarget $target,
     Future $future) {
 
-    $futures = Futures(array($future));
+    $futures = new FutureIterator(array($future));
     foreach ($futures->setUpdateInterval(5) as $key => $future) {
       if ($future === null) {
         $build->reload();

src/applications/harbormaster/step/HarbormasterCommandBuildStepImplementation.php

@@ -65,7 +65,7 @@ public function execute(
     $build_update = 5;
 
     // Read the next amount of available output every second.
-    $futures = Futures(array($future));
+    $futures = new FutureIterator(array($future));
     foreach ($futures->setUpdateInterval(1) as $key => $future_iter) {
       if ($future_iter === null) {
 

src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php

@@ -43,7 +43,10 @@ public function execute(PhutilArgumentParser $args) {
 
     $bar = id(new PhutilConsoleProgressBar())
       ->setTotal(count($futures));
-    foreach (Futures($futures)->limit(8) as $full_path => $future) {
+
+    $futures = id(new FutureIterator($futures))
+      ->limit(8);
+    foreach ($futures as $full_path => $future) {
       $bar->update(1);
 
       $tree = XHPASTTree::newFromDataAndResolvedExecFuture(

src/infrastructure/lint/linter/PhabricatorJavelinLinter.php

@@ -50,7 +50,7 @@ public function willLintPaths(array $paths) {
       $futures[$path] = $future;
     }
 
-    foreach (Futures($futures)->limit(8) as $path => $future) {
+    foreach (id(new FutureIterator($futures))->limit(8) as $path => $future) {
       $this->symbols[$path] = $future->resolvex();
     }
   }