Re-implement one line stories.

Summary: This puts back the 'one line' story we previously had with the updated design.

Test Plan: Review my feed.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D6666

Author: chadlittle

src/__celerity_resource_map__.php

@@ -3830,7 +3830,7 @@
   ),
   'phui-feed-story-css' =>
   array(
-    'uri' => '/res/e5d6825b/rsrc/css/phui/phui-feed-story.css',
+    'uri' => '/res/5d7ab26c/rsrc/css/phui/phui-feed-story.css',
     'type' => 'css',
     'requires' =>
     array(

src/applications/feed/story/PhabricatorFeedStory.php

@@ -17,7 +17,6 @@ abstract class PhabricatorFeedStory implements PhabricatorPolicyInterface {
   private $handles  = array();
   private $objects  = array();
 
-
 /* -(  Loading Stories  )---------------------------------------------------- */
 
 

src/applications/feed/story/PhabricatorFeedStoryAudit.php

@@ -23,10 +23,12 @@ public function renderView() {
       $this->linkTo($commit_phid)));
 
     $comments = $this->getValue('content');
-
     $view->setImage($this->getHandle($author_phid)->getImageURI());
-    $content = $this->renderSummary($this->getValue('content'));
-    $view->appendChild($content);
+
+    if ($comments) {
+      $content = $this->renderSummary($this->getValue('content'));
+      $view->appendChild($content);
+    }
 
     return $view;
   }

src/applications/feed/story/PhabricatorFeedStoryDifferential.php

@@ -20,9 +20,21 @@ public function renderView() {
 
     $action = $data->getValue('action');
 
+    switch ($action) {
+      case DifferentialAction::ACTION_CREATE:
+      case DifferentialAction::ACTION_CLOSE:
+        $full_size = true;
+        break;
+      default:
+        $full_size = false;
+        break;
+    }
+
     $view->setImage($this->getHandle($data->getAuthorPHID())->getImageURI());
-    $content = $this->renderSummary($data->getValue('feedback_content'));
-    $view->appendChild($content);
+    if ($full_size) {
+      $content = $this->renderSummary($data->getValue('feedback_content'));
+      $view->appendChild($content);
+    }
 
     return $view;
   }

src/applications/feed/story/PhabricatorFeedStoryManiphest.php

@@ -32,15 +32,14 @@ public function renderView() {
         // Don't repeat this at home!
         $comments = $data->getValue('comments');
         $content = $this->renderSummary($comments);
+        $view->appendChild($content);
         break;
-      default:
-        // I think this is just for create
+      case ManiphestAction::ACTION_CREATE:
         $content = $this->renderSummary($data->getValue('description'));
+        $view->appendChild($content);
         break;
     }
 
-    $view->appendChild($content);
-
     $href = $this->getHandle($data->getValue('taskPHID'))->getURI();
     $view->setHref($href);
 

src/applications/feed/story/PhabricatorFeedStoryPhriction.php

@@ -65,8 +65,12 @@ public function renderView() {
     }
 
     $view->setImage($this->getHandle($author_phid)->getImageURI());
-    $content = $this->renderSummary($data->getValue('content'));
-    $view->appendChild($content);
+    switch ($action) {
+      case PhrictionActionConstants::ACTION_CREATE:
+        $content = $this->renderSummary($data->getValue('content'));
+        $view->appendChild($content);
+        break;
+      }
 
     return $view;
   }

src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php

@@ -44,7 +44,9 @@ public function renderView() {
 
     $xaction->setHandles($this->getHandles());
     $view->setTitle($xaction->getTitleForFeed());
-    $view->appendChild($xaction->getBodyForFeed());
+    if (nonempty($xaction->getBodyForFeed())) {
+      $view->appendChild($xaction->getBodyForFeed());
+    }
 
     $view->setImage(
       $this->getHandle(

src/applications/uiexample/examples/PHUIFeedStoryExample.php

@@ -128,7 +128,6 @@ public function renderExample() {
       ->setImage(celerity_get_resource_uri('/rsrc/image/people/harding.png'))
       ->setImageHref('http://en.wikipedia.org/wiki/Warren_G._Harding')
       ->setEpoch(1)
-      ->setOneLine(true)
       ->setAppIcon('differential-dark')
       ->setUser($user);
 

src/view/phui/PHUIFeedStoryView.php

@@ -10,7 +10,6 @@ final class PHUIFeedStoryView extends AphrontView {
   private $epoch;
   private $viewed;
   private $href;
-  private $oneline = false;
   private $pontification = null;
   private $tokenBar = array();
   private $projects = array();
@@ -36,11 +35,6 @@ public function setEpoch($epoch) {
     return $this;
   }
 
-  public function setOneLine($oneline) {
-    $this->oneline = $oneline;
-    return $this;
-  }
-
   public function setImage($image) {
     $this->image = $image;
     return $this;
@@ -86,7 +80,6 @@ public function addAction(PHUIIconView $action) {
   }
 
   public function setPontification($text, $title = null) {
-    $this->setOneLine(false);
     if ($title) {
       $title = phutil_tag('h3', array(), $title);
     }
@@ -130,6 +123,7 @@ public function renderNotification() {
   public function render() {
 
     require_celerity_resource('phui-feed-story-css');
+    $oneline = $this->isEmptyContent($this->renderChildren());
 
     $body = null;
     $foot = null;
@@ -174,7 +168,7 @@ public function render() {
     }
 
     $ol_foot = null;
-    if ($this->oneline) {
+    if ($oneline) {
       $ol_foot = phutil_tag(
         'div',
           array(
@@ -236,7 +230,7 @@ public function render() {
         $body_content);
     }
 
-    if ($this->oneline) {
+    if ($oneline) {
       $foot = null;
     } else {
       $foot = phutil_tag(
@@ -250,7 +244,7 @@ public function render() {
     }
 
     $classes = array('phui-feed-story');
-    if ($this->oneline) {
+    if ($oneline) {
       $classes[] = 'phui-feed-story-oneline';
     }
 

webroot/rsrc/css/phui/phui-feed-story.css

@@ -86,7 +86,7 @@
 }
 
 .phui-feed-story-oneline .phui-feed-story-head {
-  padding: 4px;
+  padding: 8px;
 }
 
 .phui-feed-story-oneline .phui-feed-story-body {