Skip to content

Commit 9c999e3

Browse files
chadlittlechadlittle
committedAug 7, 2013
Update pinboard view styles, move to PHUI
Summary: Tightens up the CSS to display more items (4 wide on 15") and fixes some mobile CSS issues with appseach. Fixes T3614 Test Plan: Tested Pholio, Macros, mobile layouts Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T3614 Differential Revision: https://secure.phabricator.com/D6694
1 parent 8b07c49 commit 9c999e3

8 files changed

+97
-98
lines changed
 

‎src/__celerity_resource_map__.php

+54-54
Original file line numberDiff line numberDiff line change
@@ -863,7 +863,7 @@
863863
),
864864
'aphront-list-filter-view-css' =>
865865
array(
866-
'uri' => '/res/d7b529ce/rsrc/css/aphront/list-filter-view.css',
866+
'uri' => '/res/a90a0c94/rsrc/css/aphront/list-filter-view.css',
867867
'type' => 'css',
868868
'requires' =>
869869
array(
@@ -3345,15 +3345,6 @@
33453345
),
33463346
'disk' => '/rsrc/js/core/phtize.js',
33473347
),
3348-
'phabricator-pinboard-view-css' =>
3349-
array(
3350-
'uri' => '/res/61ecd7cf/rsrc/css/layout/phabricator-pinboard-view.css',
3351-
'type' => 'css',
3352-
'requires' =>
3353-
array(
3354-
),
3355-
'disk' => '/rsrc/css/layout/phabricator-pinboard-view.css',
3356-
),
33573348
'phabricator-prefab' =>
33583349
array(
33593350
'uri' => '/res/511859ca/rsrc/js/core/Prefab.js',
@@ -3825,6 +3816,15 @@
38253816
),
38263817
'disk' => '/rsrc/css/phui/phui-list.css',
38273818
),
3819+
'phui-pinboard-view-css' =>
3820+
array(
3821+
'uri' => '/res/3b961aa1/rsrc/css/phui/phui-pinboard-view.css',
3822+
'type' => 'css',
3823+
'requires' =>
3824+
array(
3825+
),
3826+
'disk' => '/rsrc/css/phui/phui-pinboard-view.css',
3827+
),
38283828
'phui-remarkup-preview-css' =>
38293829
array(
38303830
'uri' => '/res/4535e062/rsrc/css/phui/phui-remarkup-preview.css',
@@ -4161,7 +4161,7 @@
41614161
), array(
41624162
'packages' =>
41634163
array(
4164-
'604768b8' =>
4164+
'00dd9b38' =>
41654165
array(
41664166
'name' => 'core.pkg.css',
41674167
'symbols' =>
@@ -4209,7 +4209,7 @@
42094209
40 => 'phabricator-property-list-view-css',
42104210
41 => 'phabricator-tag-view-css',
42114211
),
4212-
'uri' => '/res/pkg/604768b8/core.pkg.css',
4212+
'uri' => '/res/pkg/00dd9b38/core.pkg.css',
42134213
'type' => 'css',
42144214
),
42154215
'606f7152' =>
@@ -4400,16 +4400,16 @@
44004400
),
44014401
'reverse' =>
44024402
array(
4403-
'aphront-dialog-view-css' => '604768b8',
4404-
'aphront-error-view-css' => '604768b8',
4405-
'aphront-form-view-css' => '604768b8',
4406-
'aphront-list-filter-view-css' => '604768b8',
4407-
'aphront-pager-view-css' => '604768b8',
4408-
'aphront-panel-view-css' => '604768b8',
4409-
'aphront-table-view-css' => '604768b8',
4410-
'aphront-tokenizer-control-css' => '604768b8',
4411-
'aphront-tooltip-css' => '604768b8',
4412-
'aphront-typeahead-control-css' => '604768b8',
4403+
'aphront-dialog-view-css' => '00dd9b38',
4404+
'aphront-error-view-css' => '00dd9b38',
4405+
'aphront-form-view-css' => '00dd9b38',
4406+
'aphront-list-filter-view-css' => '00dd9b38',
4407+
'aphront-pager-view-css' => '00dd9b38',
4408+
'aphront-panel-view-css' => '00dd9b38',
4409+
'aphront-table-view-css' => '00dd9b38',
4410+
'aphront-tokenizer-control-css' => '00dd9b38',
4411+
'aphront-tooltip-css' => '00dd9b38',
4412+
'aphront-typeahead-control-css' => '00dd9b38',
44134413
'differential-changeset-view-css' => 'dd27a69b',
44144414
'differential-core-view-css' => 'dd27a69b',
44154415
'differential-inline-comment-editor' => '48040be9',
@@ -4423,7 +4423,7 @@
44234423
'differential-table-of-contents-css' => 'dd27a69b',
44244424
'diffusion-commit-view-css' => 'c8ce2d88',
44254425
'diffusion-icons-css' => 'c8ce2d88',
4426-
'global-drag-and-drop-css' => '604768b8',
4426+
'global-drag-and-drop-css' => '00dd9b38',
44274427
'inline-comment-summary-css' => 'dd27a69b',
44284428
'javelin-aphlict' => '606f7152',
44294429
'javelin-behavior' => '2dbbb7d1',
@@ -4496,55 +4496,55 @@
44964496
'javelin-util' => '2dbbb7d1',
44974497
'javelin-vector' => '2dbbb7d1',
44984498
'javelin-workflow' => '2dbbb7d1',
4499-
'lightbox-attachment-css' => '604768b8',
4499+
'lightbox-attachment-css' => '00dd9b38',
45004500
'maniphest-task-summary-css' => '06bacb9a',
45014501
'maniphest-transaction-detail-css' => '06bacb9a',
4502-
'phabricator-action-list-view-css' => '604768b8',
4503-
'phabricator-application-launch-view-css' => '604768b8',
4502+
'phabricator-action-list-view-css' => '00dd9b38',
4503+
'phabricator-application-launch-view-css' => '00dd9b38',
45044504
'phabricator-busy' => '606f7152',
45054505
'phabricator-content-source-view-css' => 'dd27a69b',
4506-
'phabricator-core-css' => '604768b8',
4507-
'phabricator-crumbs-view-css' => '604768b8',
4506+
'phabricator-core-css' => '00dd9b38',
4507+
'phabricator-crumbs-view-css' => '00dd9b38',
45084508
'phabricator-drag-and-drop-file-upload' => '48040be9',
45094509
'phabricator-dropdown-menu' => '606f7152',
45104510
'phabricator-file-upload' => '606f7152',
4511-
'phabricator-filetree-view-css' => '604768b8',
4512-
'phabricator-flag-css' => '604768b8',
4513-
'phabricator-form-view-css' => '604768b8',
4514-
'phabricator-header-view-css' => '604768b8',
4511+
'phabricator-filetree-view-css' => '00dd9b38',
4512+
'phabricator-flag-css' => '00dd9b38',
4513+
'phabricator-form-view-css' => '00dd9b38',
4514+
'phabricator-header-view-css' => '00dd9b38',
45154515
'phabricator-hovercard' => '606f7152',
4516-
'phabricator-jump-nav' => '604768b8',
4516+
'phabricator-jump-nav' => '00dd9b38',
45174517
'phabricator-keyboard-shortcut' => '606f7152',
45184518
'phabricator-keyboard-shortcut-manager' => '606f7152',
4519-
'phabricator-main-menu-view' => '604768b8',
4519+
'phabricator-main-menu-view' => '00dd9b38',
45204520
'phabricator-menu-item' => '606f7152',
4521-
'phabricator-nav-view-css' => '604768b8',
4521+
'phabricator-nav-view-css' => '00dd9b38',
45224522
'phabricator-notification' => '606f7152',
4523-
'phabricator-notification-css' => '604768b8',
4524-
'phabricator-notification-menu-css' => '604768b8',
4525-
'phabricator-object-item-list-view-css' => '604768b8',
4523+
'phabricator-notification-css' => '00dd9b38',
4524+
'phabricator-notification-menu-css' => '00dd9b38',
4525+
'phabricator-object-item-list-view-css' => '00dd9b38',
45264526
'phabricator-object-selector-css' => 'dd27a69b',
45274527
'phabricator-phtize' => '606f7152',
45284528
'phabricator-prefab' => '606f7152',
45294529
'phabricator-project-tag-css' => '06bacb9a',
4530-
'phabricator-property-list-view-css' => '604768b8',
4531-
'phabricator-remarkup-css' => '604768b8',
4530+
'phabricator-property-list-view-css' => '00dd9b38',
4531+
'phabricator-remarkup-css' => '00dd9b38',
45324532
'phabricator-shaped-request' => '48040be9',
4533-
'phabricator-side-menu-view-css' => '604768b8',
4534-
'phabricator-standard-page-view' => '604768b8',
4535-
'phabricator-tag-view-css' => '604768b8',
4533+
'phabricator-side-menu-view-css' => '00dd9b38',
4534+
'phabricator-standard-page-view' => '00dd9b38',
4535+
'phabricator-tag-view-css' => '00dd9b38',
45364536
'phabricator-textareautils' => '606f7152',
45374537
'phabricator-tooltip' => '606f7152',
4538-
'phabricator-transaction-view-css' => '604768b8',
4539-
'phabricator-zindex-css' => '604768b8',
4540-
'phui-button-css' => '604768b8',
4541-
'phui-form-css' => '604768b8',
4542-
'phui-icon-view-css' => '604768b8',
4543-
'phui-spacing-css' => '604768b8',
4544-
'sprite-apps-large-css' => '604768b8',
4545-
'sprite-gradient-css' => '604768b8',
4546-
'sprite-icons-css' => '604768b8',
4547-
'sprite-menu-css' => '604768b8',
4548-
'syntax-highlighting-css' => '604768b8',
4538+
'phabricator-transaction-view-css' => '00dd9b38',
4539+
'phabricator-zindex-css' => '00dd9b38',
4540+
'phui-button-css' => '00dd9b38',
4541+
'phui-form-css' => '00dd9b38',
4542+
'phui-icon-view-css' => '00dd9b38',
4543+
'phui-spacing-css' => '00dd9b38',
4544+
'sprite-apps-large-css' => '00dd9b38',
4545+
'sprite-gradient-css' => '00dd9b38',
4546+
'sprite-icons-css' => '00dd9b38',
4547+
'sprite-menu-css' => '00dd9b38',
4548+
'syntax-highlighting-css' => '00dd9b38',
45494549
),
45504550
));

‎src/__phutil_library_map__.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -748,6 +748,8 @@
748748
'PHUIListView' => 'view/phui/PHUIListView.php',
749749
'PHUIListViewTestCase' => 'view/layout/__tests__/PHUIListViewTestCase.php',
750750
'PHUIPagedFormView' => 'view/form/PHUIPagedFormView.php',
751+
'PHUIPinboardItemView' => 'view/phui/PHUIPinboardItemView.php',
752+
'PHUIPinboardView' => 'view/phui/PHUIPinboardView.php',
751753
'PHUIRemarkupPreviewPanel' => 'view/phui/PHUIRemarkupPreviewPanel.php',
752754
'PHUIStatusItemView' => 'view/phui/PHUIStatusItemView.php',
753755
'PHUIStatusListView' => 'view/phui/PHUIStatusListView.php',
@@ -1408,8 +1410,6 @@
14081410
'PhabricatorPhortuneConfigOptions' => 'applications/phortune/option/PhabricatorPhortuneConfigOptions.php',
14091411
'PhabricatorPhrequentConfigOptions' => 'applications/phrequent/config/PhabricatorPhrequentConfigOptions.php',
14101412
'PhabricatorPhrictionConfigOptions' => 'applications/phriction/config/PhabricatorPhrictionConfigOptions.php',
1411-
'PhabricatorPinboardItemView' => 'view/layout/PhabricatorPinboardItemView.php',
1412-
'PhabricatorPinboardView' => 'view/layout/PhabricatorPinboardView.php',
14131413
'PhabricatorPolicies' => 'applications/policy/constants/PhabricatorPolicies.php',
14141414
'PhabricatorPolicy' => 'applications/policy/filter/PhabricatorPolicy.php',
14151415
'PhabricatorPolicyAwareQuery' => 'infrastructure/query/policy/PhabricatorPolicyAwareQuery.php',
@@ -2764,6 +2764,8 @@
27642764
'PHUIListView' => 'AphrontTagView',
27652765
'PHUIListViewTestCase' => 'PhabricatorTestCase',
27662766
'PHUIPagedFormView' => 'AphrontTagView',
2767+
'PHUIPinboardItemView' => 'AphrontView',
2768+
'PHUIPinboardView' => 'AphrontView',
27672769
'PHUIRemarkupPreviewPanel' => 'AphrontTagView',
27682770
'PHUIStatusItemView' => 'AphrontTagView',
27692771
'PHUIStatusListView' => 'AphrontTagView',
@@ -3471,8 +3473,6 @@
34713473
'PhabricatorPhortuneConfigOptions' => 'PhabricatorApplicationConfigOptions',
34723474
'PhabricatorPhrequentConfigOptions' => 'PhabricatorApplicationConfigOptions',
34733475
'PhabricatorPhrictionConfigOptions' => 'PhabricatorApplicationConfigOptions',
3474-
'PhabricatorPinboardItemView' => 'AphrontView',
3475-
'PhabricatorPinboardView' => 'AphrontView',
34763476
'PhabricatorPolicies' => 'PhabricatorPolicyConstants',
34773477
'PhabricatorPolicyAwareQuery' => 'PhabricatorOffsetPagedQuery',
34783478
'PhabricatorPolicyAwareTestQuery' => 'PhabricatorPolicyAwareQuery',

‎src/applications/macro/controller/PhabricatorMacroListController.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@ public function renderResultsList(
3636
$this->getLoadedHandles(),
3737
$author_phids);
3838

39-
$pinboard = new PhabricatorPinboardView();
39+
$pinboard = new PHUIPinboardView();
4040
foreach ($macros as $macro) {
4141
$file = $macro->getFile();
4242

43-
$item = new PhabricatorPinboardItemView();
43+
$item = new PHUIPinboardItemView();
4444
if ($file) {
4545
$item->setImageURI($file->getThumb280x210URI());
4646
$item->setImageSize(280, 210);

‎src/applications/pholio/controller/PholioMockListController.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ public function renderResultsList(
3737
}
3838
$this->loadHandles($author_phids);
3939

40-
$board = new PhabricatorPinboardView();
40+
$board = new PHUIPinboardView();
4141
foreach ($mocks as $mock) {
42-
$item = id(new PhabricatorPinboardItemView())
42+
$item = id(new PHUIPinboardItemView())
4343
->setHeader('M'.$mock->getID().' '.$mock->getName())
4444
->setURI('/M'.$mock->getID())
4545
->setImageURI($mock->getCoverFile()->getThumb280x210URI())

‎src/view/layout/PhabricatorPinboardItemView.php ‎src/view/phui/PHUIPinboardItemView.php

+8-8
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22

3-
final class PhabricatorPinboardItemView extends AphrontView {
3+
final class PHUIPinboardItemView extends AphrontView {
44

55
private $imageURI;
66
private $uri;
@@ -42,7 +42,7 @@ public function render() {
4242
$header = phutil_tag(
4343
'div',
4444
array(
45-
'class' => 'phabricator-pinboard-item-header',
45+
'class' => 'phui-pinboard-item-header',
4646
),
4747
phutil_tag('a', array('href' => $this->uri), $this->header));
4848
}
@@ -51,7 +51,7 @@ public function render() {
5151
'a',
5252
array(
5353
'href' => $this->uri,
54-
'class' => 'phabricator-pinboard-item-image-link',
54+
'class' => 'phui-pinboard-item-image-link',
5555
),
5656
phutil_tag(
5757
'img',
@@ -69,21 +69,21 @@ public function render() {
6969
'span',
7070
array(
7171
'class' =>
72-
'phabricator-pinboard-icon sprite-icons icons-'.$block[0].'-grey',
72+
'phui-pinboard-icon sprite-icons icons-'.$block[0].'-grey',
7373
),
7474
'');
7575
$count = phutil_tag('span', array(), $block[1]);
7676
$icon_list[] = phutil_tag(
7777
'span',
7878
array(
79-
'class' => 'phabricator-pinboard-item-count',
79+
'class' => 'phui-pinboard-item-count',
8080
),
8181
array($icon, $count));
8282
}
8383
$icons = phutil_tag(
8484
'div',
8585
array(
86-
'class' => 'phabricator-pinboard-icons',
86+
'class' => 'phui-pinboard-icons',
8787
),
8888
$icon_list);
8989
}
@@ -93,15 +93,15 @@ public function render() {
9393
$content = phutil_tag(
9494
'div',
9595
array(
96-
'class' => 'phabricator-pinboard-item-content',
96+
'class' => 'phui-pinboard-item-content',
9797
),
9898
$content);
9999
}
100100

101101
return phutil_tag(
102102
'div',
103103
array(
104-
'class' => 'phabricator-pinboard-item-view',
104+
'class' => 'phui-pinboard-item-view',
105105
),
106106
array(
107107
$header,

‎src/view/layout/PhabricatorPinboardView.php ‎src/view/phui/PHUIPinboardView.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22

3-
final class PhabricatorPinboardView extends AphrontView {
3+
final class PHUIPinboardView extends AphrontView {
44

55
private $items = array();
66
private $noDataString;
@@ -10,13 +10,13 @@ public function setNoDataString($no_data_string) {
1010
return $this;
1111
}
1212

13-
public function addItem(PhabricatorPinboardItemView $item) {
13+
public function addItem(PHUIPinboardItemView $item) {
1414
$this->items[] = $item;
1515
return $this;
1616
}
1717

1818
public function render() {
19-
require_celerity_resource('phabricator-pinboard-view-css');
19+
require_celerity_resource('phui-pinboard-view-css');
2020

2121
if (!$this->items) {
2222
$string = nonempty($this->noDataString, pht('No data.'));
@@ -29,7 +29,7 @@ public function render() {
2929
return phutil_tag(
3030
'div',
3131
array(
32-
'class' => 'phabricator-pinboard-view',
32+
'class' => 'phui-pinboard-view',
3333
),
3434
$this->items);
3535
}

‎webroot/rsrc/css/aphront/list-filter-view.css

+5-6
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
box-shadow: 0 1px 2px rgba(0,0,0,0.2);
1717
}
1818

19-
.device-phone .aphront-list-filter-view {
20-
margin: 0;
19+
.device-phone .aphront-list-filter-wrap {
20+
margin: 0 -2px;
2121
}
2222

2323
.aphront-list-filter-view-content .aphront-form-view {
@@ -58,7 +58,7 @@
5858
.device .aphront-list-filter-reveal {
5959
width: 98%;
6060
margin: auto;
61-
padding: 4px 0;
61+
padding: 8px;
6262
}
6363

6464
.aphront-list-filter-reveal a {
@@ -67,9 +67,8 @@
6767
}
6868

6969
.device .aphront-list-filter-reveal a {
70-
margin: 4px auto 0;
71-
float: none;
72-
display: block;
70+
margin: 4px 0;
71+
float: left;
7372
}
7473

7574
.aphront-list-filter-description {

0 commit comments

Comments
 (0)
Failed to load comments.