Skip to content

Commit 9ef0ea9

Browse files
chadlittlechadlittle
committedAug 20, 2013
Remove dust pattern for common bg color.
Summary: Depends on D6769, removes 'dust' and uses a similar color background. Test Plan: Review colors in sandbox. Reviewers: epriestley Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6772
1 parent 751cd54 commit 9ef0ea9

File tree

6 files changed

+49
-79
lines changed

6 files changed

+49
-79
lines changed
 

‎src/__celerity_resource_map__.php

+47-47
Original file line numberDiff line numberDiff line change
@@ -981,7 +981,7 @@
981981
),
982982
'conpherence-menu-css' =>
983983
array(
984-
'uri' => '/res/d250b49c/rsrc/css/application/conpherence/menu.css',
984+
'uri' => '/res/cae40b18/rsrc/css/application/conpherence/menu.css',
985985
'type' => 'css',
986986
'requires' =>
987987
array(
@@ -3063,7 +3063,7 @@
30633063
),
30643064
'phabricator-core-css' =>
30653065
array(
3066-
'uri' => '/res/7736096e/rsrc/css/core/core.css',
3066+
'uri' => '/res/bb4b77f3/rsrc/css/core/core.css',
30673067
'type' => 'css',
30683068
'requires' =>
30693069
array(
@@ -3470,7 +3470,7 @@
34703470
),
34713471
'phabricator-standard-page-view' =>
34723472
array(
3473-
'uri' => '/res/0151b341/rsrc/css/application/base/standard-page-view.css',
3473+
'uri' => '/res/dabd95bf/rsrc/css/application/base/standard-page-view.css',
34743474
'type' => 'css',
34753475
'requires' =>
34763476
array(
@@ -4172,7 +4172,7 @@
41724172
), array(
41734173
'packages' =>
41744174
array(
4175-
'9737ebe0' =>
4175+
'4a060444' =>
41764176
array(
41774177
'name' => 'core.pkg.css',
41784178
'symbols' =>
@@ -4220,7 +4220,7 @@
42204220
40 => 'phabricator-property-list-view-css',
42214221
41 => 'phabricator-tag-view-css',
42224222
),
4223-
'uri' => '/res/pkg/9737ebe0/core.pkg.css',
4223+
'uri' => '/res/pkg/4a060444/core.pkg.css',
42244224
'type' => 'css',
42254225
),
42264226
'4f81c788' =>
@@ -4411,16 +4411,16 @@
44114411
),
44124412
'reverse' =>
44134413
array(
4414-
'aphront-dialog-view-css' => '9737ebe0',
4415-
'aphront-error-view-css' => '9737ebe0',
4416-
'aphront-form-view-css' => '9737ebe0',
4417-
'aphront-list-filter-view-css' => '9737ebe0',
4418-
'aphront-pager-view-css' => '9737ebe0',
4419-
'aphront-panel-view-css' => '9737ebe0',
4420-
'aphront-table-view-css' => '9737ebe0',
4421-
'aphront-tokenizer-control-css' => '9737ebe0',
4422-
'aphront-tooltip-css' => '9737ebe0',
4423-
'aphront-typeahead-control-css' => '9737ebe0',
4414+
'aphront-dialog-view-css' => '4a060444',
4415+
'aphront-error-view-css' => '4a060444',
4416+
'aphront-form-view-css' => '4a060444',
4417+
'aphront-list-filter-view-css' => '4a060444',
4418+
'aphront-pager-view-css' => '4a060444',
4419+
'aphront-panel-view-css' => '4a060444',
4420+
'aphront-table-view-css' => '4a060444',
4421+
'aphront-tokenizer-control-css' => '4a060444',
4422+
'aphront-tooltip-css' => '4a060444',
4423+
'aphront-typeahead-control-css' => '4a060444',
44244424
'differential-changeset-view-css' => '09216861',
44254425
'differential-core-view-css' => '09216861',
44264426
'differential-inline-comment-editor' => 'd07a3bc2',
@@ -4434,7 +4434,7 @@
44344434
'differential-table-of-contents-css' => '09216861',
44354435
'diffusion-commit-view-css' => 'c8ce2d88',
44364436
'diffusion-icons-css' => 'c8ce2d88',
4437-
'global-drag-and-drop-css' => '9737ebe0',
4437+
'global-drag-and-drop-css' => '4a060444',
44384438
'inline-comment-summary-css' => '09216861',
44394439
'javelin-aphlict' => '4f81c788',
44404440
'javelin-behavior' => '2dbbb7d1',
@@ -4507,55 +4507,55 @@
45074507
'javelin-util' => '2dbbb7d1',
45084508
'javelin-vector' => '2dbbb7d1',
45094509
'javelin-workflow' => '2dbbb7d1',
4510-
'lightbox-attachment-css' => '9737ebe0',
4510+
'lightbox-attachment-css' => '4a060444',
45114511
'maniphest-task-summary-css' => '06bacb9a',
45124512
'maniphest-transaction-detail-css' => '06bacb9a',
4513-
'phabricator-action-list-view-css' => '9737ebe0',
4514-
'phabricator-application-launch-view-css' => '9737ebe0',
4513+
'phabricator-action-list-view-css' => '4a060444',
4514+
'phabricator-application-launch-view-css' => '4a060444',
45154515
'phabricator-busy' => '4f81c788',
45164516
'phabricator-content-source-view-css' => '09216861',
4517-
'phabricator-core-css' => '9737ebe0',
4518-
'phabricator-crumbs-view-css' => '9737ebe0',
4517+
'phabricator-core-css' => '4a060444',
4518+
'phabricator-crumbs-view-css' => '4a060444',
45194519
'phabricator-drag-and-drop-file-upload' => 'd07a3bc2',
45204520
'phabricator-dropdown-menu' => '4f81c788',
45214521
'phabricator-file-upload' => '4f81c788',
4522-
'phabricator-filetree-view-css' => '9737ebe0',
4523-
'phabricator-flag-css' => '9737ebe0',
4524-
'phabricator-form-view-css' => '9737ebe0',
4525-
'phabricator-header-view-css' => '9737ebe0',
4522+
'phabricator-filetree-view-css' => '4a060444',
4523+
'phabricator-flag-css' => '4a060444',
4524+
'phabricator-form-view-css' => '4a060444',
4525+
'phabricator-header-view-css' => '4a060444',
45264526
'phabricator-hovercard' => '4f81c788',
4527-
'phabricator-jump-nav' => '9737ebe0',
4527+
'phabricator-jump-nav' => '4a060444',
45284528
'phabricator-keyboard-shortcut' => '4f81c788',
45294529
'phabricator-keyboard-shortcut-manager' => '4f81c788',
4530-
'phabricator-main-menu-view' => '9737ebe0',
4530+
'phabricator-main-menu-view' => '4a060444',
45314531
'phabricator-menu-item' => '4f81c788',
4532-
'phabricator-nav-view-css' => '9737ebe0',
4532+
'phabricator-nav-view-css' => '4a060444',
45334533
'phabricator-notification' => '4f81c788',
4534-
'phabricator-notification-css' => '9737ebe0',
4535-
'phabricator-notification-menu-css' => '9737ebe0',
4536-
'phabricator-object-item-list-view-css' => '9737ebe0',
4534+
'phabricator-notification-css' => '4a060444',
4535+
'phabricator-notification-menu-css' => '4a060444',
4536+
'phabricator-object-item-list-view-css' => '4a060444',
45374537
'phabricator-object-selector-css' => '09216861',
45384538
'phabricator-phtize' => '4f81c788',
45394539
'phabricator-prefab' => '4f81c788',
45404540
'phabricator-project-tag-css' => '06bacb9a',
4541-
'phabricator-property-list-view-css' => '9737ebe0',
4542-
'phabricator-remarkup-css' => '9737ebe0',
4541+
'phabricator-property-list-view-css' => '4a060444',
4542+
'phabricator-remarkup-css' => '4a060444',
45434543
'phabricator-shaped-request' => 'd07a3bc2',
4544-
'phabricator-side-menu-view-css' => '9737ebe0',
4545-
'phabricator-standard-page-view' => '9737ebe0',
4546-
'phabricator-tag-view-css' => '9737ebe0',
4544+
'phabricator-side-menu-view-css' => '4a060444',
4545+
'phabricator-standard-page-view' => '4a060444',
4546+
'phabricator-tag-view-css' => '4a060444',
45474547
'phabricator-textareautils' => '4f81c788',
45484548
'phabricator-tooltip' => '4f81c788',
4549-
'phabricator-transaction-view-css' => '9737ebe0',
4550-
'phabricator-zindex-css' => '9737ebe0',
4551-
'phui-button-css' => '9737ebe0',
4552-
'phui-form-css' => '9737ebe0',
4553-
'phui-icon-view-css' => '9737ebe0',
4554-
'phui-spacing-css' => '9737ebe0',
4555-
'sprite-apps-large-css' => '9737ebe0',
4556-
'sprite-gradient-css' => '9737ebe0',
4557-
'sprite-icons-css' => '9737ebe0',
4558-
'sprite-menu-css' => '9737ebe0',
4559-
'syntax-highlighting-css' => '9737ebe0',
4549+
'phabricator-transaction-view-css' => '4a060444',
4550+
'phabricator-zindex-css' => '4a060444',
4551+
'phui-button-css' => '4a060444',
4552+
'phui-form-css' => '4a060444',
4553+
'phui-icon-view-css' => '4a060444',
4554+
'phui-spacing-css' => '4a060444',
4555+
'sprite-apps-large-css' => '4a060444',
4556+
'sprite-gradient-css' => '4a060444',
4557+
'sprite-icons-css' => '4a060444',
4558+
'sprite-menu-css' => '4a060444',
4559+
'syntax-highlighting-css' => '4a060444',
45604560
),
45614561
));

‎src/applications/base/controller/PhabricatorController.php

-2
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,6 @@ public function buildApplicationPage($view, array $options) {
188188
}
189189

190190
$page->setShowChrome(idx($options, 'chrome', true));
191-
$page->setDust(idx($options, 'dust', false));
192191

193192
$application_menu = $this->buildApplicationMenu();
194193
if ($application_menu) {
@@ -226,7 +225,6 @@ public function didProcessRequest($response) {
226225
$view->appendChild(hsprintf(
227226
'<div style="padding: 2em 0;">%s</div>',
228227
$response->buildResponseString()));
229-
$view->setDust(true);
230228
$response = new AphrontWebpageResponse();
231229
$response->setContent($view->render());
232230
return $response;

‎src/view/page/PhabricatorStandardPageView.php

-14
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView {
1212
private $glyph;
1313
private $menuContent;
1414
private $showChrome = true;
15-
private $layDownSomeDust = false;
1615
private $disableConsole;
1716
private $searchDefaultScope;
1817
private $pageObjects = array();
@@ -55,19 +54,10 @@ public function setShowChrome($show_chrome) {
5554
return $this;
5655
}
5756

58-
public function setDust($is_dusty) {
59-
$this->layDownSomeDust = $is_dusty;
60-
return $this;
61-
}
62-
6357
public function getShowChrome() {
6458
return $this->showChrome;
6559
}
6660

67-
public function getDust() {
68-
return $this->layDownSomeDust;
69-
}
70-
7161
public function setSearchDefaultScope($search_default_scope) {
7262
$this->searchDefaultScope = $search_default_scope;
7363
return $this;
@@ -407,10 +397,6 @@ protected function getBodyClasses() {
407397
$classes[] = 'phabricator-chromeless-page';
408398
}
409399

410-
if ($this->getDust()) {
411-
$classes[] = 'make-me-sneeze';
412-
}
413-
414400
$agent = AphrontRequest::getHTTPHeader('User-Agent');
415401

416402
// Try to guess the device resolution based on UA strings to avoid a flash

‎webroot/rsrc/css/application/base/standard-page-view.css

-4
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@
22
* @provides phabricator-standard-page-view
33
*/
44

5-
.phabricator-standard-page {
6-
background: #ffffff;
7-
}
8-
95
.phabricator-anchor-view,
106
.phabricator-anchor-navigation-marker {
117
position: absolute;

‎webroot/rsrc/css/application/conpherence/menu.css

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
left: 0;
99
right: 0;
1010
top: 44px;
11+
background: #fff;
1112
}
1213

1314
.conpherence-layout .conpherence-no-threads {

‎webroot/rsrc/css/core/core.css

+1-12
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,6 @@ p, blockquote, th, td, button {
2929
border: 0;
3030
}
3131

32-
body.make-me-sneeze {
33-
background: #e9eaed url('/rsrc/image/texture/dust_background.jpeg');
34-
}
35-
36-
.make-me-sneeze .phabricator-standard-page {
37-
background: transparent;
38-
}
39-
4032
table {
4133
border-collapse: collapse;
4234
border-spacing: 0;
@@ -73,10 +65,7 @@ body {
7365
direction: ltr;
7466
text-align: left;
7567
unicode-bidi: embed;
76-
}
77-
78-
body.phabricator-chromeless-page {
79-
background: #ffffff;
68+
background: #EBECEE;
8069
}
8170

8271
textarea {

0 commit comments

Comments
 (0)
Failed to load comments.