Skip to content

Commit 9be7a94

Browse files
chadlittlechadlittle
committed
Move PHUIFormBoxView to PHUIObjectBoxView
Summary: I'd like to reuse this for other content areas, renaming for now. This might be weird to keep setForm, but I can fix that later if we need. Test Plan: reload a few forms in maniphest, projects, differential Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7120
1 parent 225a38c commit 9be7a94

File tree

55 files changed

+119
-112
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+119
-112
lines changed

‎src/__celerity_resource_map__.php

Lines changed: 44 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -3756,7 +3756,7 @@
37563756
),
37573757
'phui-form-view-css' =>
37583758
array(
3759-
'uri' => '/res/5786628c/rsrc/css/phui/phui-form-view.css',
3759+
'uri' => '/res/d87bdbeb/rsrc/css/phui/phui-form-view.css',
37603760
'type' => 'css',
37613761
'requires' =>
37623762
array(
@@ -4162,7 +4162,7 @@
41624162
), array(
41634163
'packages' =>
41644164
array(
4165-
'03a782d0' =>
4165+
'15affac5' =>
41664166
array(
41674167
'name' => 'core.pkg.css',
41684168
'symbols' =>
@@ -4209,7 +4209,7 @@
42094209
39 => 'phabricator-property-list-view-css',
42104210
40 => 'phabricator-tag-view-css',
42114211
),
4212-
'uri' => '/res/pkg/03a782d0/core.pkg.css',
4212+
'uri' => '/res/pkg/15affac5/core.pkg.css',
42134213
'type' => 'css',
42144214
),
42154215
'8977e356' =>
@@ -4399,15 +4399,15 @@
43994399
),
44004400
'reverse' =>
44014401
array(
4402-
'aphront-dialog-view-css' => '03a782d0',
4403-
'aphront-error-view-css' => '03a782d0',
4404-
'aphront-list-filter-view-css' => '03a782d0',
4405-
'aphront-pager-view-css' => '03a782d0',
4406-
'aphront-panel-view-css' => '03a782d0',
4407-
'aphront-table-view-css' => '03a782d0',
4408-
'aphront-tokenizer-control-css' => '03a782d0',
4409-
'aphront-tooltip-css' => '03a782d0',
4410-
'aphront-typeahead-control-css' => '03a782d0',
4402+
'aphront-dialog-view-css' => '15affac5',
4403+
'aphront-error-view-css' => '15affac5',
4404+
'aphront-list-filter-view-css' => '15affac5',
4405+
'aphront-pager-view-css' => '15affac5',
4406+
'aphront-panel-view-css' => '15affac5',
4407+
'aphront-table-view-css' => '15affac5',
4408+
'aphront-tokenizer-control-css' => '15affac5',
4409+
'aphront-tooltip-css' => '15affac5',
4410+
'aphront-typeahead-control-css' => '15affac5',
44114411
'differential-changeset-view-css' => '44bfe40c',
44124412
'differential-core-view-css' => '44bfe40c',
44134413
'differential-inline-comment-editor' => '5e9e5c4e',
@@ -4421,7 +4421,7 @@
44214421
'differential-table-of-contents-css' => '44bfe40c',
44224422
'diffusion-commit-view-css' => 'c8ce2d88',
44234423
'diffusion-icons-css' => 'c8ce2d88',
4424-
'global-drag-and-drop-css' => '03a782d0',
4424+
'global-drag-and-drop-css' => '15affac5',
44254425
'inline-comment-summary-css' => '44bfe40c',
44264426
'javelin-aphlict' => '8977e356',
44274427
'javelin-behavior' => '9564fa17',
@@ -4494,54 +4494,54 @@
44944494
'javelin-util' => '9564fa17',
44954495
'javelin-vector' => '9564fa17',
44964496
'javelin-workflow' => '9564fa17',
4497-
'lightbox-attachment-css' => '03a782d0',
4497+
'lightbox-attachment-css' => '15affac5',
44984498
'maniphest-task-summary-css' => '49898640',
4499-
'phabricator-action-list-view-css' => '03a782d0',
4500-
'phabricator-application-launch-view-css' => '03a782d0',
4499+
'phabricator-action-list-view-css' => '15affac5',
4500+
'phabricator-application-launch-view-css' => '15affac5',
45014501
'phabricator-busy' => '8977e356',
45024502
'phabricator-content-source-view-css' => '44bfe40c',
4503-
'phabricator-core-css' => '03a782d0',
4504-
'phabricator-crumbs-view-css' => '03a782d0',
4503+
'phabricator-core-css' => '15affac5',
4504+
'phabricator-crumbs-view-css' => '15affac5',
45054505
'phabricator-drag-and-drop-file-upload' => '5e9e5c4e',
45064506
'phabricator-dropdown-menu' => '8977e356',
45074507
'phabricator-file-upload' => '8977e356',
4508-
'phabricator-filetree-view-css' => '03a782d0',
4509-
'phabricator-flag-css' => '03a782d0',
4508+
'phabricator-filetree-view-css' => '15affac5',
4509+
'phabricator-flag-css' => '15affac5',
45104510
'phabricator-hovercard' => '8977e356',
4511-
'phabricator-jump-nav' => '03a782d0',
4511+
'phabricator-jump-nav' => '15affac5',
45124512
'phabricator-keyboard-shortcut' => '8977e356',
45134513
'phabricator-keyboard-shortcut-manager' => '8977e356',
4514-
'phabricator-main-menu-view' => '03a782d0',
4514+
'phabricator-main-menu-view' => '15affac5',
45154515
'phabricator-menu-item' => '8977e356',
4516-
'phabricator-nav-view-css' => '03a782d0',
4516+
'phabricator-nav-view-css' => '15affac5',
45174517
'phabricator-notification' => '8977e356',
4518-
'phabricator-notification-css' => '03a782d0',
4519-
'phabricator-notification-menu-css' => '03a782d0',
4518+
'phabricator-notification-css' => '15affac5',
4519+
'phabricator-notification-menu-css' => '15affac5',
45204520
'phabricator-object-selector-css' => '44bfe40c',
45214521
'phabricator-phtize' => '8977e356',
45224522
'phabricator-prefab' => '8977e356',
45234523
'phabricator-project-tag-css' => '49898640',
4524-
'phabricator-property-list-view-css' => '03a782d0',
4525-
'phabricator-remarkup-css' => '03a782d0',
4524+
'phabricator-property-list-view-css' => '15affac5',
4525+
'phabricator-remarkup-css' => '15affac5',
45264526
'phabricator-shaped-request' => '5e9e5c4e',
4527-
'phabricator-side-menu-view-css' => '03a782d0',
4528-
'phabricator-standard-page-view' => '03a782d0',
4529-
'phabricator-tag-view-css' => '03a782d0',
4527+
'phabricator-side-menu-view-css' => '15affac5',
4528+
'phabricator-standard-page-view' => '15affac5',
4529+
'phabricator-tag-view-css' => '15affac5',
45304530
'phabricator-textareautils' => '8977e356',
45314531
'phabricator-tooltip' => '8977e356',
4532-
'phabricator-transaction-view-css' => '03a782d0',
4533-
'phabricator-zindex-css' => '03a782d0',
4534-
'phui-button-css' => '03a782d0',
4535-
'phui-form-css' => '03a782d0',
4536-
'phui-form-view-css' => '03a782d0',
4537-
'phui-header-view-css' => '03a782d0',
4538-
'phui-icon-view-css' => '03a782d0',
4539-
'phui-object-item-list-view-css' => '03a782d0',
4540-
'phui-spacing-css' => '03a782d0',
4541-
'sprite-apps-large-css' => '03a782d0',
4542-
'sprite-gradient-css' => '03a782d0',
4543-
'sprite-icons-css' => '03a782d0',
4544-
'sprite-menu-css' => '03a782d0',
4545-
'syntax-highlighting-css' => '03a782d0',
4532+
'phabricator-transaction-view-css' => '15affac5',
4533+
'phabricator-zindex-css' => '15affac5',
4534+
'phui-button-css' => '15affac5',
4535+
'phui-form-css' => '15affac5',
4536+
'phui-form-view-css' => '15affac5',
4537+
'phui-header-view-css' => '15affac5',
4538+
'phui-icon-view-css' => '15affac5',
4539+
'phui-object-item-list-view-css' => '15affac5',
4540+
'phui-spacing-css' => '15affac5',
4541+
'sprite-apps-large-css' => '15affac5',
4542+
'sprite-gradient-css' => '15affac5',
4543+
'sprite-icons-css' => '15affac5',
4544+
'sprite-menu-css' => '15affac5',
4545+
'syntax-highlighting-css' => '15affac5',
45464546
),
45474547
));

‎src/__phutil_library_map__.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -752,7 +752,6 @@
752752
'PHUIDocumentView' => 'view/phui/PHUIDocumentView.php',
753753
'PHUIFeedStoryExample' => 'applications/uiexample/examples/PHUIFeedStoryExample.php',
754754
'PHUIFeedStoryView' => 'view/phui/PHUIFeedStoryView.php',
755-
'PHUIFormBoxView' => 'view/form/PHUIFormBoxView.php',
756755
'PHUIFormDividerControl' => 'view/form/control/PHUIFormDividerControl.php',
757756
'PHUIFormFreeformDateControl' => 'view/form/control/PHUIFormFreeformDateControl.php',
758757
'PHUIFormLayoutView' => 'view/form/PHUIFormLayoutView.php',
@@ -765,6 +764,7 @@
765764
'PHUIListItemView' => 'view/phui/PHUIListItemView.php',
766765
'PHUIListView' => 'view/phui/PHUIListView.php',
767766
'PHUIListViewTestCase' => 'view/layout/__tests__/PHUIListViewTestCase.php',
767+
'PHUIObjectBoxView' => 'view/phui/PHUIObjectBoxView.php',
768768
'PHUIObjectItemListExample' => 'applications/uiexample/examples/PHUIObjectItemListExample.php',
769769
'PHUIObjectItemListView' => 'view/phui/PHUIObjectItemListView.php',
770770
'PHUIObjectItemView' => 'view/phui/PHUIObjectItemView.php',
@@ -2841,7 +2841,6 @@
28412841
'PHUIDocumentView' => 'AphrontTagView',
28422842
'PHUIFeedStoryExample' => 'PhabricatorUIExample',
28432843
'PHUIFeedStoryView' => 'AphrontView',
2844-
'PHUIFormBoxView' => 'AphrontView',
28452844
'PHUIFormDividerControl' => 'AphrontFormControl',
28462845
'PHUIFormFreeformDateControl' => 'AphrontFormControl',
28472846
'PHUIFormLayoutView' => 'AphrontView',
@@ -2854,6 +2853,7 @@
28542853
'PHUIListItemView' => 'AphrontTagView',
28552854
'PHUIListView' => 'AphrontTagView',
28562855
'PHUIListViewTestCase' => 'PhabricatorTestCase',
2856+
'PHUIObjectBoxView' => 'AphrontView',
28572857
'PHUIObjectItemListExample' => 'PhabricatorUIExample',
28582858
'PHUIObjectItemListView' => 'AphrontTagView',
28592859
'PHUIObjectItemView' => 'AphrontTagView',

‎src/applications/auth/controller/config/PhabricatorAuthEditController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ public function processRequest() {
280280
->setTransactions($xactions);
281281
}
282282

283-
$form_box = id(new PHUIFormBoxView())
283+
$form_box = id(new PHUIObjectBoxView())
284284
->setHeaderText($title)
285285
->setFormError($errors)
286286
->setForm($form);

‎src/applications/auth/controller/config/PhabricatorAuthNewController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public function processRequest() {
8181
->addCancelButton($this->getApplicationURI())
8282
->setValue(pht('Continue')));
8383

84-
$form_box = id(new PHUIFormBoxView())
84+
$form_box = id(new PHUIObjectBoxView())
8585
->setHeaderText(pht('Add Authentication Provider'))
8686
->setFormError($errors)
8787
->setForm($form);

‎src/applications/calendar/controller/PhabricatorCalendarEditStatusController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ public function processRequest() {
163163
}
164164
$form->appendChild($submit);
165165

166-
$form_box = id(new PHUIFormBoxView())
166+
$form_box = id(new PHUIObjectBoxView())
167167
->setHeaderText($page_title)
168168
->setFormError($error_view)
169169
->setForm($form);

‎src/applications/conduit/controller/PhabricatorConduitConsoleController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public function processRequest() {
110110
->addCancelButton($this->getApplicationURI())
111111
->setValue('Call Method'));
112112

113-
$form_box = id(new PHUIFormBoxView())
113+
$form_box = id(new PHUIObjectBoxView())
114114
->setHeaderText($method->getAPIMethodName())
115115
->setFormError($status_view)
116116
->setForm($form);

‎src/applications/config/controller/PhabricatorConfigEditController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ public function processRequest() {
193193
$title = pht('Edit %s', $this->key);
194194
$short = pht('Edit');
195195

196-
$form_box = id(new PHUIFormBoxView())
196+
$form_box = id(new PHUIObjectBoxView())
197197
->setHeaderText($title)
198198
->setFormError($error_view)
199199
->setForm($form);

‎src/applications/countdown/controller/PhabricatorCountdownEditController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public function processRequest() {
128128
->addCancelButton($cancel_uri)
129129
->setValue($submit_label));
130130

131-
$form_box = id(new PHUIFormBoxView())
131+
$form_box = id(new PHUIObjectBoxView())
132132
->setHeaderText($page_title)
133133
->setFormError($error_view)
134134
->setForm($form);

‎src/applications/differential/controller/DifferentialDiffCreateController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public function processRequest() {
8282
->addCancelButton($cancel_uri)
8383
->setValue(pht("Create Diff")));
8484

85-
$form_box = id(new PHUIFormBoxView())
85+
$form_box = id(new PHUIObjectBoxView())
8686
->setHeaderText(pht('Create New Diff'))
8787
->setFormError($errors)
8888
->setForm($form);

‎src/applications/differential/controller/DifferentialRevisionEditController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ public function processRequest() {
164164
$title = pht('Create New Differential Revision');
165165
}
166166

167-
$form_box = id(new PHUIFormBoxView())
167+
$form_box = id(new PHUIObjectBoxView())
168168
->setHeaderText($title)
169169
->setFormError($error_view)
170170
->setForm($form);

‎src/applications/diffusion/controller/DiffusionCommitEditController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public function processRequest() {
8181
->addCancelButton('/r'.$callsign.$commit->getCommitIdentifier());
8282
$form->appendChild($submit);
8383

84-
$form_box = id(new PHUIFormBoxView())
84+
$form_box = id(new PHUIObjectBoxView())
8585
->setHeaderText($page_title)
8686
->setForm($form);
8787

‎src/applications/diffusion/controller/DiffusionRepositoryEditPolicyController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public function processRequest() {
9595
->setValue(pht('Save Policies'))
9696
->addCancelButton($edit_uri));
9797

98-
$form_box = id(new PHUIFormBoxView())
98+
$form_box = id(new PHUIObjectBoxView())
9999
->setHeaderText($title)
100100
->setForm($form);
101101

‎src/applications/files/controller/PhabricatorFileUploadController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public function processRequest() {
7676
$global_upload = id(new PhabricatorGlobalUploadTargetView())
7777
->setShowIfSupportedID($support_id);
7878

79-
$form_box = id(new PHUIFormBoxView())
79+
$form_box = id(new PHUIObjectBoxView())
8080
->setHeaderText($title)
8181
->setFormError($errors)
8282
->setForm($form);

‎src/applications/herald/controller/HeraldNewController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public function processRequest() {
6969
->setValue(pht('Create Rule'))
7070
->addCancelButton($this->getApplicationURI()));
7171

72-
$form_box = id(new PHUIFormBoxView())
72+
$form_box = id(new PHUIObjectBoxView())
7373
->setHeaderText(pht('Create Herald Rule'))
7474
->setForm($form);
7575

‎src/applications/herald/controller/HeraldRuleController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ public function processRequest() {
182182
? pht('Edit Herald Rule')
183183
: pht('Create Herald Rule');
184184

185-
$form_box = id(new PHUIFormBoxView())
185+
$form_box = id(new PHUIObjectBoxView())
186186
->setHeaderText($title)
187187
->setFormError($error_view)
188188
->setForm($form);

‎src/applications/legalpad/controller/LegalpadDocumentEditController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ public function processRequest() {
167167
$form
168168
->appendChild($submit);
169169

170-
$form_box = id(new PHUIFormBoxView())
170+
$form_box = id(new PHUIObjectBoxView())
171171
->setHeaderText($title)
172172
->setFormError($error_view)
173173
->setForm($form);

‎src/applications/macro/controller/PhabricatorMacroEditController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,12 +257,12 @@ public function processRequest() {
257257
id(new AphrontFormSubmitControl())
258258
->setValue(pht('Upload File')));
259259

260-
$upload = id(new PHUIFormBoxView())
260+
$upload = id(new PHUIObjectBoxView())
261261
->setHeaderText(pht('Upload New File'))
262262
->setForm($upload_form);
263263
}
264264

265-
$form_box = id(new PHUIFormBoxView())
265+
$form_box = id(new PHUIObjectBoxView())
266266
->setHeaderText($title)
267267
->setFormError($error_view)
268268
->setForm($form);

‎src/applications/mailinglists/controller/PhabricatorMailingListsEditController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ public function processRequest() {
126126
->setName(pht('Create Mailing List')));
127127
}
128128

129-
$form_box = id(new PHUIFormBoxView())
129+
$form_box = id(new PHUIObjectBoxView())
130130
->setHeaderText($page_title)
131131
->setFormError($error_view)
132132
->setForm($form);

‎src/applications/maniphest/controller/ManiphestBatchEditController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ public function processRequest() {
140140
id(new PhabricatorCrumbView())
141141
->setName($title));
142142

143-
$form_box = id(new PHUIFormBoxView())
143+
$form_box = id(new PHUIObjectBoxView())
144144
->setHeaderText(pht('Batch Edit Tasks'))
145145
->setForm($form);
146146

‎src/applications/maniphest/controller/ManiphestTaskEditController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,7 @@ public function processRequest() {
526526
->addCancelButton($cancel_uri)
527527
->setValue($button_name));
528528

529-
$form_box = id(new PHUIFormBoxView())
529+
$form_box = id(new PHUIObjectBoxView())
530530
->setHeaderText($header_name)
531531
->setFormError($error_view)
532532
->setForm($form);

‎src/applications/owners/controller/PhabricatorOwnersEditController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ public function processRequest() {
251251
->addCancelButton($cancel_uri)
252252
->setValue(pht('Save Package')));
253253

254-
$form_box = id(new PHUIFormBoxView())
254+
$form_box = id(new PHUIObjectBoxView())
255255
->setHeaderText($title)
256256
->setFormError($error_view)
257257
->setForm($form);

‎src/applications/paste/controller/PhabricatorPasteEditController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ public function processRequest() {
205205

206206
$form->appendChild($submit);
207207

208-
$form_box = id(new PHUIFormBoxView())
208+
$form_box = id(new PHUIObjectBoxView())
209209
->setHeaderText($title)
210210
->setFormError($error_view)
211211
->setForm($form);

0 commit comments

Comments
 (0)