Autoscroll sidebar

vrana · vrana · commit 3df0cfa64176 · 2012-09-20T11:18:45.000-07:00
Summary: If the ToC in sidebar is long then the active file can be under the fold when we highlight it. This also saves some CPU cycles because it highlights only after scrolling of the main window and not in the elements. Test Plan: Scrolled on a long diff. Scrolled the ToC. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3473
diff --git a/webroot/rsrc/js/application/core/behavior-active-nav.js b/webroot/rsrc/js/application/core/behavior-active-nav.js
@@ -28,8 +28,11 @@ JX.behavior('phabricator-active-nav', function(config) {
         link,
         'phabricator-active-nav-focus',
         selected);
+      if (selected && link.scrollIntoView) {
+        link.scrollIntoView(false);
+      }
     }
-  }
+  };
 
 
   /**
@@ -72,15 +75,24 @@ JX.behavior('phabricator-active-nav', function(config) {
 
     // If we get above the first marker, select it.
     selectnav(active && JX.Stratcom.getData(active).anchor);
-  }
+  };
 
   var pending = null;
   var onviewportchange = function(e) {
     pending && clearTimeout(pending);
     pending = setTimeout(updateposition, 100);
-  }
+  };
+
+  var onscroll = function(e) {
+    if (e.getNode('tag:body')) {
+      // If we are inside <body> then it means we just scrolled some <textarea>
+      // or <div style="overflow: scroll;">. We are interested only in window.
+      return;
+    }
+    onviewportchange(e);
+  };
 
-  JX.Stratcom.listen('scroll', null, onviewportchange);
+  JX.Stratcom.listen('scroll', null, onscroll);
   JX.Stratcom.listen('resize', null, onviewportchange);
   JX.Stratcom.listen('hashchange', null, onviewportchange);
 });
