Add a test to verify that all routing maps are plausibly valid, and remove some dead routes

Summary:
Previously, see D20999. See also <https://discourse.phabricator-community.org/t/the-phutil-library-phutil-has-not-been-loaded/3543/>.

There are a couple of dead "Config" routes after recent changes. Add test coverage to make sure routes all point somewhere valid, then remove all the dead routes that turned up.

Test Plan: Ran tests, saw failures. Removed dead routes, got clean tests.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Differential Revision: https://secure.phabricator.com/D21000

Author: epriestley

src/__phutil_library_map__.php

@@ -275,6 +275,7 @@
     'AphrontResponse' => 'aphront/response/AphrontResponse.php',
     'AphrontResponseProducerInterface' => 'aphront/interface/AphrontResponseProducerInterface.php',
     'AphrontRoutingMap' => 'aphront/site/AphrontRoutingMap.php',
+    'AphrontRoutingMapTestCase' => 'aphront/__tests__/AphrontRoutingMapTestCase.php',
     'AphrontRoutingResult' => 'aphront/site/AphrontRoutingResult.php',
     'AphrontSchemaQueryException' => 'infrastructure/storage/exception/AphrontSchemaQueryException.php',
     'AphrontScopedUnguardedWriteCapability' => 'aphront/writeguard/AphrontScopedUnguardedWriteCapability.php',
@@ -6283,6 +6284,7 @@
     'AphrontRequestTestCase' => 'PhabricatorTestCase',
     'AphrontResponse' => 'Phobject',
     'AphrontRoutingMap' => 'Phobject',
+    'AphrontRoutingMapTestCase' => 'PhabricatorTestCase',
     'AphrontRoutingResult' => 'Phobject',
     'AphrontSchemaQueryException' => 'AphrontQueryException',
     'AphrontScopedUnguardedWriteCapability' => 'Phobject',

src/aphront/__tests__/AphrontRoutingMapTestCase.php

@@ -0,0 +1,85 @@
+<?php
+
+final class AphrontRoutingMapTestCase
+  extends PhabricatorTestCase {
+
+  public function testRoutingMaps() {
+    $count = 0;
+
+    $sites = AphrontSite::getAllSites();
+    foreach ($sites as $site) {
+      $maps = $site->getRoutingMaps();
+      foreach ($maps as $map) {
+        foreach ($map->getRoutes() as $rule => $value) {
+          $this->assertRoutable($site, $map, array(), $rule, $value);
+          $count++;
+        }
+      }
+    }
+
+    if (!$count) {
+      $this->assertSkipped(
+        pht('No sites define any routing rules.'));
+    }
+  }
+
+  private function assertRoutable(
+    AphrontSite $site,
+    AphrontRoutingMap $map,
+    array $path,
+    $rule,
+    $value) {
+
+    $path[] = $rule;
+
+    $site_description = $site->getDescription();
+    $rule_path = implode(' > ', $path);
+
+    $pattern = implode('', $path);
+    $pattern = '('.$pattern.')';
+    $ok = @preg_match($pattern, '');
+
+    $this->assertTrue(
+      ($ok !== false),
+      pht(
+        'Routing rule ("%s", for site "%s") does not compile into a '.
+        'valid regular expression.',
+        $rule_path,
+        $site_description));
+
+    if (is_array($value)) {
+      $this->assertTrue(
+        (count($value) > 0),
+        pht(
+          'Routing rule ("%s", for site "%s") does not have any targets.',
+          $rule_path,
+          $site_description));
+
+      foreach ($value as $sub_rule => $sub_value) {
+        $this->assertRoutable($site, $map, $path, $sub_rule, $sub_value);
+      }
+      return;
+    }
+
+    if (is_string($value)) {
+      $this->assertTrue(
+        class_exists($value),
+        pht(
+          'Routing rule ("%s", for site "%s") points at controller ("%s") '.
+          'which does not exist.',
+          $rule_path,
+          $site_description,
+          $value));
+      return;
+    }
+
+    $this->assertFailure(
+      pht(
+        'Routing rule ("%s", for site "%s") points at unknown value '.
+        '(of type "%s"), expected a controller class name string.',
+        $rule_path,
+        $site_description,
+        phutil_describe_type($value)));
+  }
+
+}

src/applications/config/application/PhabricatorConfigApplication.php

@@ -38,11 +38,7 @@ public function getRoutes() {
     return array(
       '/config/' => array(
         '' => 'PhabricatorConfigConsoleController',
-        'application/' => 'PhabricatorConfigApplicationController',
-        'all/' => 'PhabricatorConfigAllController',
-        'history/' => 'PhabricatorConfigHistoryController',
         'edit/(?P<key>[\w\.\-]+)/' => 'PhabricatorConfigEditController',
-        'group/(?P<key>[^/]+)/' => 'PhabricatorConfigGroupController',
         'database/'.
           '(?:(?P<ref>[^/]+)/'.
           '(?:(?P<database>[^/]+)/'.

src/applications/countdown/application/PhabricatorCountdownApplication.php

@@ -42,8 +42,6 @@ public function getRoutes() {
       '/countdown/' => array(
         '(?:query/(?P<queryKey>[^/]+)/)?'
           => 'PhabricatorCountdownListController',
-        'comment/(?P<id>[1-9]\d*)/'
-          => 'PhabricatorCountdownCommentController',
         $this->getEditRoutePattern('edit/')
           => 'PhabricatorCountdownEditController',
       ),

src/applications/differential/application/PhabricatorDifferentialApplication.php

@@ -76,11 +76,7 @@ public function getRoutes() {
             => 'DifferentialRevisionInlinesController',
         ),
         'comment/' => array(
-          'preview/(?P<id>[1-9]\d*)/' => 'DifferentialCommentPreviewController',
-          'save/(?P<id>[1-9]\d*)/' => 'DifferentialCommentSaveController',
           'inline/' => array(
-            'preview/(?P<id>[1-9]\d*)/'
-              => 'DifferentialInlineCommentPreviewController',
             'edit/(?P<id>[1-9]\d*)/'
               => 'DifferentialInlineCommentEditController',
           ),

src/applications/files/application/PhabricatorFilesApplication.php

@@ -81,7 +81,6 @@ public function getRoutes() {
         'upload/' => 'PhabricatorFileUploadController',
         'dropupload/' => 'PhabricatorFileDropUploadController',
         'compose/' => 'PhabricatorFileComposeController',
-        'comment/(?P<id>[1-9]\d*)/' => 'PhabricatorFileCommentController',
         'thread/(?P<phid>[^/]+)/' => 'PhabricatorFileLightboxController',
         'delete/(?P<id>[1-9]\d*)/' => 'PhabricatorFileDeleteController',
         $this->getEditRoutePattern('edit/')

src/applications/harbormaster/application/PhabricatorHarbormasterApplication.php

@@ -81,7 +81,6 @@ public function getRoutes() {
           $this->getQueryRoutePattern() => 'HarbormasterPlanListController',
           $this->getEditRoutePattern('edit/')
             => 'HarbormasterPlanEditController',
-          'order/(?:(?P<id>\d+)/)?' => 'HarbormasterPlanOrderController',
           'disable/(?P<id>\d+)/' => 'HarbormasterPlanDisableController',
           'behavior/(?P<id>\d+)/(?P<behaviorKey>[^/]+)/' =>
              'HarbormasterPlanBehaviorController',

src/applications/people/application/PhabricatorPeopleApplication.php

@@ -81,8 +81,6 @@ public function getRoutes() {
       ),
       '/p/(?P<username>[\w._-]+)/' => array(
         '' => 'PhabricatorPeopleProfileViewController',
-        'item/' => $this->getProfileMenuRouting(
-          'PhabricatorPeopleProfileMenuController'),
       ),
     );
   }

src/applications/phame/application/PhabricatorPhameApplication.php

@@ -49,7 +49,6 @@ public function getRoutes() {
           'view/(?P<id>\d+)/(?:(?P<slug>[^/]+)/)?' => 'PhamePostViewController',
           '(?P<action>publish|unpublish)/(?P<id>\d+)/'
             => 'PhamePostPublishController',
-          'preview/(?P<id>\d+)/' => 'PhamePostPreviewController',
           'preview/' => 'PhabricatorMarkupPreviewController',
           'move/(?P<id>\d+)/' => 'PhamePostMoveController',
           'archive/(?P<id>\d+)/' => 'PhamePostArchiveController',
@@ -66,20 +65,7 @@ public function getRoutes() {
           'picture/(?P<id>[1-9]\d*)/' => 'PhameBlogProfilePictureController',
           'header/(?P<id>[1-9]\d*)/' => 'PhameBlogHeaderPictureController',
         ),
-      ) + $this->getResourceSubroutes(),
-    );
-  }
-
-  public function getResourceRoutes() {
-    return array(
-      '/phame/' => $this->getResourceSubroutes(),
-    );
-  }
-
-  private function getResourceSubroutes() {
-    return array(
-      'r/(?P<id>\d+)/(?P<hash>[^/]+)/(?P<name>.*)' =>
-        'PhameResourceController',
+      ),
     );
   }
 

src/applications/phortune/application/PhabricatorPhortuneApplication.php

@@ -101,11 +101,8 @@ public function getRoutes() {
         'product/' => array(
           '' => 'PhortuneProductListController',
           'view/(?P<id>\d+)/' => 'PhortuneProductViewController',
-          'edit/(?:(?P<id>\d+)/)?' => 'PhortuneProductEditController',
         ),
         'provider/' => array(
-          'edit/(?:(?P<id>\d+)/)?' => 'PhortuneProviderEditController',
-          'disable/(?P<id>\d+)/' => 'PhortuneProviderDisableController',
           '(?P<id>\d+)/(?P<action>[^/]+)/'
             => 'PhortuneProviderActionController',
         ),

src/applications/search/application/PhabricatorSearchApplication.php

@@ -30,7 +30,6 @@ public function getRoutes() {
     return array(
       '/search/' => array(
         '(?:query/(?P<queryKey>[^/]+)/)?' => 'PhabricatorSearchController',
-        'index/(?P<phid>[^/]+)/' => 'PhabricatorSearchIndexController',
         'hovercard/'
           => 'PhabricatorSearchHovercardController',
         'handle/(?P<phid>[^/]+)/'