Break IRCSymbolHandler from IRCObjectNameHandler

Summary: Allows to easily disable responding to "where is..."

Test Plan: Run ircbot with and without the handler

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4444

Author: dctrwatson

resources/ircbot/example_config.json

@@ -8,6 +8,7 @@
   "handlers" : [
     "PhabricatorIRCProtocolHandler",
     "PhabricatorIRCObjectNameHandler",
+    "PhabricatorIRCSymbolHandler",
     "PhabricatorIRCLogHandler",
     "PhabricatorIRCWhatsNewHandler",
     "PhabricatorIRCDifferentialNotificationHandler",

src/__phutil_library_map__.php

@@ -888,6 +888,7 @@
     'PhabricatorIRCMessage' => 'infrastructure/daemon/irc/PhabricatorIRCMessage.php',
     'PhabricatorIRCObjectNameHandler' => 'infrastructure/daemon/irc/handler/PhabricatorIRCObjectNameHandler.php',
     'PhabricatorIRCProtocolHandler' => 'infrastructure/daemon/irc/handler/PhabricatorIRCProtocolHandler.php',
+    'PhabricatorIRCSymbolHandler' => 'infrastructure/daemon/irc/handler/PhabricatorIRCSymbolHandler.php',
     'PhabricatorIRCWhatsNewHandler' => 'infrastructure/daemon/irc/handler/PhabricatorIRCWhatsNewHandler.php',
     'PhabricatorImageTransformer' => 'applications/files/PhabricatorImageTransformer.php',
     'PhabricatorInfrastructureTestCase' => 'infrastructure/__tests__/PhabricatorInfrastructureTestCase.php',
@@ -2254,6 +2255,7 @@
     'PhabricatorIRCMacroHandler' => 'PhabricatorIRCHandler',
     'PhabricatorIRCObjectNameHandler' => 'PhabricatorIRCHandler',
     'PhabricatorIRCProtocolHandler' => 'PhabricatorIRCHandler',
+    'PhabricatorIRCSymbolHandler' => 'PhabricatorIRCHandler',
     'PhabricatorIRCWhatsNewHandler' => 'PhabricatorIRCHandler',
     'PhabricatorInfrastructureTestCase' => 'PhabricatorTestCase',
     'PhabricatorInlineCommentController' => 'PhabricatorController',

src/infrastructure/daemon/irc/handler/PhabricatorIRCObjectNameHandler.php

@@ -22,8 +22,6 @@ public function receiveMessage(PhabricatorIRCMessage $message) {
           break;
         }
 
-        $this->handleSymbols($message);
-
         $message = $message->getMessageText();
         $matches = null;
 
@@ -198,39 +196,4 @@ public function receiveMessage(PhabricatorIRCMessage $message) {
     }
   }
 
-  private function handleSymbols(PhabricatorIRCMessage $message) {
-    $reply_to = $message->getReplyTo();
-    $text = $message->getMessageText();
-
-    $matches = null;
-    if (!preg_match('/where(?: in the world)? is (\S+?)\?/i',
-        $text, $matches)) {
-      return;
-    }
-
-    $symbol = $matches[1];
-    $results = $this->getConduit()->callMethodSynchronous(
-      'diffusion.findsymbols',
-      array(
-        'name' => $symbol,
-      ));
-
-    $default_uri = $this->getURI('/diffusion/symbol/'.$symbol.'/');
-
-    if (count($results) > 1) {
-      $response = "Multiple symbols named '{$symbol}': {$default_uri}";
-    } else if (count($results) == 1) {
-      $result = head($results);
-      $response =
-        $result['type'].' '.
-        $result['name'].' '.
-        '('.$result['language'].'): '.
-        nonempty($result['uri'], $default_uri);
-    } else {
-      $response = "No symbol '{$symbol}' found anywhere.";
-    }
-
-    $this->write('PRIVMSG', "{$reply_to} :{$response}");
-  }
-
 }

src/infrastructure/daemon/irc/handler/PhabricatorIRCSymbolHandler.php

@@ -0,0 +1,55 @@
+<?php
+
+/**
+ * Watches for "where is <symbol>?"
+ *
+ * @group irc
+ */
+final class PhabricatorIRCSymbolHandler extends PhabricatorIRCHandler {
+
+  public function receiveMessage(PhabricatorIRCMessage $message) {
+
+    switch ($message->getCommand()) {
+      case 'PRIVMSG':
+        $reply_to = $message->getReplyTo();
+        if (!$reply_to) {
+          break;
+        }
+
+        $text = $message->getMessageText();
+
+        $matches = null;
+        if (!preg_match('/where(?: in the world)? is (\S+?)\?/i',
+            $text, $matches)) {
+          break;
+        }
+
+        $symbol = $matches[1];
+        $results = $this->getConduit()->callMethodSynchronous(
+          'diffusion.findsymbols',
+          array(
+            'name' => $symbol,
+          ));
+
+        $default_uri = $this->getURI('/diffusion/symbol/'.$symbol.'/');
+
+        if (count($results) > 1) {
+          $response = "Multiple symbols named '{$symbol}': {$default_uri}";
+        } else if (count($results) == 1) {
+          $result = head($results);
+          $response =
+            $result['type'].' '.
+            $result['name'].' '.
+            '('.$result['language'].'): '.
+            nonempty($result['uri'], $default_uri);
+        } else {
+          $response = "No symbol '{$symbol}' found anywhere.";
+        }
+
+        $this->write('PRIVMSG', "{$reply_to} :{$response}");
+
+        break;
+    }
+  }
+
+}