Make AphrontProxyResponse reduce to a real response instead of building a string

Summary: Currently, AphrontProxyResponse is expected to build a string. This prevents some response types (like Dialog) from being proxied, because they have special rules. Instead, make proxy responses reduce into a non-proxied response so it's possible to proxy any type of response and hit all the normal rules for it.

Test Plan: Built a proxied DialogResponse on top of this.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2104, T912

Differential Revision: https://secure.phabricator.com/D4159

Author: epriestley

src/aphront/response/AphrontProxyResponse.php

@@ -5,8 +5,8 @@
  * a response might be substantially an Ajax response, but add structure to the
  * response content. It can do this by extending @{class:AphrontProxyResponse},
  * instantiating an @{class:AphrontAjaxResponse} in @{method:buildProxy}, and
- * then using the proxy to construct the response string in
- * @{method:buildResponseString}.
+ * then constructing a real @{class:AphrontAjaxResponse} in
+ * @{method:reduceProxyResponse}.
  *
  * @group aphront
  */
@@ -63,5 +63,12 @@ public function getCacheHeaders() {
   }
 
   abstract protected function buildProxy();
+  abstract public function reduceProxyResponse();
+
+  final public function buildResponseString() {
+    throw new Exception(
+      "AphrontProxyResponse must implement reduceProxyResponse().");
+  }
+
 
 }

src/applications/base/controller/PhabricatorController.php

@@ -181,6 +181,22 @@ public function buildApplicationPage($view, array $options) {
   public function didProcessRequest($response) {
     $request = $this->getRequest();
     $response->setRequest($request);
+
+    $seen = array();
+    while ($response instanceof AphrontProxyResponse) {
+
+      $hash = spl_object_hash($response);
+      if (isset($seen[$hash])) {
+        $seen[] = get_class($response);
+        throw new Exception(
+          "Cycle while reducing proxy responses: ".
+          implode(' -> ', $seen));
+      }
+      $seen[$hash] = get_class($response);
+
+      $response = $response->reduceProxyResponse();
+    }
+
     if ($response instanceof AphrontDialogResponse) {
       if (!$request->isAjax()) {
         $view = new PhabricatorStandardPageView();

src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php

@@ -40,7 +40,7 @@ public function getViewer() {
     return $this->viewer;
   }
 
-  public function buildResponseString() {
+  public function reduceProxyResponse() {
     $view = id(new PhabricatorApplicationTransactionView())
       ->setViewer($this->getViewer())
       ->setTransactions($this->getTransactions());
@@ -56,10 +56,7 @@ public function buildResponseString() {
       'spacer'   => PhabricatorTimelineView::renderSpacer(),
     );
 
-    return $this
-      ->getProxy()
-      ->setContent($content)
-      ->buildResponseString();
+    return $this->getProxy()->setContent($content);
   }
 
 }

src/infrastructure/diff/PhabricatorChangesetResponse.php

@@ -19,7 +19,7 @@ protected function buildProxy() {
     return new AphrontAjaxResponse();
   }
 
-  public function buildResponseString() {
+  public function reduceProxyResponse() {
     $content = array(
       'changeset' => $this->renderedChangeset,
     );
@@ -28,7 +28,7 @@ public function buildResponseString() {
       $content['coverage'] = $this->coverage;
     }
 
-    return $this->getProxy()->setContent($content)->buildResponseString();
+    return $this->getProxy()->setContent($content);
   }
 
 }