Skip to content

Commit 4c540fb

Browse files
author
epriestley
committedNov 11, 2016
Fix some policy CSS
Summary: Ref T11853. My CSS change for the more enormous policy dialog was a little too broad, and affected the "You shall not pass!" dialog too. Narrow the scope of the CSS rules. Also add a missing "." that I caught. Test Plan: - Looked at policy exception dialogs. - Looked at policy explanation dialogs. - Looked at the end of that sentence. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11853 Differential Revision: https://secure.phabricator.com/D16841
1 parent 32d2955 commit 4c540fb

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed
 

‎resources/celerity/map.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
'names' => array(
1010
'conpherence.pkg.css' => 'cea72e09',
1111
'conpherence.pkg.js' => '6249a1cf',
12-
'core.pkg.css' => '231b1ee5',
12+
'core.pkg.css' => 'a729d20e',
1313
'core.pkg.js' => '1a77dddf',
1414
'darkconsole.pkg.js' => 'e7393ebb',
1515
'differential.pkg.css' => 'a4ba74b5',
@@ -21,7 +21,7 @@
2121
'maniphest.pkg.js' => '949a7498',
2222
'rsrc/css/aphront/aphront-bars.css' => '231ac33c',
2323
'rsrc/css/aphront/dark-console.css' => 'f54bf286',
24-
'rsrc/css/aphront/dialog-view.css' => '1e6b8603',
24+
'rsrc/css/aphront/dialog-view.css' => 'ea3745f5',
2525
'rsrc/css/aphront/lightbox-attachment.css' => '7acac05d',
2626
'rsrc/css/aphront/list-filter-view.css' => '5d6f0526',
2727
'rsrc/css/aphront/multi-column.css' => '84cc6640',
@@ -550,7 +550,7 @@
550550
'almanac-css' => 'dbb9b3af',
551551
'aphront-bars' => '231ac33c',
552552
'aphront-dark-console-css' => 'f54bf286',
553-
'aphront-dialog-view-css' => '1e6b8603',
553+
'aphront-dialog-view-css' => 'ea3745f5',
554554
'aphront-list-filter-view-css' => '5d6f0526',
555555
'aphront-multi-column-view-css' => '84cc6640',
556556
'aphront-panel-view-css' => '8427b78d',

‎src/applications/policy/controller/PhabricatorPolicyExplainController.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public function handleRequest(AphrontRequest $request) {
4040

4141
$dialog = id(new AphrontDialogView())
4242
->setUser($viewer)
43-
->setClass('aphront-access-dialog')
43+
->setClass('aphront-access-dialog aphront-policy-explain-dialog')
4444
->setTitle(pht('Policy Details: %s', $object_name))
4545
->addCancelButton($object_uri, pht('Done'));
4646

‎src/applications/project/controller/PhabricatorProjectSubprojectWarningController.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public function handleRequest(AphrontRequest $request) {
3535

3636
$conversion_help = pht(
3737
"Creating a project's first subproject **moves all ".
38-
"members** to become members of the subproject instead".
38+
"members** to become members of the subproject instead.".
3939
"\n\n".
4040
"See [[ %s | Projects User Guide ]] in the documentation for details. ".
4141
"This process can not be undone.",

‎webroot/rsrc/css/aphront/dialog-view.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@
128128
width: 50%;
129129
}
130130

131-
.aphront-access-dialog .aphront-dialog-body {
131+
.aphront-policy-explain-dialog .aphront-dialog-body {
132132
padding: 0 12px;
133133
}
134134

0 commit comments

Comments
 (0)
Failed to load comments.