Skip to content

Commit 02b59e6

Browse files
chadlittlechadlittle
committed
PHUIButtonView class
Summary: Rough pass at a PHUIButtonView Class. Keeps phutil_tag intact and adds some image features if you use the class. Test Plan: UIExamples Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6192
1 parent a66e6c2 commit 02b59e6

File tree

10 files changed

+410
-134
lines changed

10 files changed

+410
-134
lines changed

‎scripts/celerity_mapper.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
'core.pkg.css' => array(
6868
'phabricator-core-css',
6969
'phabricator-zindex-css',
70-
'phabricator-core-buttons-css',
70+
'phui-button-css',
7171
'phabricator-standard-page-view',
7272
'aphront-dialog-view-css',
7373
'aphront-form-view-css',
@@ -104,7 +104,7 @@
104104
'phabricator-crumbs-view-css',
105105
'phabricator-object-item-list-view-css',
106106
'global-drag-and-drop-css',
107-
'spacing-css',
107+
'phui-spacing-css',
108108
'phui-form-css',
109109
'phui-icon-view-css',
110110

‎src/__celerity_resource_map__.php

Lines changed: 65 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -2965,15 +2965,6 @@
29652965
),
29662966
'disk' => '/rsrc/css/application/contentsource/content-source-view.css',
29672967
),
2968-
'phabricator-core-buttons-css' =>
2969-
array(
2970-
'uri' => '/res/073fc5eb/rsrc/css/core/buttons.css',
2971-
'type' => 'css',
2972-
'requires' =>
2973-
array(
2974-
),
2975-
'disk' => '/rsrc/css/core/buttons.css',
2976-
),
29772968
'phabricator-core-css' =>
29782969
array(
29792970
'uri' => '/res/dc204369/rsrc/css/core/core.css',
@@ -3694,6 +3685,15 @@
36943685
),
36953686
'disk' => '/rsrc/css/phui/phui-box.css',
36963687
),
3688+
'phui-button-css' =>
3689+
array(
3690+
'uri' => '/res/8fc82931/rsrc/css/phui/phui-button.css',
3691+
'type' => 'css',
3692+
'requires' =>
3693+
array(
3694+
),
3695+
'disk' => '/rsrc/css/phui/phui-button.css',
3696+
),
36973697
'phui-document-view-css' =>
36983698
array(
36993699
'uri' => '/res/fe374dee/rsrc/css/phui/phui-document.css',
@@ -3723,7 +3723,7 @@
37233723
),
37243724
'phui-icon-view-css' =>
37253725
array(
3726-
'uri' => '/res/7fd37b96/rsrc/css/phui/phui-icon.css',
3726+
'uri' => '/res/f78f4c64/rsrc/css/phui/phui-icon.css',
37273727
'type' => 'css',
37283728
'requires' =>
37293729
array(
@@ -3739,6 +3739,15 @@
37393739
),
37403740
'disk' => '/rsrc/css/phui/phui-list.css',
37413741
),
3742+
'phui-spacing-css' =>
3743+
array(
3744+
'uri' => '/res/28891fd3/rsrc/css/phui/phui-spacing.css',
3745+
'type' => 'css',
3746+
'requires' =>
3747+
array(
3748+
),
3749+
'disk' => '/rsrc/css/phui/phui-spacing.css',
3750+
),
37423751
'phui-text-css' =>
37433752
array(
37443753
'uri' => '/res/ca884ca6/rsrc/css/phui/phui-text.css',
@@ -3901,15 +3910,6 @@
39013910
),
39023911
'disk' => '/rsrc/css/application/config/setup-issue.css',
39033912
),
3904-
'spacing-css' =>
3905-
array(
3906-
'uri' => '/res/61563661/rsrc/css/core/spacing.css',
3907-
'type' => 'css',
3908-
'requires' =>
3909-
array(
3910-
),
3911-
'disk' => '/rsrc/css/core/spacing.css',
3912-
),
39133913
'sprite-actions-css' =>
39143914
array(
39153915
'uri' => '/res/bd43efa8/rsrc/css/sprite-actions.css',
@@ -4048,14 +4048,14 @@
40484048
), array(
40494049
'packages' =>
40504050
array(
4051-
'76d08512' =>
4051+
'0a101340' =>
40524052
array(
40534053
'name' => 'core.pkg.css',
40544054
'symbols' =>
40554055
array(
40564056
0 => 'phabricator-core-css',
40574057
1 => 'phabricator-zindex-css',
4058-
2 => 'phabricator-core-buttons-css',
4058+
2 => 'phui-button-css',
40594059
3 => 'phabricator-standard-page-view',
40604060
4 => 'aphront-dialog-view-css',
40614061
5 => 'aphront-form-view-css',
@@ -4088,15 +4088,15 @@
40884088
32 => 'phabricator-crumbs-view-css',
40894089
33 => 'phabricator-object-item-list-view-css',
40904090
34 => 'global-drag-and-drop-css',
4091-
35 => 'spacing-css',
4091+
35 => 'phui-spacing-css',
40924092
36 => 'phui-form-css',
40934093
37 => 'phui-icon-view-css',
40944094
38 => 'phabricator-application-launch-view-css',
40954095
39 => 'phabricator-action-list-view-css',
40964096
40 => 'phabricator-property-list-view-css',
40974097
41 => 'phabricator-tag-view-css',
40984098
),
4099-
'uri' => '/res/pkg/76d08512/core.pkg.css',
4099+
'uri' => '/res/pkg/0a101340/core.pkg.css',
41004100
'type' => 'css',
41014101
),
41024102
'f2ad0683' =>
@@ -4290,16 +4290,16 @@
42904290
'reverse' =>
42914291
array(
42924292
'aphront-attached-file-view-css' => 'a7ca34a9',
4293-
'aphront-dialog-view-css' => '76d08512',
4294-
'aphront-error-view-css' => '76d08512',
4295-
'aphront-form-view-css' => '76d08512',
4296-
'aphront-list-filter-view-css' => '76d08512',
4297-
'aphront-pager-view-css' => '76d08512',
4298-
'aphront-panel-view-css' => '76d08512',
4299-
'aphront-table-view-css' => '76d08512',
4300-
'aphront-tokenizer-control-css' => '76d08512',
4301-
'aphront-tooltip-css' => '76d08512',
4302-
'aphront-typeahead-control-css' => '76d08512',
4293+
'aphront-dialog-view-css' => '0a101340',
4294+
'aphront-error-view-css' => '0a101340',
4295+
'aphront-form-view-css' => '0a101340',
4296+
'aphront-list-filter-view-css' => '0a101340',
4297+
'aphront-pager-view-css' => '0a101340',
4298+
'aphront-panel-view-css' => '0a101340',
4299+
'aphront-table-view-css' => '0a101340',
4300+
'aphront-tokenizer-control-css' => '0a101340',
4301+
'aphront-tooltip-css' => '0a101340',
4302+
'aphront-typeahead-control-css' => '0a101340',
43034303
'differential-changeset-view-css' => 'dd27a69b',
43044304
'differential-core-view-css' => 'dd27a69b',
43054305
'differential-inline-comment-editor' => '9488bb69',
@@ -4313,7 +4313,7 @@
43134313
'differential-table-of-contents-css' => 'dd27a69b',
43144314
'diffusion-commit-view-css' => 'c8ce2d88',
43154315
'diffusion-icons-css' => 'c8ce2d88',
4316-
'global-drag-and-drop-css' => '76d08512',
4316+
'global-drag-and-drop-css' => '0a101340',
43174317
'inline-comment-summary-css' => 'dd27a69b',
43184318
'javelin-aphlict' => 'f2ad0683',
43194319
'javelin-behavior' => 'a9f14d76',
@@ -4387,55 +4387,55 @@
43874387
'javelin-util' => 'a9f14d76',
43884388
'javelin-vector' => 'a9f14d76',
43894389
'javelin-workflow' => 'a9f14d76',
4390-
'lightbox-attachment-css' => '76d08512',
4390+
'lightbox-attachment-css' => '0a101340',
43914391
'maniphest-task-summary-css' => 'a7ca34a9',
43924392
'maniphest-transaction-detail-css' => 'a7ca34a9',
4393-
'phabricator-action-list-view-css' => '76d08512',
4394-
'phabricator-application-launch-view-css' => '76d08512',
4393+
'phabricator-action-list-view-css' => '0a101340',
4394+
'phabricator-application-launch-view-css' => '0a101340',
43954395
'phabricator-busy' => 'f2ad0683',
43964396
'phabricator-content-source-view-css' => 'dd27a69b',
4397-
'phabricator-core-buttons-css' => '76d08512',
4398-
'phabricator-core-css' => '76d08512',
4399-
'phabricator-crumbs-view-css' => '76d08512',
4397+
'phabricator-core-css' => '0a101340',
4398+
'phabricator-crumbs-view-css' => '0a101340',
44004399
'phabricator-drag-and-drop-file-upload' => '9488bb69',
44014400
'phabricator-dropdown-menu' => 'f2ad0683',
44024401
'phabricator-file-upload' => 'f2ad0683',
4403-
'phabricator-filetree-view-css' => '76d08512',
4404-
'phabricator-flag-css' => '76d08512',
4405-
'phabricator-form-view-css' => '76d08512',
4406-
'phabricator-header-view-css' => '76d08512',
4402+
'phabricator-filetree-view-css' => '0a101340',
4403+
'phabricator-flag-css' => '0a101340',
4404+
'phabricator-form-view-css' => '0a101340',
4405+
'phabricator-header-view-css' => '0a101340',
44074406
'phabricator-hovercard' => 'f2ad0683',
4408-
'phabricator-jump-nav' => '76d08512',
4407+
'phabricator-jump-nav' => '0a101340',
44094408
'phabricator-keyboard-shortcut' => 'f2ad0683',
44104409
'phabricator-keyboard-shortcut-manager' => 'f2ad0683',
4411-
'phabricator-main-menu-view' => '76d08512',
4410+
'phabricator-main-menu-view' => '0a101340',
44124411
'phabricator-menu-item' => 'f2ad0683',
4413-
'phabricator-nav-view-css' => '76d08512',
4412+
'phabricator-nav-view-css' => '0a101340',
44144413
'phabricator-notification' => 'f2ad0683',
4415-
'phabricator-notification-css' => '76d08512',
4416-
'phabricator-notification-menu-css' => '76d08512',
4417-
'phabricator-object-item-list-view-css' => '76d08512',
4414+
'phabricator-notification-css' => '0a101340',
4415+
'phabricator-notification-menu-css' => '0a101340',
4416+
'phabricator-object-item-list-view-css' => '0a101340',
44184417
'phabricator-object-selector-css' => 'dd27a69b',
44194418
'phabricator-phtize' => 'f2ad0683',
44204419
'phabricator-prefab' => 'f2ad0683',
44214420
'phabricator-project-tag-css' => 'a7ca34a9',
4422-
'phabricator-property-list-view-css' => '76d08512',
4423-
'phabricator-remarkup-css' => '76d08512',
4421+
'phabricator-property-list-view-css' => '0a101340',
4422+
'phabricator-remarkup-css' => '0a101340',
44244423
'phabricator-shaped-request' => '9488bb69',
4425-
'phabricator-side-menu-view-css' => '76d08512',
4426-
'phabricator-standard-page-view' => '76d08512',
4427-
'phabricator-tag-view-css' => '76d08512',
4424+
'phabricator-side-menu-view-css' => '0a101340',
4425+
'phabricator-standard-page-view' => '0a101340',
4426+
'phabricator-tag-view-css' => '0a101340',
44284427
'phabricator-textareautils' => 'f2ad0683',
44294428
'phabricator-tooltip' => 'f2ad0683',
4430-
'phabricator-transaction-view-css' => '76d08512',
4431-
'phabricator-zindex-css' => '76d08512',
4432-
'phui-form-css' => '76d08512',
4433-
'phui-icon-view-css' => '76d08512',
4434-
'spacing-css' => '76d08512',
4435-
'sprite-apps-large-css' => '76d08512',
4436-
'sprite-gradient-css' => '76d08512',
4437-
'sprite-icons-css' => '76d08512',
4438-
'sprite-menu-css' => '76d08512',
4439-
'syntax-highlighting-css' => '76d08512',
4429+
'phabricator-transaction-view-css' => '0a101340',
4430+
'phabricator-zindex-css' => '0a101340',
4431+
'phui-button-css' => '0a101340',
4432+
'phui-form-css' => '0a101340',
4433+
'phui-icon-view-css' => '0a101340',
4434+
'phui-spacing-css' => '0a101340',
4435+
'sprite-apps-large-css' => '0a101340',
4436+
'sprite-gradient-css' => '0a101340',
4437+
'sprite-icons-css' => '0a101340',
4438+
'sprite-menu-css' => '0a101340',
4439+
'syntax-highlighting-css' => '0a101340',
44404440
),
44414441
));

‎src/__phutil_library_map__.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -686,6 +686,8 @@
686686
'PHUI' => 'view/phui/PHUI.php',
687687
'PHUIBoxExample' => 'applications/uiexample/examples/PHUIBoxExample.php',
688688
'PHUIBoxView' => 'view/phui/PHUIBoxView.php',
689+
'PHUIButtonExample' => 'applications/uiexample/examples/PHUIButtonExample.php',
690+
'PHUIButtonView' => 'view/phui/PHUIButtonView.php',
689691
'PHUIDocumentExample' => 'applications/uiexample/examples/PHUIDocumentExample.php',
690692
'PHUIDocumentView' => 'view/phui/PHUIDocumentView.php',
691693
'PHUIFeedStoryExample' => 'applications/uiexample/examples/PHUIFeedStoryExample.php',
@@ -835,7 +837,6 @@
835837
'PhabricatorBotUser' => 'infrastructure/daemon/bot/target/PhabricatorBotUser.php',
836838
'PhabricatorBotWhatsNewHandler' => 'infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php',
837839
'PhabricatorBuiltinPatchList' => 'infrastructure/storage/patch/PhabricatorBuiltinPatchList.php',
838-
'PhabricatorButtonsExample' => 'applications/uiexample/examples/PhabricatorButtonsExample.php',
839840
'PhabricatorCacheDAO' => 'applications/cache/storage/PhabricatorCacheDAO.php',
840841
'PhabricatorCacheManagementPurgeWorkflow' => 'applications/cache/management/PhabricatorCacheManagementPurgeWorkflow.php',
841842
'PhabricatorCacheManagementWorkflow' => 'applications/cache/management/PhabricatorCacheManagementWorkflow.php',
@@ -2531,6 +2532,8 @@
25312532
'OwnersPackageReplyHandler' => 'PhabricatorMailReplyHandler',
25322533
'PHUIBoxExample' => 'PhabricatorUIExample',
25332534
'PHUIBoxView' => 'AphrontTagView',
2535+
'PHUIButtonExample' => 'PhabricatorUIExample',
2536+
'PHUIButtonView' => 'AphrontTagView',
25342537
'PHUIDocumentExample' => 'PhabricatorUIExample',
25352538
'PHUIDocumentView' => 'AphrontTagView',
25362539
'PHUIFeedStoryExample' => 'PhabricatorUIExample',
@@ -2683,7 +2686,6 @@
26832686
'PhabricatorBotUser' => 'PhabricatorBotTarget',
26842687
'PhabricatorBotWhatsNewHandler' => 'PhabricatorBotHandler',
26852688
'PhabricatorBuiltinPatchList' => 'PhabricatorSQLPatchList',
2686-
'PhabricatorButtonsExample' => 'PhabricatorUIExample',
26872689
'PhabricatorCacheDAO' => 'PhabricatorLiskDAO',
26882690
'PhabricatorCacheManagementPurgeWorkflow' => 'PhabricatorSearchManagementWorkflow',
26892691
'PhabricatorCacheManagementWorkflow' => 'PhutilArgumentWorkflow',

0 commit comments

Comments
 (0)