Make nonscalar field saves raise a more useful exception from LiskDAO

Summary:
If you do something like this:

  // Missing $user->getPHID()!
  $object->setUserPHID($user)->save();

...you get a very unhelpful exception:

  Expected a scalar or null for %s conversion. Query: %s

This doesn't give you any hints about what's wrong. Instead, provide a more useful exception:

  Unable to insert or update object of class DifferentialRevision, field 'title' has a nonscalar value.

Test Plan: {F87614}

Reviewers: hach-que, btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7725

Author: epriestley

src/infrastructure/storage/lisk/LiskDAO.php

@@ -1244,7 +1244,17 @@ protected function insertRecordIntoDatabase($mode) {
     $columns = array_keys($data);
 
     foreach ($data as $key => $value) {
-      $data[$key] = qsprintf($conn, '%ns', $value);
+      try {
+        $data[$key] = qsprintf($conn, '%ns', $value);
+      } catch (AphrontQueryParameterException $parameter_exception) {
+        throw new PhutilProxyException(
+          pht(
+            "Unable to insert or update object of class %s, field '%s' ".
+            "has a nonscalar value.",
+            get_class($this),
+            $key),
+          $parameter_exception);
+      }
     }
     $data = implode(', ', $data);