render_tag -> tag: phabricator_render_form -> phabricator_form

Summary: Convert most phabricator_render_form callsites. In the case of the "headsup view", it converts it by deleting the element entirely (this is the very old Maniphest/Differential header which we no longer use).

Test Plan: Poked around a bit.

Reviewers: vrana

Reviewed By: vrana

CC: aran

Maniphest Tasks: T2432

Differential Revision: https://secure.phabricator.com/D4726

Author: epriestley

scripts/celerity_mapper.php

@@ -81,7 +81,6 @@
     'aphront-pager-view-css',
     'phabricator-transaction-view-css',
     'aphront-tooltip-css',
-    'aphront-headsup-view-css',
     'phabricator-flag-css',
     'aphront-error-view-css',
 
@@ -115,7 +114,6 @@
     'differential-revision-add-comment-css',
     'differential-revision-comment-list-css',
     'phabricator-object-selector-css',
-    'aphront-headsup-action-list-view-css',
     'phabricator-content-source-view-css',
     'differential-local-commits-view-css',
     'inline-comment-summary-css',

src/__celerity_resource_map__.php

@@ -653,24 +653,6 @@
     ),
     'disk' => '/rsrc/css/aphront/form-view.css',
   ),
-  'aphront-headsup-action-list-view-css' =>
-  array(
-    'uri' => '/res/1dce0ad7/rsrc/css/aphront/headsup-action-list-view.css',
-    'type' => 'css',
-    'requires' =>
-    array(
-    ),
-    'disk' => '/rsrc/css/aphront/headsup-action-list-view.css',
-  ),
-  'aphront-headsup-view-css' =>
-  array(
-    'uri' => '/res/73874cd2/rsrc/css/aphront/headsup.css',
-    'type' => 'css',
-    'requires' =>
-    array(
-    ),
-    'disk' => '/rsrc/css/aphront/headsup.css',
-  ),
   'aphront-list-filter-view-css' =>
   array(
     'uri' => '/res/e783d6e1/rsrc/css/aphront/list-filter-view.css',
@@ -1166,7 +1148,7 @@
   ),
   'javelin-behavior-dark-console' =>
   array(
-    'uri' => '/res/c3e8a3d8/rsrc/js/application/core/behavior-dark-console.js',
+    'uri' => '/res/52444d4e/rsrc/js/application/core/behavior-dark-console.js',
     'type' => 'js',
     'requires' =>
     array(
@@ -3375,7 +3357,7 @@
 ), array(
   'packages' =>
   array(
-    '0cb71c48' =>
+    '0e6165d0' =>
     array(
       'name' => 'core.pkg.css',
       'symbols' =>
@@ -3399,27 +3381,26 @@
         16 => 'aphront-pager-view-css',
         17 => 'phabricator-transaction-view-css',
         18 => 'aphront-tooltip-css',
-        19 => 'aphront-headsup-view-css',
-        20 => 'phabricator-flag-css',
-        21 => 'aphront-error-view-css',
-        22 => 'sprite-icon-css',
-        23 => 'sprite-gradient-css',
-        24 => 'sprite-menu-css',
-        25 => 'sprite-apps-large-css',
-        26 => 'phabricator-main-menu-view',
-        27 => 'phabricator-notification-css',
-        28 => 'phabricator-notification-menu-css',
-        29 => 'lightbox-attachment-css',
-        30 => 'phabricator-header-view-css',
-        31 => 'phabricator-form-view-css',
-        32 => 'phabricator-filetree-view-css',
-        33 => 'phabricator-nav-view-css',
-        34 => 'phabricator-side-menu-view-css',
-        35 => 'phabricator-crumbs-view-css',
-        36 => 'phabricator-object-item-list-view-css',
-        37 => 'global-drag-and-drop-css',
+        19 => 'phabricator-flag-css',
+        20 => 'aphront-error-view-css',
+        21 => 'sprite-icon-css',
+        22 => 'sprite-gradient-css',
+        23 => 'sprite-menu-css',
+        24 => 'sprite-apps-large-css',
+        25 => 'phabricator-main-menu-view',
+        26 => 'phabricator-notification-css',
+        27 => 'phabricator-notification-menu-css',
+        28 => 'lightbox-attachment-css',
+        29 => 'phabricator-header-view-css',
+        30 => 'phabricator-form-view-css',
+        31 => 'phabricator-filetree-view-css',
+        32 => 'phabricator-nav-view-css',
+        33 => 'phabricator-side-menu-view-css',
+        34 => 'phabricator-crumbs-view-css',
+        35 => 'phabricator-object-item-list-view-css',
+        36 => 'global-drag-and-drop-css',
       ),
-      'uri' => '/res/pkg/0cb71c48/core.pkg.css',
+      'uri' => '/res/pkg/0e6165d0/core.pkg.css',
       'type' => 'css',
     ),
     'ff199687' =>
@@ -3464,18 +3445,18 @@
       'uri' => '/res/pkg/ff199687/core.pkg.js',
       'type' => 'js',
     ),
-    '032118cf' =>
+    '74593df4' =>
     array(
       'name' => 'darkconsole.pkg.js',
       'symbols' =>
       array(
         0 => 'javelin-behavior-dark-console',
         1 => 'javelin-behavior-error-log',
       ),
-      'uri' => '/res/pkg/032118cf/darkconsole.pkg.js',
+      'uri' => '/res/pkg/74593df4/darkconsole.pkg.js',
       'type' => 'js',
     ),
-    'ec01d039' =>
+    '8aaacd1b' =>
     array(
       'name' => 'differential.pkg.css',
       'symbols' =>
@@ -3490,12 +3471,11 @@
         7 => 'differential-revision-add-comment-css',
         8 => 'differential-revision-comment-list-css',
         9 => 'phabricator-object-selector-css',
-        10 => 'aphront-headsup-action-list-view-css',
-        11 => 'phabricator-content-source-view-css',
-        12 => 'differential-local-commits-view-css',
-        13 => 'inline-comment-summary-css',
+        10 => 'phabricator-content-source-view-css',
+        11 => 'differential-local-commits-view-css',
+        12 => 'inline-comment-summary-css',
       ),
-      'uri' => '/res/pkg/ec01d039/differential.pkg.css',
+      'uri' => '/res/pkg/8aaacd1b/differential.pkg.css',
       'type' => 'css',
     ),
     '9dae5f20' =>
@@ -3608,34 +3588,32 @@
   'reverse' =>
   array(
     'aphront-attached-file-view-css' => 'e30a3fa8',
-    'aphront-crumbs-view-css' => '0cb71c48',
-    'aphront-dialog-view-css' => '0cb71c48',
-    'aphront-error-view-css' => '0cb71c48',
-    'aphront-form-view-css' => '0cb71c48',
-    'aphront-headsup-action-list-view-css' => 'ec01d039',
-    'aphront-headsup-view-css' => '0cb71c48',
-    'aphront-list-filter-view-css' => '0cb71c48',
-    'aphront-pager-view-css' => '0cb71c48',
-    'aphront-panel-view-css' => '0cb71c48',
-    'aphront-table-view-css' => '0cb71c48',
-    'aphront-tokenizer-control-css' => '0cb71c48',
-    'aphront-tooltip-css' => '0cb71c48',
-    'aphront-typeahead-control-css' => '0cb71c48',
-    'differential-changeset-view-css' => 'ec01d039',
-    'differential-core-view-css' => 'ec01d039',
+    'aphront-crumbs-view-css' => '0e6165d0',
+    'aphront-dialog-view-css' => '0e6165d0',
+    'aphront-error-view-css' => '0e6165d0',
+    'aphront-form-view-css' => '0e6165d0',
+    'aphront-list-filter-view-css' => '0e6165d0',
+    'aphront-pager-view-css' => '0e6165d0',
+    'aphront-panel-view-css' => '0e6165d0',
+    'aphront-table-view-css' => '0e6165d0',
+    'aphront-tokenizer-control-css' => '0e6165d0',
+    'aphront-tooltip-css' => '0e6165d0',
+    'aphront-typeahead-control-css' => '0e6165d0',
+    'differential-changeset-view-css' => '8aaacd1b',
+    'differential-core-view-css' => '8aaacd1b',
     'differential-inline-comment-editor' => '9dae5f20',
-    'differential-local-commits-view-css' => 'ec01d039',
-    'differential-results-table-css' => 'ec01d039',
-    'differential-revision-add-comment-css' => 'ec01d039',
-    'differential-revision-comment-css' => 'ec01d039',
-    'differential-revision-comment-list-css' => 'ec01d039',
-    'differential-revision-history-css' => 'ec01d039',
-    'differential-revision-list-css' => 'ec01d039',
-    'differential-table-of-contents-css' => 'ec01d039',
+    'differential-local-commits-view-css' => '8aaacd1b',
+    'differential-results-table-css' => '8aaacd1b',
+    'differential-revision-add-comment-css' => '8aaacd1b',
+    'differential-revision-comment-css' => '8aaacd1b',
+    'differential-revision-comment-list-css' => '8aaacd1b',
+    'differential-revision-history-css' => '8aaacd1b',
+    'differential-revision-list-css' => '8aaacd1b',
+    'differential-table-of-contents-css' => '8aaacd1b',
     'diffusion-commit-view-css' => 'c8ce2d88',
     'diffusion-icons-css' => 'c8ce2d88',
-    'global-drag-and-drop-css' => '0cb71c48',
-    'inline-comment-summary-css' => 'ec01d039',
+    'global-drag-and-drop-css' => '0e6165d0',
+    'inline-comment-summary-css' => '8aaacd1b',
     'javelin-aphlict' => 'ff199687',
     'javelin-behavior' => '1c6f020b',
     'javelin-behavior-aphlict-dropdown' => 'ff199687',
@@ -3645,7 +3623,7 @@
     'javelin-behavior-aphront-drag-and-drop-textarea' => '9dae5f20',
     'javelin-behavior-aphront-form-disable-on-submit' => 'ff199687',
     'javelin-behavior-audit-preview' => 'f96657b8',
-    'javelin-behavior-dark-console' => '032118cf',
+    'javelin-behavior-dark-console' => '74593df4',
     'javelin-behavior-device' => 'ff199687',
     'javelin-behavior-differential-accept-with-errors' => '9dae5f20',
     'javelin-behavior-differential-add-reviewers-and-ccs' => '9dae5f20',
@@ -3661,7 +3639,7 @@
     'javelin-behavior-differential-user-select' => '9dae5f20',
     'javelin-behavior-diffusion-commit-graph' => 'f96657b8',
     'javelin-behavior-diffusion-pull-lastmodified' => 'f96657b8',
-    'javelin-behavior-error-log' => '032118cf',
+    'javelin-behavior-error-log' => '74593df4',
     'javelin-behavior-global-drag-and-drop' => 'ff199687',
     'javelin-behavior-konami' => 'ff199687',
     'javelin-behavior-lightbox-attachments' => 'ff199687',
@@ -3703,48 +3681,48 @@
     'javelin-util' => '1c6f020b',
     'javelin-vector' => '1c6f020b',
     'javelin-workflow' => '1c6f020b',
-    'lightbox-attachment-css' => '0cb71c48',
+    'lightbox-attachment-css' => '0e6165d0',
     'maniphest-task-summary-css' => 'e30a3fa8',
     'maniphest-transaction-detail-css' => 'e30a3fa8',
     'phabricator-busy' => 'ff199687',
-    'phabricator-content-source-view-css' => 'ec01d039',
-    'phabricator-core-buttons-css' => '0cb71c48',
-    'phabricator-core-css' => '0cb71c48',
-    'phabricator-crumbs-view-css' => '0cb71c48',
-    'phabricator-directory-css' => '0cb71c48',
+    'phabricator-content-source-view-css' => '8aaacd1b',
+    'phabricator-core-buttons-css' => '0e6165d0',
+    'phabricator-core-css' => '0e6165d0',
+    'phabricator-crumbs-view-css' => '0e6165d0',
+    'phabricator-directory-css' => '0e6165d0',
     'phabricator-drag-and-drop-file-upload' => '9dae5f20',
     'phabricator-dropdown-menu' => 'ff199687',
     'phabricator-file-upload' => 'ff199687',
-    'phabricator-filetree-view-css' => '0cb71c48',
-    'phabricator-flag-css' => '0cb71c48',
-    'phabricator-form-view-css' => '0cb71c48',
-    'phabricator-header-view-css' => '0cb71c48',
-    'phabricator-jump-nav' => '0cb71c48',
+    'phabricator-filetree-view-css' => '0e6165d0',
+    'phabricator-flag-css' => '0e6165d0',
+    'phabricator-form-view-css' => '0e6165d0',
+    'phabricator-header-view-css' => '0e6165d0',
+    'phabricator-jump-nav' => '0e6165d0',
     'phabricator-keyboard-shortcut' => 'ff199687',
     'phabricator-keyboard-shortcut-manager' => 'ff199687',
-    'phabricator-main-menu-view' => '0cb71c48',
+    'phabricator-main-menu-view' => '0e6165d0',
     'phabricator-menu-item' => 'ff199687',
-    'phabricator-nav-view-css' => '0cb71c48',
+    'phabricator-nav-view-css' => '0e6165d0',
     'phabricator-notification' => 'ff199687',
-    'phabricator-notification-css' => '0cb71c48',
-    'phabricator-notification-menu-css' => '0cb71c48',
-    'phabricator-object-item-list-view-css' => '0cb71c48',
-    'phabricator-object-selector-css' => 'ec01d039',
+    'phabricator-notification-css' => '0e6165d0',
+    'phabricator-notification-menu-css' => '0e6165d0',
+    'phabricator-object-item-list-view-css' => '0e6165d0',
+    'phabricator-object-selector-css' => '8aaacd1b',
     'phabricator-paste-file-upload' => 'ff199687',
     'phabricator-prefab' => 'ff199687',
     'phabricator-project-tag-css' => 'e30a3fa8',
-    'phabricator-remarkup-css' => '0cb71c48',
+    'phabricator-remarkup-css' => '0e6165d0',
     'phabricator-shaped-request' => '9dae5f20',
-    'phabricator-side-menu-view-css' => '0cb71c48',
-    'phabricator-standard-page-view' => '0cb71c48',
+    'phabricator-side-menu-view-css' => '0e6165d0',
+    'phabricator-standard-page-view' => '0e6165d0',
     'phabricator-textareautils' => 'ff199687',
     'phabricator-tooltip' => 'ff199687',
-    'phabricator-transaction-view-css' => '0cb71c48',
-    'phabricator-zindex-css' => '0cb71c48',
-    'sprite-apps-large-css' => '0cb71c48',
-    'sprite-gradient-css' => '0cb71c48',
-    'sprite-icon-css' => '0cb71c48',
-    'sprite-menu-css' => '0cb71c48',
-    'syntax-highlighting-css' => '0cb71c48',
+    'phabricator-transaction-view-css' => '0e6165d0',
+    'phabricator-zindex-css' => '0e6165d0',
+    'sprite-apps-large-css' => '0e6165d0',
+    'sprite-gradient-css' => '0e6165d0',
+    'sprite-icon-css' => '0e6165d0',
+    'sprite-menu-css' => '0e6165d0',
+    'syntax-highlighting-css' => '0e6165d0',
   ),
 ));

src/__phutil_library_map__.php

@@ -55,9 +55,6 @@
     'AphrontHTMLResponse' => 'aphront/response/AphrontHTMLResponse.php',
     'AphrontHTTPSink' => 'aphront/sink/AphrontHTTPSink.php',
     'AphrontHTTPSinkTestCase' => 'aphront/sink/__tests__/AphrontHTTPSinkTestCase.php',
-    'AphrontHeadsupActionListView' => 'view/layout/headsup/AphrontHeadsupActionListView.php',
-    'AphrontHeadsupActionView' => 'view/layout/headsup/AphrontHeadsupActionView.php',
-    'AphrontHeadsupView' => 'view/layout/headsup/AphrontHeadsupView.php',
     'AphrontIsolatedDatabaseConnectionTestCase' => 'infrastructure/storage/__tests__/AphrontIsolatedDatabaseConnectionTestCase.php',
     'AphrontIsolatedHTTPSink' => 'aphront/sink/AphrontIsolatedHTTPSink.php',
     'AphrontJSONResponse' => 'aphront/response/AphrontJSONResponse.php',
@@ -1544,9 +1541,6 @@
     'AphrontFormView' => 'AphrontView',
     'AphrontHTMLResponse' => 'AphrontResponse',
     'AphrontHTTPSinkTestCase' => 'PhabricatorTestCase',
-    'AphrontHeadsupActionListView' => 'AphrontView',
-    'AphrontHeadsupActionView' => 'AphrontView',
-    'AphrontHeadsupView' => 'AphrontView',
     'AphrontIsolatedDatabaseConnectionTestCase' => 'PhabricatorTestCase',
     'AphrontIsolatedHTTPSink' => 'AphrontHTTPSink',
     'AphrontJSONResponse' => 'AphrontResponse',

src/applications/auth/controller/PhabricatorMustVerifyEmailController.php

@@ -51,7 +51,7 @@ public function processRequest() {
       '</p>');
     $error_view->appendChild(
       '<div class="aphront-failure-continue">'.
-        phabricator_render_form(
+        phabricator_form(
           $user,
           array(
             'action' => '/login/mustverify/',

src/applications/differential/controller/DifferentialDiffViewController.php

@@ -113,9 +113,10 @@ public function processRequest() {
       }
     }
 
-    $action_panel = new AphrontHeadsupView();
-    $action_panel->setProperties($dict);
-    $action_panel->setHeader(pht('Diff Properties'));
+    $property_view = new PhabricatorPropertyListView();
+    foreach ($dict as $key => $value) {
+      $property_view->addProperty($key, $value);
+    }
 
     $changesets = $diff->loadChangesets();
     $changesets = msort($changesets, 'getSortKey');
@@ -144,7 +145,7 @@ public function processRequest() {
         ->appendChild(
           array(
             $top_panel->render(),
-            $action_panel->render(),
+            $property_view,
             $table_of_contents->render(),
             $details->render(),
           )),

src/applications/directory/controller/PhabricatorDirectoryMainController.php

@@ -322,15 +322,17 @@ private function buildJumpPanel($query=null) {
     $panel = new AphrontPanelView();
     $panel->setHeader('Jump Nav');
     $panel->appendChild(
-      phabricator_render_form(
+      phabricator_form(
         $user,
         array(
           'action' => '/jump/',
           'method' => 'POST',
           'class'  => 'phabricator-jump-nav-form',
         ),
-        $jump_input.
-        $jump_caption));
+        array(
+          $jump_input,
+          $jump_caption,
+        )));
 
     return $panel;
   }

src/applications/flag/view/PhabricatorFlagListView.php

@@ -29,7 +29,7 @@ public function render() {
         $flag->getHandle()->renderLink(),
         phutil_escape_html($flag->getNote()),
         phabricator_datetime($flag->getDateCreated(), $user),
-        phabricator_render_form(
+        phabricator_form(
           $user,
           array(
             'method' => 'POST',
@@ -42,7 +42,7 @@ public function render() {
               'class' => 'small grey',
             ),
             'Edit Flag')),
-        phabricator_render_form(
+        phabricator_form(
           $user,
           array(
             'method' => 'POST',