Skip to content

testimonial wall & highlight testimonials #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 25, 2025

Conversation

vedantnene
Copy link
Collaborator

Checklist:

  • I've thoroughly self-reviewed my changes
  • I've added tests for my changes, unless they affect admin-only areas (or are otherwise not worth testing)
  • I've verified any visual changes using Percy (add a commit with [percy] in the message to trigger)

Copy link
Contributor

coderabbitai bot commented Jun 19, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Jun 19, 2025

Bundle Report

Changes will increase total bundle size by 260.41kB (0.68%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
client-array-push 38.35MB 260.41kB (0.68%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/*.svg 20 bytes 2.03kB 0.99%
assets/*.svg -17 bytes 2.55kB -0.66%
assets/*.svg 19 bytes 6.11kB 0.31%
assets/*.svg -121 bytes 12.09kB -0.99%
assets/*.svg 167 bytes 10.99kB 1.54%
assets/*.svg -553 bytes 6.69kB -7.63%
assets/*.svg -117 bytes 4.44kB -2.57%
assets/*.svg 9 bytes 2.17kB 0.42%
assets/*.svg 13 bytes 1.15kB 1.14%
assets/*.svg -26 bytes 3.43kB -0.75%
assets/*.svg -10 bytes 2.38kB -0.42%
assets/*.svg -146 bytes 3.98kB -3.54%
assets/*.svg -132 bytes 4.05kB -3.16%
assets/*.svg 150 bytes 7.8kB 1.96%
assets/*.svg 13 bytes 3.01kB 0.43%
assets/*.svg 14 bytes 3.67kB 0.38%
assets/*.svg 1.79kB 11.55kB 18.37% ⚠️
assets/*.svg -891 bytes 7.25kB -10.95%
assets/*.svg -19 bytes 2.16kB -0.87%
assets/*.svg -72 bytes 1.9kB -3.65%
assets/*.svg 158 bytes 5.96kB 2.72%
assets/*.svg 1.13kB 9.61kB 13.36% ⚠️
assets/*.svg 5 bytes 5.35kB 0.09%
assets/*.svg 167 bytes 1.97kB 9.26% ⚠️
assets/*.svg 102 bytes 4.8kB 2.17%
assets/*.svg 1.28kB 9.76kB 15.16% ⚠️
assets/*.svg -528 bytes 7.63kB -6.47%
assets/*.svg 100 bytes 8.48kB 1.19%
assets/*.svg -3 bytes 2.18kB -0.14%
assets/*.svg 3.79kB 8.77kB 75.98% ⚠️
assets/*.svg -71 bytes 4.18kB -1.67%
assets/*.svg 22 bytes 3.66kB 0.6%
assets/*.svg 5 bytes 3.72kB 0.13%
assets/*.svg -125 bytes 2.13kB -5.55%
assets/*.svg -129 bytes 4.12kB -3.04%
assets/*.svg 241 bytes 2.01kB 13.59% ⚠️
assets/*.svg 74 bytes 1.8kB 4.28%
assets/*.svg 84 bytes 1.14kB 7.96% ⚠️
assets/*.svg -676 bytes 4.25kB -13.72%
assets/*.svg 4.9kB 8.38kB 141.11% ⚠️
assets/*.svg 82 bytes 3.23kB 2.61%
assets/*.svg 10.43kB 13.81kB 308.28% ⚠️
assets/*.svg 5.57kB 8.48kB 191.27% ⚠️
assets/*.svg 2.92kB 5.8kB 101.28% ⚠️
assets/*.svg 1.84kB 4.37kB 72.66% ⚠️
assets/*.svg -14.46kB 53.51kB -21.28%
assets/*.svg 422 bytes 2.88kB 17.15% ⚠️
assets/*.svg 42.1kB 67.97kB 162.71% ⚠️
assets/*.svg 3.28kB 4.98kB 191.92% ⚠️
assets/*.svg 117 bytes 1.05kB 12.47% ⚠️
assets/*.svg -4.35MB 7.98kB -99.82%
assets/*.svg (New) 4.36MB 4.36MB 100.0% 🚀
assets/*.svg (New) 4.25kB 4.25kB 100.0% 🚀
assets/*.svg (New) 1.24kB 1.24kB 100.0% 🚀
assets/*.svg (New) 938 bytes 938 bytes 100.0% 🚀
assets/*.svg (New) 12.37kB 12.37kB 100.0% 🚀
assets/*.svg (New) 2.86kB 2.86kB 100.0% 🚀
assets/*.svg (New) 2.0kB 2.0kB 100.0% 🚀
assets/*.svg (New) 2.39kB 2.39kB 100.0% 🚀
assets/chunk.*.js 3.21kB 3.0MB 0.11%
assets/chunk.*.js 83 bytes 26.51kB 0.31%
assets/*.png (Deleted) -32.16kB 0 bytes -100.0% 🗑️
assets/*.png (Deleted) -8.58kB 0 bytes -100.0% 🗑️
assets/*.png (Deleted) -19.02kB 0 bytes -100.0% 🗑️
assets/*.png (Deleted) -66.14kB 0 bytes -100.0% 🗑️
assets/*.jpeg -20.62kB 12.72kB -61.86%
assets/*.jpeg (New) 16.02kB 16.02kB 100.0% 🚀
assets/*.jpeg (New) 37.29kB 37.29kB 100.0% 🚀
assets/*.jpeg (New) 161.33kB 161.33kB 100.0% 🚀
assets/*.jpeg (New) 58.72kB 58.72kB 100.0% 🚀
assets/*.jpeg (New) 33.34kB 33.34kB 100.0% 🚀

Files in assets/chunk.*.js:

  • ./assets/images/company-logos/mit-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/meta-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/jpmorgan-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/figma-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/hcltech-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/amazon-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/coinbase-company-logo.svg → Total Size: 42 bytes

  • ./controllers/pay.ts → Total Size: 5.29kB

  • ./assets/images/company-logos/gitlab-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/apple-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/google-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/mapbox-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/hashicorp-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/aws-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/harvard-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/bookingcom-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/cloudflare-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/dropbox-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/docker-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/nextjs-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/deliveroo-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/instagram-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/grab-company-logo.svg → Total Size: 42 bytes

  • ./assets/images/company-logos/adobe-company-logo.svg → Total Size: 42 bytes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get Arief to edit all of these files -- since this one has so much space around it, it's going to look smaller than the other logos when rendered.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just point arief to this directory, ask him to revise all logos to make them similarly sized. Our rendering technique is to enforce same height of all logos. These should look good when rendered both in testimonials cards and in places like this:

Screenshot 2025-06-20 at 15 24 33

@rohitpaulk
Copy link
Member

rohitpaulk commented Jun 24, 2025

Screenshot 2025-06-24 at 14 29 35 Screenshot 2025-06-24 at 14 29 38

(Pinged Arief about this)

@rohitpaulk rohitpaulk closed this Jun 24, 2025
@rohitpaulk rohitpaulk reopened this Jun 24, 2025
@vedantnene vedantnene closed this Jun 25, 2025
@vedantnene vedantnene reopened this Jun 25, 2025
@vedantnene vedantnene enabled auto-merge June 25, 2025 20:48
@vedantnene vedantnene disabled auto-merge June 25, 2025 20:48
@rohitpaulk rohitpaulk merged commit 74d64f2 into codecrafters-io:main Jun 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants