Add allowed cookies field in druid datasource settings

[Spikatrix]

Summary by CodeRabbit

• New Features
  • Added the ability to specify allowed cookies for forwarding to the data source in Druid connection settings.

[coderabbitai]

Walkthrough

The Grafadruid-Druid datasource plugin for Grafana has been updated to handle cookie management. Specifically, it now allows users to specify which cookies should be retained when making requests to the Druid datasource. This is achieved through new UI components for cookie specification and updates to the configuration settings to include a keepCookies field.

Changes

File Path	Change Summary
.../grafadruid-druid-datasource/ConfigEditor.tsx	Added connectionJsonData property and included keepCookies in state's jsonData.
.../DruidHttpSettings.tsx	Inserted TagsInput and InlineFormLabel for allowed cookies input.
.../types.ts	Extended ConnectionSettingsOptions with optional jsonData.keepCookies.

🐇✨
To Grafana's code, a change we bestow,
With tags and cookies lined up in a row.
A rabbit's touch, so deft and so quick,
Now keep your cookies, just take your pick! 🍪🌟

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 10beaa2 and 8b9b400.

Files selected for processing (3)

• public/app/plugins/datasource/grafadruid-druid-datasource/ConfigEditor.tsx (2 hunks)
• public/app/plugins/datasource/grafadruid-druid-datasource/configuration/ConnectionSettings/DruidHttpSettings.tsx (2 hunks)
• public/app/plugins/datasource/grafadruid-druid-datasource/configuration/ConnectionSettings/types.ts (1 hunks)

Additional comments: 4

public/app/plugins/datasource/grafadruid-druid-datasource/configuration/ConnectionSettings/types.ts (1)

• 19-21: The addition of the keepCookies property to the ConnectionSettingsOptions interface is well-aligned with the PR objectives to allow users to specify cookies to be forwarded to the Druid data source.

public/app/plugins/datasource/grafadruid-druid-datasource/configuration/ConnectionSettings/DruidHttpSettings.tsx (1)

• 95-107: The UI changes with the addition of TagsInput and InlineFormLabel in the DruidHttpSettings component are clear and user-friendly. Ensure that the user input is properly sanitized to prevent XSS vulnerabilities.

public/app/plugins/datasource/grafadruid-druid-datasource/ConfigEditor.tsx (2)

• 60-62: The changes to include connectionJsonData in the onConnectionOptionsChange method are correctly implemented to handle the new keepCookies field.

• 88-88: The defaulting of keepCookies to an empty array in the connectionOptions method is a good practice to avoid potential undefined issues.