Skip to content

Commit 30374bc

Browse files
committed
refactoring
1 parent 4411a7a commit 30374bc

File tree

3 files changed

+30
-30
lines changed

3 files changed

+30
-30
lines changed

src/Http/Livewire/CsvImporter.php

+15-15
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class CsvImporter extends Component
3939
public int $fileRowCount = 0;
4040

4141
/** @var array */
42-
protected $exception = [
42+
protected $exceptions = [
4343
'mode', 'columnsToMap', 'open',
4444
'columnLabels', 'requiredColumns',
4545
];
@@ -123,19 +123,19 @@ protected function importCsv()
123123
$import = $this->createNewImport();
124124
$chunks = (new ChunkIterator($this->csvRecords->getIterator(), 10))->get();
125125

126-
$jobs = collect($chunks)
127-
->map(
128-
fn ($chunk) => new ImportCsv(
129-
$import,
130-
$this->model,
131-
$chunk,
132-
$this->columnsToMap
133-
)
134-
);
135-
136-
Bus::batch($jobs)
137-
->finally(
138-
fn () => $import->touch('compoleted_at')
139-
)->dispatch();
126+
// $jobs = collect($chunks)
127+
// ->map(
128+
// fn ($chunk) => new ImportCsv(
129+
// $import,
130+
// $this->model,
131+
// $chunk,
132+
// $this->columnsToMap
133+
// )
134+
// );
135+
136+
// Bus::batch($jobs)
137+
// ->finally(
138+
// fn () => $import->touch('compoleted_at')
139+
// )->dispatch();
140140
}
141141
}

tests/ImportCsvTest.php renamed to tests/CsvImporterTest.php

+13-13
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
11
<?php
22

3-
use Coderflex\LaravelCsv\Http\Livewire\ImportCsv;
3+
use Coderflex\LaravelCsv\Http\Livewire\CsvImporter;
44
use Coderflex\LaravelCsv\Models\Import;
55
use Coderflex\LaravelCsv\Tests\Models\Customer;
66
use Illuminate\Http\UploadedFile;
77
use Illuminate\Support\Facades\Storage;
88
use function Pest\Livewire\livewire;
99

1010
it('renders import CSV component', function () {
11-
livewire(ImportCsv::class)
11+
livewire(CsvImporter::class)
1212
->assertSuccessful();
1313
});
1414

1515
it('renders import CSV component with model', function () {
1616
$model = Customer::class;
1717

18-
livewire(ImportCsv::class, [
18+
livewire(CsvImporter::class, [
1919
'model' => $model,
2020
])
2121
->assertSet('model', $model)
@@ -31,7 +31,7 @@
3131
file_get_contents('stubs/customers.csv', true)
3232
);
3333

34-
livewire(ImportCsv::class, [
34+
livewire(CsvImporter::class, [
3535
'model' => $model,
3636
])
3737
->set('file', $file)
@@ -48,7 +48,7 @@
4848
file_get_contents('stubs/empty.csv', true)
4949
);
5050

51-
livewire(ImportCsv::class, [
51+
livewire(CsvImporter::class, [
5252
'model' => $model,
5353
])
5454
->set('file', $file)
@@ -65,7 +65,7 @@
6565
file_get_contents('stubs/file_with_duplicate_headers.csv', true)
6666
);
6767

68-
livewire(ImportCsv::class, [
68+
livewire(CsvImporter::class, [
6969
'model' => $model,
7070
])
7171
->set('file', $file)
@@ -81,7 +81,7 @@
8181
];
8282
$model = Customer::class;
8383

84-
livewire(ImportCsv::class, [
84+
livewire(CsvImporter::class, [
8585
'model' => $model,
8686
'columnsToMap' => $columnsToMap,
8787
])
@@ -108,7 +108,7 @@
108108
];
109109
$model = Customer::class;
110110

111-
livewire(ImportCsv::class, [
111+
livewire(CsvImporter::class, [
112112
'model' => $model,
113113
'columnsToMap' => $columnsToMap,
114114
'requiredColumns' => $requiredColumns,
@@ -137,7 +137,7 @@
137137

138138
$model = Customer::class;
139139

140-
livewire(ImportCsv::class, [
140+
livewire(CsvImporter::class, [
141141
'model' => $model,
142142
'columnsToMap' => $columnsToMap,
143143
'requiredColumns' => $requiredColumns,
@@ -161,7 +161,7 @@
161161

162162
$model = Customer::class;
163163

164-
livewire(ImportCsv::class, [
164+
livewire(CsvImporter::class, [
165165
'model' => $model,
166166
])
167167
->set('file', $file)
@@ -178,7 +178,7 @@
178178
$file = UploadedFile::fake()->create('image.png');
179179
$model = Customer::class;
180180

181-
livewire(ImportCsv::class, [
181+
livewire(CsvImporter::class, [
182182
'model' => $model,
183183
])
184184
->set('file', $file)
@@ -209,7 +209,7 @@
209209

210210
$model = Customer::class;
211211

212-
livewire(ImportCsv::class, [
212+
livewire(CsvImporter::class, [
213213
'model' => $model,
214214
'columnsToMap' => $columnsToMap,
215215
'requiredColumns' => $requiredColumns,
@@ -231,7 +231,7 @@
231231

232232
$model = Customer::class;
233233

234-
livewire(ImportCsv::class, [
234+
livewire(CsvImporter::class, [
235235
'model' => $model,
236236
])
237237
->set('file', $file)

tests/TestCase.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
namespace Coderflex\LaravelCsv\Tests;
44

5+
use Coderflex\LaravelCsv\Http\Livewire\CsvImporter;
56
use Coderflex\LaravelCsv\Http\Livewire\HandleImports;
6-
use Coderflex\LaravelCsv\Http\Livewire\ImportCsv;
77
use Coderflex\LaravelCsv\LaravelCsvServiceProvider;
88
use Illuminate\Database\Eloquent\Factories\Factory;
99
use Livewire\Livewire;
@@ -46,7 +46,7 @@ public function getEnvironmentSetUp($app)
4646

4747
public function registerLivewireComponents()
4848
{
49-
Livewire::component(ImportCsv::class, 'import-csv');
49+
Livewire::component(CsvImporter::class, 'csv-importer');
5050
Livewire::component(HandleImports::class, 'handle-imports');
5151
}
5252
}

0 commit comments

Comments
 (0)