Fix toRfc3339String

Author: riasvdv

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to `laravel-feed` will be documented in this file
 
+## 3.1.2 - 2020-12-09
+
+- Fix issue with Rfc3339 string
+
 ## 3.1.1 - 2020-12-07
 
 - RFC3339 compliant updated field (#136)

resources/views/atom.blade.php

@@ -31,7 +31,7 @@
                 <![CDATA[{!! $category !!}]]>
             </category>
             @endforeach
-            <updated>{{ $item->updated->toRssString() }}</updated>
+            <updated>{{ $item->updated->toRfc3339String() }}</updated>
         </entry>
     @endforeach
 </feed>

resources/views/rss.blade.php

@@ -17,7 +17,7 @@
                 <description><![CDATA[{!! $item->summary !!}]]></description>
                 <author><![CDATA[{{ $item->author }}]]></author>
                 <guid>{{ url($item->id) }}</guid>
-                <pubDate>{{ $item->updated->toRssString() }}</pubDate>
+                <pubDate>{{ $item->updated->toRfc3339String() }}</pubDate>
                 @foreach($item->category as $category)
                     <category>{{ $category }}</category>
                 @endforeach

src/Feed.php

@@ -94,6 +94,6 @@ protected function lastUpdated(): string
 
         return $this->feedItems->sortBy(function ($feedItem) {
             return $feedItem->updated;
-        })->last()->updated->toRssString();
+        })->last()->updated->toRfc3339String();
     }
 }

src/FeedItem.php

@@ -62,7 +62,7 @@ public function title(string $title): self
 
     public function updated(Carbon $updated): self
     {
-        $this->updated = $updated->toRfc3339String();
+        $this->updated = $updated;
 
         return $this;
     }

tests/FeedItemTest.php

@@ -14,4 +14,17 @@ public function a_feed_is_invalid_if_a_field_is_missing()
 
         FeedItem::create()->validate();
     }
+
+    /** @test * */
+    public function it_can_be_created_without_errors()
+    {
+        FeedItem::create()
+            ->title('A title')
+            ->category('a category')
+            ->link('https://spatie.be')
+            ->author('an author')
+            ->updated(now());
+
+        $this->expectNotToPerformAssertions();
+    }
 }