Tests OK

Author: Sébastien Geiser

CodingSeb.Converters.Tests/CodingSeb.Converters.Tests.csproj

@@ -7,8 +7,9 @@
 
   <ItemGroup>
     <PackageReference Include="NUnit" Version="3.12.0" />
+    <PackageReference Include="NUnit3TestAdapter" Version="3.15.1" />
     <PackageReference Include="Shouldly" Version="3.0.2" />
-    <PackageReference Include="System.Drawing.Common" Version="4.6.1" />
+    <PackageReference Include="System.Drawing.Common" Version="4.7.0" />
   </ItemGroup>
 
   <ItemGroup>

CodingSeb.Converters.Tests/StringContainsConverterTest.cs

@@ -1,5 +1,6 @@
 using NUnit.Framework;
 using Shouldly;
+using System;
 
 namespace CodingSeb.Converters.Tests
 {
@@ -17,7 +18,7 @@ public void SimpleStringContainsConvert()
             ((bool)converter.Convert("This is a Test !!!", null, null, null)).ShouldBeTrue();
             ((bool)converter.Convert("This is a test !!!", null, null, null)).ShouldBeFalse();
 
-            converter.IgnoreCase = true;
+            converter.StringComparison = StringComparison.OrdinalIgnoreCase;
 
             ((bool)converter.Convert("This is a test !!!", null, null, null)).ShouldBeTrue();
         }

CodingSeb.Converters/CodingSeb.Converters.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp3.0;net4.7</TargetFrameworks>
+    <TargetFrameworks>netcoreapp3.0;net47</TargetFrameworks>
     <UseWPF>true</UseWPF>
     <Description>Some Converters to use in WPF</Description>
     <PackageReleaseNotes />

CodingSeb.Converters/Converters/StringContainsConverter.cs

@@ -22,22 +22,15 @@ public class StringContainsConverter : BaseConverter, IValueConverter
         public string ContainsString { get; set; } = string.Empty;
 
         /// <summary>
-        /// if <c>true</c>, ignore case of the string to find ContainsString, if <c>false</c> take care of the case. By default : false
+        /// To specify the culture and case of the equals
         /// </summary>
-        public bool IgnoreCase { get; set; }
+        public StringComparison StringComparison { get; set; }
 
         public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
         {
             if (DesignerProperties.GetIsInDesignMode(new DependencyObject()) && InDesigner != null) return InDesigner.Value;
 
-            if (IgnoreCase)
-            {
-                return value.ToString().ToLower().Contains(ContainsString.ToLower().EscapeForXaml());
-            }
-            else
-            {
-                return value.ToString().Contains(ContainsString.EscapeForXaml());
-            }
+            return value.ToString().IndexOf(ContainsString.EscapeForXaml(), StringComparison) > -1;
         }
 
         public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)

CodingSeb.Converters/Converters/StringEqualsConverter.cs

@@ -36,7 +36,7 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
         {
             if (DesignerProperties.GetIsInDesignMode(new DependencyObject()) && InDesigner != null) return InDesigner.Value;
 
-            return value.ToString().Equals(Value, StringComparison);
+            return value.ToString().Equals(Value.EscapeForXaml(), StringComparison);
         }
 
         /// <summary>