Skip to content

Commit a44de4f

Browse files
author
vrana
committedAug 27, 2012
Link interfaces as classes
Summary: We link classes from `extends` and `instanceof` (which can be both interface and class) and from `implements` (which is always interface). We don't need to split these two because they share the same namespace. If we decide to then we will need to: - Fix [[ https://secure.phabricator.com/diffusion/P/browse/master/src/applications/diffusion/controller/DiffusionSymbolController.php;66a300768a62bbc9$79 | DiffusionSymbolController ]] - Fix [[ https://secure.phabricator.com/diffusion/P/browse/master/webroot/rsrc/js/application/repository/repository-crossreference.js;66a300768a62bbc9$24 | repository-crossreference ]] - Allow more types in `DiffusionSymbolController`. Test Plan: Ran the script on secure.phabricator.com, clicked on `ArcanistLintRenderer` symbol. Reviewers: epriestley, alanh Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3382
1 parent 8d7f5ee commit a44de4f

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed
 

‎scripts/symbols/generate_php_symbols.php

+2-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@
6363
$interfaces = $root->selectDescendantsOfType('n_INTERFACE_DECLARATION');
6464
foreach ($interfaces as $interface) {
6565
$interface_name = $interface->getChildByIndex(1);
66-
print_symbol($file, 'interface', $interface_name);
66+
// We don't differentiate classes and interfaces in highlighters.
67+
print_symbol($file, 'class', $interface_name);
6768
$scopes[] = array($interface, $interface_name);
6869
}
6970

0 commit comments

Comments
 (0)
Failed to load comments.