Skip to content

Commit bb4f9d7

Browse files
authored
Offcanvas not showing with .showing (#36353)
The transform of .showing was being overridden by .offcanvas.offcanvas-start, while .show wasn't. This resulted in an illusion of the offcanvas waiting for the backdrop, reported in #36347. Moving the show classes below the position classes fixes this problem.
1 parent 46bb9e7 commit bb4f9d7

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

scss/_offcanvas.scss

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -43,17 +43,6 @@
4343
@include box-shadow(var(--#{$prefix}offcanvas-box-shadow));
4444
@include transition(transform $offcanvas-transition-duration ease-in-out);
4545

46-
&.showing,
47-
&.show:not(.hiding) {
48-
transform: none;
49-
}
50-
51-
&.showing,
52-
&.hiding,
53-
&.show {
54-
visibility: visible;
55-
}
56-
5746
&.offcanvas-start {
5847
top: 0;
5948
left: 0;
@@ -88,6 +77,17 @@
8877
border-top: var(--#{$prefix}offcanvas-border-width) solid var(--#{$prefix}offcanvas-border-color);
8978
transform: translateY(100%);
9079
}
80+
81+
&.showing,
82+
&.show:not(.hiding) {
83+
transform: none;
84+
}
85+
86+
&.showing,
87+
&.hiding,
88+
&.show {
89+
visibility: visible;
90+
}
9191
}
9292

9393
@if not ($infix == "") {

0 commit comments

Comments
 (0)