Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tesseract): Support for rolling window without date range #9364

Merged
merged 5 commits into from
Mar 28, 2025

Conversation

waralexrom
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@waralexrom waralexrom requested a review from KSDaemon March 19, 2025 14:57
@waralexrom waralexrom requested a review from a team as a code owner March 19, 2025 14:57
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.72%. Comparing base (abe830c) to head (74a4afc).
Report is 29 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9364   +/-   ##
=======================================
  Coverage   83.72%   83.72%           
=======================================
  Files         229      229           
  Lines       82574    82614   +40     
=======================================
+ Hits        69138    69172   +34     
- Misses      13436    13442    +6     
Flag Coverage Δ
cubesql 83.72% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM. Left minor notes rgd tests

Comment on lines 1098 to 1099
it('rolling count without date range', async () => {
if (!getEnv('nativeSqlPlanner')) return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to mark test as skipped if !getEnv('nativeSqlPlanner'). Because now it's a bit weird: test runs every time, but in real it does nothing for !getEnv('nativeSqlPlanner') case. With skip - it will be clear that test is skipped.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, smth like this:

Suggested change
it('rolling count without date range', async () => {
if (!getEnv('nativeSqlPlanner')) return;
if (getEnv('nativeSqlPlanner')) {
it('rolling count without date range', async () => {
.....
});
} else {
it.skip('rolling count without date range', () => {});
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or even better:

testNativeFn = getEnv('nativeSqlPlanner')? it : it.skip;

and then use it for all tests that should run only for native:

 testNativeFn('rolling count without date range', async () => { ... });

With this approach, you can put all native tests into the same room and remove all if (!getEnv('nativeSqlPlanner')) return; checks.

@waralexrom waralexrom force-pushed the tesseract-rolling-window-without-date-range branch from be30231 to 8538a47 Compare March 28, 2025 15:10
@waralexrom waralexrom merged commit fd94b02 into master Mar 28, 2025
78 checks passed
@waralexrom waralexrom deleted the tesseract-rolling-window-without-date-range branch March 28, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants