Backed out 2 changesets (bug 1442931) for build bustages at ..\dom\bindings\mozwebidlcodegen\test\test_mozwebidlcodegen.py::TestWebIDLCodegenManager::test_copy_input on a CLOSED TREE

Backed out changeset 9f46e7d52b9b (bug 1442931)
Backed out changeset 608e21fcd167 (bug 1442931)

--HG--
rename : dom/chrome-webidl/ChannelWrapper.webidl => dom/webidl/ChannelWrapper.webidl
rename : dom/chrome-webidl/ChromeUtils.webidl => dom/webidl/ChromeUtils.webidl
rename : dom/chrome-webidl/DominatorTree.webidl => dom/webidl/DominatorTree.webidl
rename : dom/chrome-webidl/HeapSnapshot.webidl => dom/webidl/HeapSnapshot.webidl
rename : dom/chrome-webidl/InspectorUtils.webidl => dom/webidl/InspectorUtils.webidl
rename : dom/chrome-webidl/MatchGlob.webidl => dom/webidl/MatchGlob.webidl
rename : dom/chrome-webidl/MatchPattern.webidl => dom/webidl/MatchPattern.webidl
rename : dom/chrome-webidl/MozStorageAsyncStatementParams.webidl => dom/webidl/MozStorageAsyncStatementParams.webidl
rename : dom/chrome-webidl/MozStorageStatementParams.webidl => dom/webidl/MozStorageStatementParams.webidl
rename : dom/chrome-webidl/MozStorageStatementRow.webidl => dom/webidl/MozStorageStatementRow.webidl
rename : dom/chrome-webidl/PrecompiledScript.webidl => dom/webidl/PrecompiledScript.webidl
rename : dom/chrome-webidl/PromiseDebugging.webidl => dom/webidl/PromiseDebugging.webidl
rename : dom/chrome-webidl/StructuredCloneHolder.webidl => dom/webidl/StructuredCloneHolder.webidl
rename : dom/chrome-webidl/WebExtensionContentScript.webidl => dom/webidl/WebExtensionContentScript.webidl
rename : dom/chrome-webidl/WebExtensionPolicy.webidl => dom/webidl/WebExtensionPolicy.webidl

Author: AndreeaPavel

dom/bindings/Configuration.py

@@ -18,28 +18,19 @@ def __init__(self):
         pass
 
 
-def isChildPath(path, basePath):
-    path = os.path.normpath(path)
-    return os.path.commonprefix((path, basePath)) == basePath
-
-
 class Configuration(DescriptorProvider):
     """
     Represents global configuration state based on IDL parse data and
     the configuration file.
     """
-    def __init__(self, filename, webRoots, parseData, generatedEvents=[]):
+    def __init__(self, filename, parseData, generatedEvents=[]):
         DescriptorProvider.__init__(self)
 
         # Read the configuration file.
         glbl = {}
         execfile(filename, glbl)
         config = glbl['DOMInterfaces']
 
-        webRoots = tuple(map(os.path.normpath, webRoots))
-        def isInWebIDLRoot(path):
-            return any(isChildPath(path, root) for root in webRoots)
-
         # Build descriptors for all the interfaces we have in the parse data.
         # This allows callers to specify a subset of interfaces by filtering
         # |parseData|.
@@ -103,17 +94,6 @@ def isInWebIDLRoot(path):
                             "%s\n"
                             "%s" %
                             (partialIface.location, iface.location))
-                if not (iface.getExtendedAttribute("ChromeOnly") or
-                        not (iface.hasInterfaceObject() or
-                             iface.isNavigatorProperty()) or
-                        isInWebIDLRoot(iface.filename())):
-                    raise TypeError(
-                        "Interfaces which are exposed to the web may only be "
-                        "defined in a DOM WebIDL root %r. Consider marking "
-                        "the interface [ChromeOnly] if you do not want it "
-                        "exposed to the web.\n"
-                        "%s" %
-                        (webRoots, iface.location))
             self.interfaces[iface.identifier.name] = iface
             if iface.identifier.name not in config:
                 # Completely skip consequential interfaces with no descriptor

dom/bindings/mozwebidlcodegen/__init__.py

@@ -150,7 +150,7 @@ class WebIDLCodegenManager(LoggingMixin):
         'PrototypeList.cpp',
     }
 
-    def __init__(self, config_path, webidl_root, inputs, exported_header_dir,
+    def __init__(self, config_path, inputs, exported_header_dir,
                  codegen_dir, state_path, cache_dir=None, make_deps_path=None,
                  make_deps_target=None):
         """Create an instance that manages WebIDLs in the build system.
@@ -176,7 +176,6 @@ def __init__(self, config_path, webidl_root, inputs, exported_header_dir,
         input_paths, exported_stems, generated_events_stems, example_interfaces = inputs
 
         self._config_path = config_path
-        self._webidl_root = webidl_root
         self._input_paths = set(input_paths)
         self._exported_stems = set(exported_stems)
         self._generated_events_stems = set(generated_events_stems)
@@ -333,26 +332,8 @@ def _parse_webidl(self):
                 hashes[path] = hashlib.sha1(data).hexdigest()
                 parser.parse(data, path)
 
-        # Only these directories may contain WebIDL files with interfaces
-        # which are exposed to the web. WebIDL files in these roots may not
-        # be changed without DOM peer review.
-        #
-        # Other directories may contain WebIDL files as long as they only
-        # contain ChromeOnly interfaces. These are not subject to mandatory
-        # DOM peer review.
-        web_roots = (
-            # The main WebIDL root.
-            self._webidl_root,
-            # The binding config root, which contains some test-only
-            # interfaces.
-            os.path.dirname(self._config_path),
-            # The objdir sub-directory which contains generated WebIDL files.
-            self._codegen_dir,
-        )
-
         self._parser_results = parser.finish()
-        self._config = Configuration(self._config_path, web_roots,
-                                     self._parser_results,
+        self._config = Configuration(self._config_path, self._parser_results,
                                      self._generated_events_stems_as_array)
         self._input_hashes = hashes
 
@@ -565,7 +546,6 @@ def create_build_system_manager(topsrcdir, topobjdir, dist_dir):
     """Create a WebIDLCodegenManager for use by the build system."""
     src_dir = os.path.join(topsrcdir, 'dom', 'bindings')
     obj_dir = os.path.join(topobjdir, 'dom', 'bindings')
-    webidl_root = os.path.join(topsrcdir, 'dom', 'webidl')
 
     with open(os.path.join(obj_dir, 'file-lists.json'), 'rb') as fh:
         files = json.load(fh)
@@ -582,7 +562,6 @@ def create_build_system_manager(topsrcdir, topobjdir, dist_dir):
 
     return WebIDLCodegenManager(
         os.path.join(src_dir, 'Bindings.conf'),
-        webidl_root,
         inputs,
         os.path.join(dist_dir, 'include', 'mozilla', 'dom'),
         obj_dir,

dom/bindings/mozwebidlcodegen/test/test_mozwebidlcodegen.py

@@ -71,7 +71,6 @@ def _get_manager_args(self):
 
         return dict(
             config_path=self._config_path,
-            webidl_root='/',
             inputs=inputs,
             exported_header_dir=mozpath.join(tmp, 'exports'),
             codegen_dir=mozpath.join(tmp, 'codegen'),

dom/chrome-webidl/moz.build

@@ -41,7 +41,6 @@ DIRS += [
     'browser-element',
     'cache',
     'canvas',
-    'chrome-webidl',
     'clients',
     'commandhandler',
     'credentialmanagement',

dom/moz.build

@@ -139,6 +139,9 @@ with Files("HTML*"):
 with Files("HashChangeEvent.webidl"):
     BUG_COMPONENT = ("Core", "DOM: Events")
 
+with Files("HeapSnapshot.webidl"):
+    BUG_COMPONENT = ("Firefox", "Developer Tools: Memory")
+
 with Files("HiddenPluginEvent.webidl"):
     BUG_COMPONENT = ("Core", "Plug-ins")
 
@@ -160,6 +163,9 @@ with Files("InputEvent.webidl"):
 with Files("InstallTrigger.webidl"):
     BUG_COMPONENT = ("Toolkit", "Add-ons Manager")
 
+with Files("InspectorUtils.webidl"):
+    BUG_COMPONENT = ("Firefox", "Developer Tools: Inspector")
+
 with Files("KeyAlgorithm.webidl"):
     BUG_COMPONENT = ("Core", "DOM: Security")
 
@@ -354,6 +360,7 @@ GENERATED_WEBIDL_FILES = [
 ]
 
 PREPROCESSED_WEBIDL_FILES = [
+    'ChromeUtils.webidl',
     'Node.webidl',
     'Window.webidl',
 ]
@@ -411,6 +418,7 @@ WEBIDL_FILES = [
     'CDATASection.webidl',
     'ChannelMergerNode.webidl',
     'ChannelSplitterNode.webidl',
+    'ChannelWrapper.webidl',
     'CharacterData.webidl',
     'CheckerboardReportService.webidl',
     'ChildNode.webidl',
@@ -475,6 +483,7 @@ WEBIDL_FILES = [
     'DOMError.webidl',
     'DOMException.webidl',
     'DOMImplementation.webidl',
+    'DominatorTree.webidl',
     'DOMMatrix.webidl',
     'DOMParser.webidl',
     'DOMPoint.webidl',
@@ -527,6 +536,7 @@ WEBIDL_FILES = [
     'GetUserMediaRequest.webidl',
     'Grid.webidl',
     'Headers.webidl',
+    'HeapSnapshot.webidl',
     'History.webidl',
     'HTMLAllCollection.webidl',
     'HTMLAnchorElement.webidl',
@@ -625,6 +635,7 @@ WEBIDL_FILES = [
     'ImageData.webidl',
     'ImageDocument.webidl',
     'InputEvent.webidl',
+    'InspectorUtils.webidl',
     'IntersectionObserver.webidl',
     'IntlUtils.webidl',
     'IterableIterator.webidl',
@@ -640,6 +651,8 @@ WEBIDL_FILES = [
     'ListBoxObject.webidl',
     'LocalMediaStream.webidl',
     'Location.webidl',
+    'MatchGlob.webidl',
+    'MatchPattern.webidl',
     'MediaDeviceInfo.webidl',
     'MediaDevices.webidl',
     'MediaElementAudioSourceNode.webidl',
@@ -680,6 +693,9 @@ WEBIDL_FILES = [
     'MimeTypeArray.webidl',
     'MouseEvent.webidl',
     'MouseScrollEvent.webidl',
+    'MozStorageAsyncStatementParams.webidl',
+    'MozStorageStatementParams.webidl',
+    'MozStorageStatementRow.webidl',
     'MutationEvent.webidl',
     'MutationObserver.webidl',
     'NamedNodeMap.webidl',
@@ -726,6 +742,7 @@ WEBIDL_FILES = [
     'PopupBoxObject.webidl',
     'Position.webidl',
     'PositionError.webidl',
+    'PrecompiledScript.webidl',
     'Presentation.webidl',
     'PresentationAvailability.webidl',
     'PresentationConnection.webidl',
@@ -735,6 +752,7 @@ WEBIDL_FILES = [
     'ProcessingInstruction.webidl',
     'ProfileTimelineMarker.webidl',
     'Promise.webidl',
+    'PromiseDebugging.webidl',
     'PushEvent.webidl',
     'PushManager.webidl',
     'PushManager.webidl',
@@ -772,6 +790,7 @@ WEBIDL_FILES = [
     'StorageType.webidl',
     'StreamFilter.webidl',
     'StreamFilterDataEvent.webidl',
+    'StructuredCloneHolder.webidl',
     'StyleSheet.webidl',
     'StyleSheetList.webidl',
     'SubtleCrypto.webidl',
@@ -926,6 +945,8 @@ WEBIDL_FILES = [
     'WaveShaperNode.webidl',
     'WebAuthentication.webidl',
     'WebComponents.webidl',
+    'WebExtensionContentScript.webidl',
+    'WebExtensionPolicy.webidl',
     'WebGL2RenderingContext.webidl',
     'WebGLRenderingContext.webidl',
     'WebKitCSSMatrix.webidl',