Skip to content

Commit 6abe98f

Browse files
saschanazsaschanaz
committed
Bug 1769290 - Part 8: Apply mozilla-js-handle-rooted-typedef against dom/canvas,crypto,fetch,gamepad,geolocation,indexedDB,ipc r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D148281
1 parent 1991e63 commit 6abe98f

24 files changed

+79
-65
lines changed

‎dom/canvas/ClientWebGLContext.cpp

+5-4
Original file line numberDiff line numberDiff line change
@@ -4470,7 +4470,7 @@ void ClientWebGLContext::GetVertexAttrib(JSContext* cx, GLuint index,
44704470

44714471
switch (pname) {
44724472
case LOCAL_GL_CURRENT_VERTEX_ATTRIB: {
4473-
JS::RootedObject obj(cx);
4473+
JS::Rooted<JSObject*> obj(cx);
44744474

44754475
const auto& attrib = genericAttribs[index];
44764476
switch (attrib.type) {
@@ -5774,8 +5774,9 @@ void ClientWebGLContext::GetActiveUniformBlockParameter(
57745774

57755775
case LOCAL_GL_UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES: {
57765776
const auto& indices = block.activeUniformIndices;
5777-
JS::RootedObject obj(cx, dom::Uint32Array::Create(
5778-
cx, this, indices.size(), indices.data()));
5777+
JS::Rooted<JSObject*> obj(
5778+
cx,
5779+
dom::Uint32Array::Create(cx, this, indices.size(), indices.data()));
57795780
if (!obj) {
57805781
rv = NS_ERROR_OUT_OF_MEMORY;
57815782
}
@@ -5820,7 +5821,7 @@ void ClientWebGLContext::GetActiveUniforms(
58205821
}
58215822
const auto& uniform = list[index];
58225823

5823-
JS::RootedValue value(cx);
5824+
JS::Rooted<JS::Value> value(cx);
58245825
switch (pname) {
58255826
case LOCAL_GL_UNIFORM_TYPE:
58265827
value = JS::NumberValue(uniform.elemType);

‎dom/canvas/ClientWebGLContext.h

+6-6
Original file line numberDiff line numberDiff line change
@@ -1115,7 +1115,7 @@ class ClientWebGLContext final : public nsICanvasRenderingContextInternal,
11151115
JS::MutableHandle<JS::Value> retval) const;
11161116

11171117
void GetIndexedParameter(JSContext* cx, GLenum target, GLuint index,
1118-
JS::MutableHandleValue retval,
1118+
JS::MutableHandle<JS::Value> retval,
11191119
ErrorResult& rv) const;
11201120

11211121
already_AddRefed<WebGLShaderPrecisionFormatJS> GetShaderPrecisionFormat(
@@ -1503,7 +1503,7 @@ class ClientWebGLContext final : public nsICanvasRenderingContextInternal,
15031503
// ----------------------- Renderbuffer objects -----------------------
15041504
void GetInternalformatParameter(JSContext* cx, GLenum target,
15051505
GLenum internalformat, GLenum pname,
1506-
JS::MutableHandleValue retval,
1506+
JS::MutableHandle<JS::Value> retval,
15071507
ErrorResult& rv);
15081508

15091509
void BindRenderbuffer(GLenum target, WebGLRenderbufferJS*);
@@ -2100,17 +2100,17 @@ class ClientWebGLContext final : public nsICanvasRenderingContextInternal,
21002100
// ---------------------------------
21012101
public:
21022102
void GetQuery(JSContext*, GLenum target, GLenum pname,
2103-
JS::MutableHandleValue retval) const;
2103+
JS::MutableHandle<JS::Value> retval) const;
21042104
void GetQueryParameter(JSContext*, WebGLQueryJS&, GLenum pname,
2105-
JS::MutableHandleValue retval) const;
2105+
JS::MutableHandle<JS::Value> retval) const;
21062106
void BeginQuery(GLenum target, WebGLQueryJS&);
21072107
void EndQuery(GLenum target);
21082108
void QueryCounter(WebGLQueryJS&, GLenum target) const;
21092109

21102110
// -------------------------------- Sampler -------------------------------
21112111

21122112
void GetSamplerParameter(JSContext*, const WebGLSamplerJS&, GLenum pname,
2113-
JS::MutableHandleValue retval) const;
2113+
JS::MutableHandle<JS::Value> retval) const;
21142114

21152115
void BindSampler(GLuint unit, WebGLSamplerJS*);
21162116
void SamplerParameteri(WebGLSamplerJS&, GLenum pname, GLint param) const;
@@ -2120,7 +2120,7 @@ class ClientWebGLContext final : public nsICanvasRenderingContextInternal,
21202120

21212121
GLenum ClientWaitSync(WebGLSyncJS&, GLbitfield flags, GLuint64 timeout) const;
21222122
void GetSyncParameter(JSContext*, WebGLSyncJS&, GLenum pname,
2123-
JS::MutableHandleValue retval) const;
2123+
JS::MutableHandle<JS::Value> retval) const;
21242124
void WaitSync(const WebGLSyncJS&, GLbitfield flags, GLint64 timeout) const;
21252125

21262126
// -------------------------- Transform Feedback ---------------------------

‎dom/crypto/CryptoKey.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ void CryptoKey::GetAlgorithm(JSContext* cx,
190190
JS::MutableHandle<JSObject*> aRetVal,
191191
ErrorResult& aRv) const {
192192
bool converted = false;
193-
JS::RootedValue val(cx);
193+
JS::Rooted<JS::Value> val(cx);
194194
switch (mAlgorithm.mType) {
195195
case KeyAlgorithmProxy::AES:
196196
converted = ToJSValue(cx, mAlgorithm.mAes, &val);

‎dom/crypto/WebCryptoTask.cpp

+4-3
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,8 @@ static nsresult GetAlgorithmName(JSContext* aCx, const OOS& aAlgorithm,
138138
aName.Assign(aAlgorithm.GetAsString());
139139
} else {
140140
// Coerce to algorithm and extract name
141-
JS::RootedValue value(aCx, JS::ObjectValue(*aAlgorithm.GetAsObject()));
141+
JS::Rooted<JS::Value> value(aCx,
142+
JS::ObjectValue(*aAlgorithm.GetAsObject()));
142143
Algorithm alg;
143144

144145
if (!alg.Init(aCx, value)) {
@@ -163,7 +164,7 @@ static nsresult Coerce(JSContext* aCx, T& aTarget, const OOS& aAlgorithm) {
163164
return NS_ERROR_DOM_SYNTAX_ERR;
164165
}
165166

166-
JS::RootedValue value(aCx, JS::ObjectValue(*aAlgorithm.GetAsObject()));
167+
JS::Rooted<JS::Value> value(aCx, JS::ObjectValue(*aAlgorithm.GetAsObject()));
167168
if (!aTarget.Init(aCx, value)) {
168169
return NS_ERROR_DOM_SYNTAX_ERR;
169170
}
@@ -1358,7 +1359,7 @@ class ImportKeyTask : public WebCryptoTask {
13581359

13591360
// Try JWK
13601361
ClearException ce(aCx);
1361-
JS::RootedValue value(aCx, JS::ObjectValue(*aKeyData));
1362+
JS::Rooted<JS::Value> value(aCx, JS::ObjectValue(*aKeyData));
13621363
if (!mJwk.Init(aCx, value)) {
13631364
mEarlyRv = NS_ERROR_DOM_DATA_ERR;
13641365
return;

‎dom/fetch/FetchUtil.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -671,7 +671,7 @@ static bool ThrowException(JSContext* aCx, unsigned errorNumber) {
671671
}
672672

673673
// static
674-
bool FetchUtil::StreamResponseToJS(JSContext* aCx, JS::HandleObject aObj,
674+
bool FetchUtil::StreamResponseToJS(JSContext* aCx, JS::Handle<JSObject*> aObj,
675675
JS::MimeType aMimeType,
676676
JS::StreamConsumer* aConsumer,
677677
WorkerPrivate* aMaybeWorker) {

‎dom/gamepad/GamepadServiceTest.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ already_AddRefed<Promise> GamepadServiceTest::NewTouch(
369369
}
370370

371371
JSObject* GamepadServiceTest::WrapObject(JSContext* aCx,
372-
JS::HandleObject aGivenProto) {
372+
JS::Handle<JSObject*> aGivenProto) {
373373
return GamepadServiceTest_Binding::Wrap(aCx, this, aGivenProto);
374374
}
375375

‎dom/gamepad/GamepadServiceTest.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,8 @@ class GamepadServiceTest final : public DOMEventTargetHelper,
8181
static already_AddRefed<GamepadServiceTest> CreateTestService(
8282
nsPIDOMWindowInner* aWindow);
8383
nsPIDOMWindowInner* GetParentObject() const { return mWindow; }
84-
JSObject* WrapObject(JSContext* aCx, JS::HandleObject aGivenProto) override;
84+
JSObject* WrapObject(JSContext* aCx,
85+
JS::Handle<JSObject*> aGivenProto) override;
8586

8687
private:
8788
// Hold a reference to the gamepad service so we don't have to worry about

‎dom/geolocation/Geolocation.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ class nsGeolocationRequest final : public ContentPermissionRequestBase,
8989

9090
// nsIContentPermissionRequest
9191
MOZ_CAN_RUN_SCRIPT NS_IMETHOD Cancel(void) override;
92-
MOZ_CAN_RUN_SCRIPT NS_IMETHOD Allow(JS::HandleValue choices) override;
92+
MOZ_CAN_RUN_SCRIPT NS_IMETHOD Allow(JS::Handle<JS::Value> choices) override;
9393

9494
void Shutdown();
9595

@@ -253,7 +253,7 @@ nsGeolocationRequest::Cancel() {
253253
}
254254

255255
NS_IMETHODIMP
256-
nsGeolocationRequest::Allow(JS::HandleValue aChoices) {
256+
nsGeolocationRequest::Allow(JS::Handle<JS::Value> aChoices) {
257257
MOZ_ASSERT(aChoices.isUndefined());
258258

259259
if (mLocator->ClearPendingRequest(this)) {

‎dom/indexedDB/IDBObjectStore.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,7 @@ void IDBObjectStore::AppendIndexUpdateInfo(
544544
}
545545

546546
for (uint32_t arrayIndex = 0; arrayIndex < arrayLength; arrayIndex++) {
547-
JS::RootedId indexId(aCx);
547+
JS::Rooted<JS::PropertyKey> indexId(aCx);
548548
if (NS_WARN_IF(!JS_IndexToId(aCx, arrayIndex, &indexId))) {
549549
IDB_REPORT_INTERNAL_ERR();
550550
aRv->Throw(NS_ERROR_DOM_INDEXEDDB_UNKNOWN_ERR);
@@ -563,7 +563,7 @@ void IDBObjectStore::AppendIndexUpdateInfo(
563563
continue;
564564
}
565565

566-
JS::RootedValue arrayItem(aCx);
566+
JS::Rooted<JS::Value> arrayItem(aCx);
567567
if (NS_WARN_IF(!JS_GetPropertyById(aCx, array, indexId, &arrayItem))) {
568568
IDB_REPORT_INTERNAL_ERR();
569569
aRv->Throw(NS_ERROR_DOM_INDEXEDDB_UNKNOWN_ERR);

‎dom/indexedDB/Key.cpp

+10-10
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include "Key.h"
88

99
#include <algorithm>
10-
#include <stdint.h> // for UINT32_MAX, uintptr_t
10+
#include <stdint.h> // for UINT32_MAX, uintptr_t
1111
#include "js/Array.h" // JS::NewArrayObject
1212
#include "js/ArrayBuffer.h" // JS::{IsArrayBufferObject,NewArrayBuffer{,WithContents},GetArrayBufferLengthAndData}
1313
#include "js/Date.h"
@@ -41,7 +41,7 @@ namespace {
4141
// https://w3c.github.io/IndexedDB/#convert-value-to-key
4242
template <typename ArrayConversionPolicy>
4343
IDBResult<Ok, IDBSpecialValue::Invalid> ConvertArrayValueToKey(
44-
JSContext* const aCx, JS::HandleObject aObject,
44+
JSContext* const aCx, JS::Handle<JSObject*> aObject,
4545
ArrayConversionPolicy&& aPolicy) {
4646
// 1. Let `len` be ? ToLength( ? Get(`input`, "length")).
4747
uint32_t len;
@@ -60,7 +60,7 @@ IDBResult<Ok, IDBSpecialValue::Invalid> ConvertArrayValueToKey(
6060

6161
// 5. While `index` is less than `len`:
6262
while (index < len) {
63-
JS::RootedId indexId(aCx);
63+
JS::Rooted<JS::PropertyKey> indexId(aCx);
6464
if (!JS_IndexToId(aCx, index, &indexId)) {
6565
return Err(IDBException(NS_ERROR_DOM_INDEXEDDB_UNKNOWN_ERR));
6666
}
@@ -77,7 +77,7 @@ IDBResult<Ok, IDBSpecialValue::Invalid> ConvertArrayValueToKey(
7777
}
7878

7979
// 3. Let `entry` be ? Get(`input`, `index`).
80-
JS::RootedValue entry(aCx);
80+
JS::Rooted<JS::Value> entry(aCx);
8181
if (!JS_GetPropertyById(aCx, aObject, indexId, &entry)) {
8282
return Err(IDBException(NS_ERROR_DOM_INDEXEDDB_UNKNOWN_ERR));
8383
}
@@ -330,7 +330,7 @@ class MOZ_STACK_CLASS Key::ArrayValueEncoder final {
330330
mTypeOffset(aTypeOffset),
331331
mRecursionDepth(aRecursionDepth) {}
332332

333-
void AddToSeenSet(JSContext* const aCx, JS::HandleObject) {
333+
void AddToSeenSet(JSContext* const aCx, JS::Handle<JSObject*>) {
334334
++mRecursionDepth;
335335
}
336336

@@ -345,9 +345,9 @@ class MOZ_STACK_CLASS Key::ArrayValueEncoder final {
345345
MOZ_ASSERT(mTypeOffset < eMaxType * kMaxArrayCollapse);
346346
}
347347

348-
IDBResult<Ok, IDBSpecialValue::Invalid> ConvertSubkey(JSContext* const aCx,
349-
JS::HandleValue aEntry,
350-
const uint32_t aIndex) {
348+
IDBResult<Ok, IDBSpecialValue::Invalid> ConvertSubkey(
349+
JSContext* const aCx, JS::Handle<JS::Value> aEntry,
350+
const uint32_t aIndex) {
351351
auto result =
352352
mKey.EncodeJSValInternal(aCx, aEntry, mTypeOffset, mRecursionDepth);
353353
mTypeOffset = 0;
@@ -406,7 +406,7 @@ IDBResult<Ok, IDBSpecialValue::Invalid> Key::EncodeJSValInternal(
406406
}
407407

408408
if (aVal.isObject()) {
409-
JS::RootedObject object(aCx, &aVal.toObject());
409+
JS::Rooted<JSObject*> object(aCx, &aVal.toObject());
410410

411411
js::ESClass builtinClass;
412412
if (!JS::GetBuiltinClass(aCx, object, &builtinClass)) {
@@ -845,7 +845,7 @@ Result<Ok, nsresult> Key::EncodeBinary(JSObject* aObject, bool aIsViewObject,
845845
// static
846846
JSObject* Key::DecodeBinary(const EncodedDataType*& aPos,
847847
const EncodedDataType* aEnd, JSContext* aCx) {
848-
JS::RootedObject rv(aCx);
848+
JS::Rooted<JSObject*> rv(aCx);
849849
DecodeStringy<eBinary, uint8_t>(
850850
aPos, aEnd,
851851
[&rv, aCx](uint8_t** out, uint32_t decodedSize) {

‎dom/ipc/ClonedErrorHolder.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ void ClonedErrorHolder::Init(JSContext* aCx, JS::Handle<JSObject*> aError,
120120
if (stack) {
121121
ar.emplace(aCx, stack);
122122
}
123-
JS::RootedValue stackValue(aCx, JS::ObjectOrNullValue(stack));
123+
JS::Rooted<JS::Value> stackValue(aCx, JS::ObjectOrNullValue(stack));
124124
mStack.Write(aCx, stackValue, aRv);
125125
}
126126

@@ -256,7 +256,7 @@ static bool ToJSString(JSContext* aCx, const nsACString& aStr,
256256
}
257257

258258
bool ClonedErrorHolder::ToErrorValue(JSContext* aCx,
259-
JS::MutableHandleValue aResult) {
259+
JS::MutableHandle<JS::Value> aResult) {
260260
JS::Rooted<JS::Value> stackVal(aCx);
261261
JS::Rooted<JSObject*> stack(aCx);
262262

‎dom/ipc/ClonedErrorHolder.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class ClonedErrorHolder final {
6565
// Creates a new JS Error or Exception/DOMException object based on the
6666
// values stored in the holder. Returns false and sets an exception on aCx
6767
// if it fails.
68-
bool ToErrorValue(JSContext* aCx, JS::MutableHandleValue aResult);
68+
bool ToErrorValue(JSContext* aCx, JS::MutableHandle<JS::Value> aResult);
6969

7070
class Holder final : public StructuredCloneHolder {
7171
public:

‎dom/ipc/ContentChild.cpp

+5-4
Original file line numberDiff line numberDiff line change
@@ -526,14 +526,14 @@ ConsoleListener::Observe(nsIConsoleMessage* aMessage) {
526526
jsapi.Init();
527527
JSContext* cx = jsapi.cx();
528528

529-
JS::RootedValue stack(cx);
529+
JS::Rooted<JS::Value> stack(cx);
530530
rv = scriptError->GetStack(&stack);
531531
NS_ENSURE_SUCCESS(rv, rv);
532532

533533
if (stack.isObject()) {
534534
// Because |stack| might be a cross-compartment wrapper, we can't use it
535535
// with JSAutoRealm. Use the stackGlobal for that.
536-
JS::RootedValue stackGlobal(cx);
536+
JS::Rooted<JS::Value> stackGlobal(cx);
537537
rv = scriptError->GetStackGlobal(&stackGlobal);
538538
NS_ENSURE_SUCCESS(rv, rv);
539539

@@ -1389,7 +1389,7 @@ void ContentChild::InitXPCOM(
13891389
MOZ_CRASH();
13901390
}
13911391
ErrorResult rv;
1392-
JS::RootedValue data(jsapi.cx());
1392+
JS::Rooted<JS::Value> data(jsapi.cx());
13931393
mozilla::dom::ipc::StructuredCloneData id;
13941394
id.Copy(aInitialData);
13951395
id.Read(jsapi.cx(), &data, rv);
@@ -4571,7 +4571,8 @@ NS_IMETHODIMP ContentChild::GetExistingActor(const nsACString& aName,
45714571
}
45724572

45734573
already_AddRefed<JSActor> ContentChild::InitJSActor(
4574-
JS::HandleObject aMaybeActor, const nsACString& aName, ErrorResult& aRv) {
4574+
JS::Handle<JSObject*> aMaybeActor, const nsACString& aName,
4575+
ErrorResult& aRv) {
45754576
RefPtr<JSProcessActorChild> actor;
45764577
if (aMaybeActor.get()) {
45774578
aRv = UNWRAP_OBJECT(JSProcessActorChild, aMaybeActor.get(), actor);

‎dom/ipc/ContentParent.cpp

+6-5
Original file line numberDiff line numberDiff line change
@@ -2937,7 +2937,7 @@ bool ContentParent::InitInternal(ProcessPriority aInitialPriority) {
29372937
if (NS_WARN_IF(!jsapi.Init(xpc::PrivilegedJunkScope()))) {
29382938
MOZ_CRASH();
29392939
}
2940-
JS::RootedValue init(jsapi.cx());
2940+
JS::Rooted<JS::Value> init(jsapi.cx());
29412941
// We'll crash on failure, so use a IgnoredErrorResult (which also
29422942
// auto-suppresses exceptions).
29432943
IgnoredErrorResult rv;
@@ -4768,18 +4768,18 @@ mozilla::ipc::IPCResult ContentParent::RecvScriptErrorInternal(
47684768
}
47694769
JSContext* cx = jsapi.cx();
47704770

4771-
JS::RootedValue stack(cx);
4771+
JS::Rooted<JS::Value> stack(cx);
47724772
ErrorResult rv;
47734773
data.Read(cx, &stack, rv);
47744774
if (rv.Failed() || !stack.isObject()) {
47754775
rv.SuppressException();
47764776
return IPC_OK();
47774777
}
47784778

4779-
JS::RootedObject stackObj(cx, &stack.toObject());
4779+
JS::Rooted<JSObject*> stackObj(cx, &stack.toObject());
47804780
MOZ_ASSERT(JS::IsUnwrappedSavedFrame(stackObj));
47814781

4782-
JS::RootedObject stackGlobal(cx, JS::GetNonCCWObjectGlobal(stackObj));
4782+
JS::Rooted<JSObject*> stackGlobal(cx, JS::GetNonCCWObjectGlobal(stackObj));
47834783
msg = new nsScriptErrorWithStack(JS::NothingHandleValue, stackObj,
47844784
stackGlobal);
47854785
} else {
@@ -7608,7 +7608,8 @@ NS_IMETHODIMP ContentParent::GetExistingActor(const nsACString& aName,
76087608
}
76097609

76107610
already_AddRefed<JSActor> ContentParent::InitJSActor(
7611-
JS::HandleObject aMaybeActor, const nsACString& aName, ErrorResult& aRv) {
7611+
JS::Handle<JSObject*> aMaybeActor, const nsACString& aName,
7612+
ErrorResult& aRv) {
76127613
RefPtr<JSProcessActorParent> actor;
76137614
if (aMaybeActor.get()) {
76147615
aRv = UNWRAP_OBJECT(JSProcessActorParent, aMaybeActor.get(), actor);

‎dom/ipc/InProcessChild.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class InProcessChild final : public nsIDOMProcessChild,
4848
const nsACString& GetRemoteType() const override { return NOT_REMOTE_TYPE; }
4949

5050
protected:
51-
already_AddRefed<JSActor> InitJSActor(JS::HandleObject aMaybeActor,
51+
already_AddRefed<JSActor> InitJSActor(JS::Handle<JSObject*> aMaybeActor,
5252
const nsACString& aName,
5353
ErrorResult& aRv) override;
5454
mozilla::ipc::IProtocol* AsNativeActor() override { return this; }

‎dom/ipc/InProcessImpl.cpp

+4-2
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,8 @@ InProcessParent::GetExistingActor(const nsACString& aName,
166166
}
167167

168168
already_AddRefed<JSActor> InProcessParent::InitJSActor(
169-
JS::HandleObject aMaybeActor, const nsACString& aName, ErrorResult& aRv) {
169+
JS::Handle<JSObject*> aMaybeActor, const nsACString& aName,
170+
ErrorResult& aRv) {
170171
RefPtr<JSProcessActorParent> actor;
171172
if (aMaybeActor.get()) {
172173
aRv = UNWRAP_OBJECT(JSProcessActorParent, aMaybeActor.get(), actor);
@@ -227,7 +228,8 @@ InProcessChild::GetExistingActor(const nsACString& aName,
227228
}
228229

229230
already_AddRefed<JSActor> InProcessChild::InitJSActor(
230-
JS::HandleObject aMaybeActor, const nsACString& aName, ErrorResult& aRv) {
231+
JS::Handle<JSObject*> aMaybeActor, const nsACString& aName,
232+
ErrorResult& aRv) {
231233
RefPtr<JSProcessActorChild> actor;
232234
if (aMaybeActor.get()) {
233235
aRv = UNWRAP_OBJECT(JSProcessActorChild, aMaybeActor.get(), actor);

‎dom/ipc/InProcessParent.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class InProcessParent final : public nsIDOMProcessParent,
5050
const nsACString& GetRemoteType() const override { return NOT_REMOTE_TYPE; };
5151

5252
protected:
53-
already_AddRefed<JSActor> InitJSActor(JS::HandleObject aMaybeActor,
53+
already_AddRefed<JSActor> InitJSActor(JS::Handle<JSObject*> aMaybeActor,
5454
const nsACString& aName,
5555
ErrorResult& aRv) override;
5656
mozilla::ipc::IProtocol* AsNativeActor() override { return this; }

0 commit comments

Comments
 (0)