Bug 1631581 - Part 1: Rename NoInterfaceObject to LegacyNoInterfaceObject r=edgar

Differential Revision: https://phabricator.services.mozilla.com/D111209

Author: saschanaz

dom/bindings/mozwebidlcodegen/test/TestEvent.webidl

@@ -7,7 +7,7 @@ interface Event {};
 callback EventHandlerNonNull = any (Event event);
 typedef EventHandlerNonNull? EventHandler;
 
-[NoInterfaceObject]
+[LegacyNoInterfaceObject]
 interface TestEvent : EventTarget {
   attribute EventHandler onfoo;
 };

dom/bindings/parser/WebIDL.py

@@ -1006,7 +1006,7 @@ def finish(self, scope):
             if not self.hasInterfaceObject():
                 raise WebIDLError(
                     "Interface %s unexpectedly has [LegacyWindowAlias] "
-                    "and [NoInterfaceObject] together" % self.identifier.name,
+                    "and [LegacyNoInterfaceObject] together" % self.identifier.name,
                     [self.location],
                 )
             if not self.isExposedInWindow():
@@ -1120,13 +1120,13 @@ def finish(self, scope):
                 )
 
             # Interfaces which have interface objects can't inherit
-            # from [NoInterfaceObject] interfaces.
+            # from [LegacyNoInterfaceObject] interfaces.
             if self.parent.getExtendedAttribute(
-                "NoInterfaceObject"
-            ) and not self.getExtendedAttribute("NoInterfaceObject"):
+                "LegacyNoInterfaceObject"
+            ) and not self.getExtendedAttribute("LegacyNoInterfaceObject"):
                 raise WebIDLError(
                     "Interface %s does not have "
-                    "[NoInterfaceObject] but inherits from "
+                    "[LegacyNoInterfaceObject] but inherits from "
                     "interface %s which does"
                     % (self.identifier.name, self.parent.identifier.name),
                     [self.location, self.parent.location],
@@ -1161,7 +1161,7 @@ def finish(self, scope):
         if ctor is not None:
             if not self.hasInterfaceObject():
                 raise WebIDLError(
-                    "Can't have both a constructor and [NoInterfaceObject]",
+                    "Can't have both a constructor and [LegacyNoInterfaceObject]",
                     [self.location, ctor.location],
                 )
 
@@ -1821,10 +1821,11 @@ def addExtendedAttributes(self, attrs):
                     "TreatNonObjectAsNull cannot be specified on interfaces",
                     [attr.location, self.location],
                 )
-            elif identifier == "NoInterfaceObject":
+            elif identifier == "LegacyNoInterfaceObject":
                 if not attr.noArguments():
                     raise WebIDLError(
-                        "[NoInterfaceObject] must take no arguments", [attr.location]
+                        "[LegacyNoInterfaceObject] must take no arguments",
+                        [attr.location],
                     )
 
                 self._noInterfaceObject = True
@@ -8646,7 +8647,7 @@ def simpleExtendedAttr(str):
                     classNameOverride=classNameOverride,
                 )
                 itr_iface.addExtendedAttributes(
-                    [simpleExtendedAttr("NoInterfaceObject")]
+                    [simpleExtendedAttr("LegacyNoInterfaceObject")]
                 )
                 # Make sure the exposure set for the iterator interface is the
                 # same as the exposure set for the iterable interface, because

dom/bindings/parser/tests/test_constructor.py

@@ -537,7 +537,7 @@ def checkResults(results):
     try:
         parser.parse(
             """
-            [NoInterfaceObject]
+            [LegacyNoInterfaceObject]
             interface InterfaceWithoutInterfaceObject {
               constructor();
             };
@@ -549,7 +549,8 @@ def checkResults(results):
 
     harness.ok(
         threw,
-        "Can't have a constructor operation on a [NoInterfaceObject] " "interface",
+        "Can't have a constructor operation on a [LegacyNoInterfaceObject] "
+        "interface",
     )
 
     parser = parser.reset()

dom/bindings/parser/tests/test_constructor_no_interface_object.py

@@ -3,8 +3,8 @@ def WebIDLTest(parser, harness):
     try:
         parser.parse(
             """
-            [NoInterfaceObject]
-            interface TestConstructorNoInterfaceObject {
+            [LegacyNoInterfaceObject]
+            interface TestConstructorLegacyNoInterfaceObject {
               constructor();
             };
         """
@@ -20,21 +20,21 @@ def WebIDLTest(parser, harness):
 
     parser.parse(
         """
-        [NoInterfaceObject, NamedConstructor=FooBar]
-        interface TestNamedConstructorNoInterfaceObject {
+        [LegacyNoInterfaceObject, NamedConstructor=FooBar]
+        interface TestNamedConstructorLegacyNoInterfaceObject {
         };
     """
     )
 
-    # Test HTMLConstructor and NoInterfaceObject
+    # Test HTMLConstructor and LegacyNoInterfaceObject
     parser = parser.reset()
 
     threw = False
     try:
         parser.parse(
             """
-            [NoInterfaceObject]
-            interface TestHTMLConstructorNoInterfaceObject {
+            [LegacyNoInterfaceObject]
+            interface TestHTMLConstructorLegacyNoInterfaceObject {
               [HTMLConstructor] constructor();
             };
         """

dom/bindings/parser/tests/test_extended_attributes.py

@@ -4,7 +4,7 @@
 def WebIDLTest(parser, harness):
     parser.parse(
         """
-        [NoInterfaceObject]
+        [LegacyNoInterfaceObject]
         interface TestExtendedAttr {
           [Unforgeable] readonly attribute byte b;
         };

dom/bindings/parser/tests/test_securecontext_extended_attribute.py

@@ -473,12 +473,12 @@ def WebIDLTest(parser, harness):
         "Methods copied from non-[SecureContext] mixin should not be [SecureContext]",
     )
 
-    # Test SecureContext and NoInterfaceObject
+    # Test SecureContext and LegacyNoInterfaceObject
     parser = parser.reset()
     parser.parse(
         """
-        [NoInterfaceObject, SecureContext]
-        interface TestSecureContextNoInterfaceObject {
+        [LegacyNoInterfaceObject, SecureContext]
+        interface TestSecureContextLegacyNoInterfaceObject {
           void testSecureMethod(byte foo);
         };
     """
@@ -487,7 +487,7 @@ def WebIDLTest(parser, harness):
     harness.check(
         len(results[0].members),
         1,
-        "TestSecureContextNoInterfaceObject should have only one member",
+        "TestSecureContextLegacyNoInterfaceObject should have only one member",
     )
     harness.ok(
         results[0].getExtendedAttribute("SecureContext"),

dom/bindings/test/TestCodeGen.webidl

@@ -160,8 +160,7 @@ interface OnlyForUseInConstructor {
  NamedConstructor=Test4(record<DOMString, record<DOMString, any>> arg1),
  NamedConstructor=Test5(record<DOMString, sequence<record<DOMString, record<DOMString, sequence<sequence<any>>>>>> arg1),
  NamedConstructor=Test6(sequence<record<ByteString, sequence<sequence<record<ByteString, record<USVString, any>>>>>> arg1),
- Exposed=Window,
- ]
+ Exposed=Window]
 interface TestInterface {
   constructor();
   constructor(DOMString str);

dom/bindings/test/TestExampleGen.webidl

@@ -9,8 +9,7 @@
                            object? obj2, sequence<Dict> seq, optional any any2,
                            optional object obj3, optional object? obj4),
  NamedConstructor=Example2((long or record<DOMString, any>) arg1),
- Exposed=Window,
- ]
+ Exposed=Window]
 interface TestExampleInterface {
   constructor();
   constructor(DOMString str);

dom/bindings/test/TestJSImplGen.webidl

@@ -874,7 +874,7 @@ interface TestCImplementedInterface : TestJSImplInterface {
 interface TestCImplementedInterface2 {
 };
 
-[NoInterfaceObject,
+[LegacyNoInterfaceObject,
  JSImplementation="@mozilla.org/test-js-impl-interface;2",
  Exposed=Window]
 interface TestJSImplNoInterfaceObject {

dom/chrome-webidl/DocumentL10n.webidl

@@ -16,7 +16,7 @@
  * are added to the document, and is removed in case all links
  * of that type are removed from it.
  */
-[NoInterfaceObject,
+[LegacyNoInterfaceObject,
  Exposed=Window]
 interface DocumentL10n : DOMLocalization {
   /**

dom/chrome-webidl/JSProcessActor.webidl

@@ -75,6 +75,6 @@ dictionary ProcessActorChildOptions : ProcessActorSidedOptions {
    *
    * Unlike for JSWindowActor, observers are always invoked, and do not need to
    * pass an inner or outer window as subject.
-   **/
+   */
   sequence<ByteString> observers;
 };

dom/chrome-webidl/JSWindowActor.webidl

@@ -139,6 +139,6 @@ dictionary WindowActorChildOptions : WindowActorSidedOptions {
   * nsGlobalWindowOuter object as their subject, and the events will only be
   * dispatched to the corresponding window actor. If additional observer
   * notification's subjects are needed, please file a bug for that.
-  **/
+  */
   sequence<ByteString> observers;
 };

dom/webidl/DOMException.webidl

@@ -49,7 +49,7 @@ interface mixin ExceptionMembers
   readonly attribute DOMString               stack;
 };
 
-[NoInterfaceObject, Exposed=(Window,Worker)]
+[LegacyNoInterfaceObject, Exposed=(Window,Worker)]
 interface Exception {
   // The name of the error code (ie, a string repr of |result|).
   readonly attribute DOMString               name;

dom/webidl/DeviceMotionEvent.webidl

@@ -6,15 +6,15 @@
  * https://w3c.github.io/deviceorientation/
  */
 
-[NoInterfaceObject,
+[LegacyNoInterfaceObject,
   Exposed=Window]
 interface DeviceAcceleration {
   readonly attribute double? x;
   readonly attribute double? y;
   readonly attribute double? z;
 };
 
-[NoInterfaceObject,
+[LegacyNoInterfaceObject,
  Exposed=Window]
 interface DeviceRotationRate {
   readonly attribute double? alpha;

dom/webidl/External.webidl

@@ -4,7 +4,7 @@
  * You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-[NoInterfaceObject, JSImplementation="@mozilla.org/sidebar;1",
+[LegacyNoInterfaceObject, JSImplementation="@mozilla.org/sidebar;1",
  Exposed=Window]
 interface External
 {

dom/webidl/FeaturePolicy.webidl

@@ -7,7 +7,7 @@
  * https://w3c.github.io/webappsec-feature-policy/#idl-index
  */
 
-[NoInterfaceObject,
+[LegacyNoInterfaceObject,
  Exposed=Window]
 interface FeaturePolicy {
   boolean allowsFeature(DOMString feature, optional DOMString origin);

dom/webidl/FontFaceSet.webidl

@@ -18,7 +18,7 @@ dictionary FontFaceSetIteratorResult
 };
 
 // To implement FontFaceSet's iterator until we can use setlike.
-[NoInterfaceObject,
+[LegacyNoInterfaceObject,
  Exposed=Window]
 interface FontFaceSetIterator {
   [Throws] FontFaceSetIteratorResult next();

dom/webidl/GetUserMediaRequest.webidl

@@ -21,7 +21,7 @@ enum GetUserMediaRequestType {
     "recording-device-stopped"
 };
 
-[NoInterfaceObject,
+[LegacyNoInterfaceObject,
  Exposed=Window]
 interface GetUserMediaRequest {
   readonly attribute GetUserMediaRequestType type;

dom/webidl/ImageCaptureErrorEvent.webidl

@@ -23,7 +23,7 @@ dictionary ImageCaptureErrorEventInit : EventInit {
   ImageCaptureError? imageCaptureError = null;
 };
 
-[NoInterfaceObject,
+[LegacyNoInterfaceObject,
  Exposed=Window]
 interface ImageCaptureError {
   const unsigned short FRAME_GRAB_ERROR = 1;

dom/webidl/IntlUtils.webidl

@@ -24,7 +24,7 @@ dictionary LocaleInfo {
 /**
  * The IntlUtils interface provides helper functions for localization.
  */
-[NoInterfaceObject,
+[LegacyNoInterfaceObject,
  Exposed=Window]
 interface IntlUtils {
   /**

dom/webidl/MediaStreamError.webidl

@@ -13,7 +13,7 @@
 // TODO: This is an 'exception', not an interface, by virtue of needing to be
 // passed as a promise rejection-reason. Revisit if DOMException grows a customArg
 
-[ExceptionClass, NoInterfaceObject,
+[ExceptionClass, LegacyNoInterfaceObject,
  Exposed=Window]
 interface MediaStreamError {
   readonly attribute DOMString  name;

dom/webidl/Promise.webidl

@@ -14,6 +14,6 @@ callback AnyCallback = any (any value);
 
 // Hack to allow us to have JS owning and properly tracing/CCing/etc a
 // PromiseNativeHandler.
-[NoInterfaceObject, Exposed=(Window,Worker)]
+[LegacyNoInterfaceObject, Exposed=(Window,Worker)]
 interface PromiseNativeHandler {
 };

dom/webidl/RTCIdentityProvider.webidl

@@ -6,7 +6,7 @@
  * http://w3c.github.io/webrtc-pc/ (with https://github.com/w3c/webrtc-pc/pull/178)
  */
 
-[NoInterfaceObject,
+[LegacyNoInterfaceObject,
  Exposed=Window]
 interface RTCIdentityProviderRegistrar {
   void register(RTCIdentityProvider idp);