Bug 1255655 - Heap-allocate _progname. r=froydnj.

This saves almost 1 KiB per process.

--HG--
extra : rebase_source : 56e7d9451b0c647b1672dc23e6bc1117c5a20388

Author: nnethercote

toolkit/xre/nsSigHandlers.cpp

@@ -37,7 +37,7 @@
 #include <ucontext.h>
 #endif
 
-static char _progname[1024] = "huh?";
+static const char* gProgname = "huh?";
 
 // Note: some tests manipulate this value.
 unsigned int _gdb_sleep_duration = 300;
@@ -84,7 +84,7 @@ void
 ah_crap_handler(int signum)
 {
   printf("\nProgram %s (pid = %d) received signal %d.\n",
-         _progname,
+         gProgname,
          getpid(),
          signum);
 
@@ -94,7 +94,7 @@ ah_crap_handler(int signum)
 
   printf("Sleeping for %d seconds.\n",_gdb_sleep_duration);
   printf("Type 'gdb %s %d' to attach your debugger to this thread.\n",
-         _progname,
+         gProgname,
          getpid());
 
   // Allow us to be ptraced by gdb on Linux with Yama restrictions enabled.
@@ -227,9 +227,12 @@ static void fpehandler(int signum, siginfo_t *si, void *context)
 }
 #endif
 
-void InstallSignalHandlers(const char *ProgramName)
+void InstallSignalHandlers(const char *aProgname)
 {
-  PL_strncpy(_progname,ProgramName, (sizeof(_progname)-1) );
+  const char* tmp = PL_strdup(aProgname);
+  if (tmp) {
+    gProgname = tmp;
+  }
 
   const char *gdbSleep = PR_GetEnv("MOZ_GDB_SLEEP");
   if (gdbSleep && *gdbSleep)
@@ -383,14 +386,14 @@ LONG __stdcall FpeHandler(PEXCEPTION_POINTERS pe)
   return action;
 }
 
-void InstallSignalHandlers(const char *ProgramName)
+void InstallSignalHandlers(const char *aProgname)
 {
   gFPEPreviousFilter = SetUnhandledExceptionFilter(FpeHandler);
 }
 
 #else
 
-void InstallSignalHandlers(const char *ProgramName)
+void InstallSignalHandlers(const char *aProgname)
 {
 }