Bug 1753919 - Remove copy constructor from AndroidWebAuthnResult. r=geckoview-reviewers,agi

Let's remove copy situation of `AndroidWebAuthnResult`.

Differential Revision: https://phabricator.services.mozilla.com/D137975

Author: makotokato

dom/webauthn/AndroidWebAuthnTokenManager.cpp

@@ -229,22 +229,22 @@ RefPtr<U2FRegisterPromise> AndroidWebAuthnTokenManager::Register(
         // This is likely running on the main thread, so we'll always dispatch
         // to the background for state updates.
         MozPromise<AndroidWebAuthnResult, AndroidWebAuthnResult,
-                   false>::FromGeckoResult(geckoResult)
+                   true>::FromGeckoResult(geckoResult)
             ->Then(
                 GetMainThreadSerialEventTarget(), __func__,
-                [self = std::move(self)](const AndroidWebAuthnResult& aValue) {
-                  self->HandleRegisterResult(aValue);
+                [self = std::move(self)](AndroidWebAuthnResult&& aValue) {
+                  self->HandleRegisterResult(std::move(aValue));
                 },
-                [self = std::move(self)](const AndroidWebAuthnResult& aValue) {
-                  self->HandleRegisterResult(aValue);
+                [self = std::move(self)](AndroidWebAuthnResult&& aValue) {
+                  self->HandleRegisterResult(std::move(aValue));
                 });
       }));
 
   return mRegisterPromise.Ensure(__func__);
 }
 
 void AndroidWebAuthnTokenManager::HandleRegisterResult(
-    const AndroidWebAuthnResult& aResult) {
+    AndroidWebAuthnResult&& aResult) {
   if (!gAndroidPBackgroundThread) {
     // Promise is already rejected when shutting down background thread
     return;
@@ -262,7 +262,8 @@ void AndroidWebAuthnTokenManager::HandleRegisterResult(
   } else {
     gAndroidPBackgroundThread->Dispatch(NS_NewRunnableFunction(
         "AndroidWebAuthnTokenManager::RegisterComplete",
-        [self = RefPtr<AndroidWebAuthnTokenManager>(this), aResult]() {
+        [self = RefPtr<AndroidWebAuthnTokenManager>(this),
+         aResult = std::move(aResult)]() {
           CryptoBuffer emptyBuffer;
           nsTArray<WebAuthnExtensionResult> extensions;
           WebAuthnMakeCredentialResult result(
@@ -350,22 +351,22 @@ RefPtr<U2FSignPromise> AndroidWebAuthnTokenManager::Sign(
             extensionsBundle);
         auto geckoResult = java::GeckoResult::LocalRef(std::move(result));
         MozPromise<AndroidWebAuthnResult, AndroidWebAuthnResult,
-                   false>::FromGeckoResult(geckoResult)
+                   true>::FromGeckoResult(geckoResult)
             ->Then(
                 GetMainThreadSerialEventTarget(), __func__,
-                [self = std::move(self)](const AndroidWebAuthnResult& aValue) {
-                  self->HandleSignResult(aValue);
+                [self = std::move(self)](AndroidWebAuthnResult&& aValue) {
+                  self->HandleSignResult(std::move(aValue));
                 },
-                [self = std::move(self)](const AndroidWebAuthnResult& aValue) {
-                  self->HandleSignResult(aValue);
+                [self = std::move(self)](AndroidWebAuthnResult&& aValue) {
+                  self->HandleSignResult(std::move(aValue));
                 });
       }));
 
   return mSignPromise.Ensure(__func__);
 }
 
 void AndroidWebAuthnTokenManager::HandleSignResult(
-    const AndroidWebAuthnResult& aResult) {
+    AndroidWebAuthnResult&& aResult) {
   if (!gAndroidPBackgroundThread) {
     // Promise is already rejected when shutting down background thread
     return;
@@ -383,7 +384,8 @@ void AndroidWebAuthnTokenManager::HandleSignResult(
   } else {
     gAndroidPBackgroundThread->Dispatch(NS_NewRunnableFunction(
         "AndroidWebAuthnTokenManager::SignComplete",
-        [self = RefPtr<AndroidWebAuthnTokenManager>(this), aResult]() {
+        [self = RefPtr<AndroidWebAuthnTokenManager>(this),
+         aResult = std::move(aResult)]() {
           CryptoBuffer emptyBuffer;
 
           nsTArray<WebAuthnExtensionResult> emptyExtensions;

dom/webauthn/AndroidWebAuthnTokenManager.h

@@ -80,14 +80,8 @@ class AndroidWebAuthnResult {
     }
   }
 
-  AndroidWebAuthnResult(const AndroidWebAuthnResult& aOther)
-      : mAttObj(aOther.mAttObj.InfallibleClone()),
-        mKeyHandle(aOther.mKeyHandle.InfallibleClone()),
-        mClientDataJSON(aOther.mClientDataJSON),
-        mAuthData(aOther.mAuthData.InfallibleClone()),
-        mSignature(aOther.mSignature.InfallibleClone()),
-        mUserHandle(aOther.mUserHandle.InfallibleClone()),
-        mErrorCode(aOther.mErrorCode) {}
+  AndroidWebAuthnResult(const AndroidWebAuthnResult&) = delete;
+  AndroidWebAuthnResult(AndroidWebAuthnResult&&) = default;
 
   // Attestation-only
   CryptoBuffer mAttObj;
@@ -126,9 +120,9 @@ class AndroidWebAuthnTokenManager final : public U2FTokenTransport {
   static AndroidWebAuthnTokenManager* GetInstance();
 
  private:
-  void HandleRegisterResult(const AndroidWebAuthnResult& aResult);
+  void HandleRegisterResult(AndroidWebAuthnResult&& aResult);
 
-  void HandleSignResult(const AndroidWebAuthnResult& aResult);
+  void HandleSignResult(AndroidWebAuthnResult&& aResult);
 
   void ClearPromises() {
     mRegisterPromise.RejectIfExists(NS_ERROR_DOM_UNKNOWN_ERR, __func__);