Bug 1524290: Fix a potential memory leak in updater.cpp. r=rstrong

Stephen A Pohl · Stephen A Pohl · commit acf6d68ad884 · 2019-01-31T17:39:15.000-05:00
diff --git a/toolkit/mozapps/update/updater/updater.cpp b/toolkit/mozapps/update/updater/updater.cpp
@@ -4170,6 +4170,7 @@ int AddPreCompleteActions(ActionList *list) {
 
     rv = action->Parse(line);
     if (rv) {
+      delete action;
       free(buf);
       return rv;
     }

Original file line number	Diff line number	Diff line change
`@@ -4170,6 +4170,7 @@ int AddPreCompleteActions(ActionList *list) {`
`4170`	`4170`
`4171`	`4171`	`rv = action->Parse(line);`
`4172`	`4172`	`if (rv) {`
	`4173`	`+ delete action;`
`4173`	`4174`	`free(buf);`
`4174`	`4175`	`return rv;`
`4175`	`4176`	`}`