Bug 1392684 Remove const qualifier that gets discarded after function return in mscom::AgileReference r=aklotz

tomrittervg · tomrittervg · commit d0293ed01d36 · 2017-08-22T17:25:27.000-05:00
gcc throws a warning-as-error saying that the const qualifier will be ignored by function callers.
Remove the const qualifier to remove the warning.

MozReview-Commit-ID: JRQMz6Zdcdz

--HG--
extra : rebase_source : 687a7b310270823180b848d6c65cba7ba688b2ae
diff --git a/ipc/mscom/AgileReference.cpp b/ipc/mscom/AgileReference.cpp
@@ -135,7 +135,7 @@ AgileReference::ObtainGit()
 {
   // Internally to COM, the Global Interface Table is a singleton, therefore we
   // don't worry about holding onto this reference indefinitely.
-  static IGlobalInterfaceTable * const sGit = []() -> IGlobalInterfaceTable * const {
+  static IGlobalInterfaceTable* sGit = []() -> IGlobalInterfaceTable* {
     IGlobalInterfaceTable* result = nullptr;
     DebugOnly<HRESULT> hr =
       ::CoCreateInstance(CLSID_StdGlobalInterfaceTable, nullptr,

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ AgileReference::ObtainGit()`
`135`	`135`	`{`
`136`	`136`	`// Internally to COM, the Global Interface Table is a singleton, therefore we`
`137`	`137`	`// don't worry about holding onto this reference indefinitely.`
`138`		`- static IGlobalInterfaceTable * const sGit = []() -> IGlobalInterfaceTable * const {`
	`138`	`+ static IGlobalInterfaceTable* sGit = []() -> IGlobalInterfaceTable* {`
`139`	`139`	`IGlobalInterfaceTable* result = nullptr;`
`140`	`140`	`DebugOnly<HRESULT> hr =`
`141`	`141`	`::CoCreateInstance(CLSID_StdGlobalInterfaceTable, nullptr,`