Skip to content

Commit 0a62f13

Browse files
joshuaspenceepriestley
joshuaspence
authored and
epriestley
committed
Change double quotes to single quotes.
Summary: Ran `arc lint --apply-patches --everything` over rP, mainly to change double quotes to single quotes where appropriate. These changes also validate that the `ArcanistXHPASTLinter::LINT_DOUBLE_QUOTE` rule is working as expected. Test Plan: Eyeballed it. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin, hach-que Differential Revision: https://secure.phabricator.com/D9431
1 parent 78f7832 commit 0a62f13

File tree

560 files changed

+1721
-1722
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

560 files changed

+1721
-1722
lines changed

‎resources/sql/patches/059.engines.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
echo "Converting {$name}...\n";
2525
queryfx(
2626
$conn,
27-
"ALTER TABLE %T.%T ENGINE=InnoDB",
27+
'ALTER TABLE %T.%T ENGINE=InnoDB',
2828
$table['db'],
2929
$table['tbl']);
3030
}

‎resources/sql/patches/079.nametokenindex.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77
$table->beginReadLocking();
88

99
$users = $table->loadAll();
10-
echo count($users)." users to index";
10+
echo count($users).' users to index';
1111
foreach ($users as $user) {
1212
$user->updateNameTokens();
13-
echo ".";
13+
echo '.';
1414
}
1515

1616
$table->endReadLocking();

‎resources/sql/patches/090.forceuniqueprojectnames.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,9 @@
6464
}
6565
if (count($update) == $size) {
6666
throw new Exception(
67-
"Failed to make any progress while updating projects. Schema upgrade ".
68-
"has failed. Go manually fix your project names to be unique (they are ".
69-
"probably ridiculous?) and then try again.");
67+
'Failed to make any progress while updating projects. Schema upgrade '.
68+
'has failed. Go manually fix your project names to be unique (they are '.
69+
'probably ridiculous?) and then try again.');
7070
}
7171
}
7272

‎resources/sql/patches/102.heraldcleanup.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@
2424
mpull($rules, 'getID'));
2525
}
2626

27-
echo "This may take a moment";
27+
echo 'This may take a moment';
2828
do {
2929
queryfx(
3030
$conn_w,
3131
'DELETE FROM %T %Q LIMIT 1000',
3232
HeraldRule::TABLE_RULE_APPLIED,
3333
$clause);
34-
echo ".";
34+
echo '.';
3535
} while ($conn_w->getAffectedRows());
3636

3737
$table->endReadLocking();

‎resources/sql/patches/117.repositorydescription.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22

33
$conn = id(new PhabricatorRepository())->establishConnection('w');
44
if (queryfx_one($conn, "SHOW COLUMNS FROM `repository` LIKE 'description'")) {
5-
queryfx($conn, "ALTER TABLE `repository` DROP `description`");
5+
queryfx($conn, 'ALTER TABLE `repository` DROP `description`');
66
}

‎resources/sql/patches/131.migraterevisionquery.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
$table->beginReadLocking();
66
$conn_w = $table->establishConnection('w');
77

8-
echo "Migrating revisions";
8+
echo 'Migrating revisions';
99
do {
1010
$revisions = $table->loadAllWhere('branchName IS NULL LIMIT 1000');
1111

1212
foreach ($revisions as $revision) {
13-
echo ".";
13+
echo '.';
1414

1515
$diff = $revision->loadActiveDiff();
1616
if (!$diff) {

‎resources/sql/patches/20121209.xmacromigrate.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22

3-
echo "Giving image macros PHIDs";
3+
echo 'Giving image macros PHIDs';
44
$table = new PhabricatorFileImageMacro();
55
$table->openTransaction();
66

@@ -9,7 +9,7 @@
99
continue;
1010
}
1111

12-
echo ".";
12+
echo '.';
1313

1414
queryfx(
1515
$macro->establishConnection('w'),

‎resources/sql/patches/20130201.revisionunsubscribed.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
'SELECT id, phid, unsubscribed FROM differential_revision');
1212

1313
foreach ($revs as $rev) {
14-
echo ".";
14+
echo '.';
1515

1616
$unsubscribed = json_decode($rev['unsubscribed']);
1717
if (!$unsubscribed) {

‎resources/sql/patches/20130409.commitdrev.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@
2222
$editor->addEdge($commit->getPHID(), $commit_drev, $revision_phid);
2323
$edges++;
2424
if ($edges % 256 == 0) {
25-
echo ".";
25+
echo '.';
2626
$editor->save();
2727
$editor = id(new PhabricatorEdgeEditor())->setSuppressEvents(true);
2828
}
2929
}
3030

31-
echo ".";
31+
echo '.';
3232
$editor->save();
3333
echo "\nDone.\n";

‎resources/sql/patches/20130502.countdownrevamp2.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22

3-
echo "Giving countdowns PHIDs";
3+
echo 'Giving countdowns PHIDs';
44
$table = new PhabricatorCountdown();
55
$table->openTransaction();
66

@@ -9,7 +9,7 @@
99
continue;
1010
}
1111

12-
echo ".";
12+
echo '.';
1313

1414
queryfx(
1515
$countdown->establishConnection('w'),

‎resources/sql/patches/20130703.legalpaddocdenorm.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22

3-
echo "Populating Legalpad Documents with ",
3+
echo 'Populating Legalpad Documents with ',
44
"titles, recentContributorPHIDs, and contributorCounts...\n";
55
$table = new LegalpadDocument();
66
$table->openTransaction();

‎resources/sql/patches/20130711.pholioimageobsolete.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22

3-
echo "Giving pholio images PHIDs";
3+
echo 'Giving pholio images PHIDs';
44
$table = new PholioImage();
55
$table->openTransaction();
66

@@ -9,7 +9,7 @@
99
continue;
1010
}
1111

12-
echo ".";
12+
echo '.';
1313

1414
queryfx(
1515
$image->establishConnection('w'),

‎resources/sql/patches/20131205.buildstepordermig.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313

1414
$rows = queryfx_all(
1515
$conn_w,
16-
"SELECT id, sequence FROM harbormaster_buildstep ".
17-
"WHERE buildPlanPHID = %s ".
18-
"ORDER BY id ASC",
16+
'SELECT id, sequence FROM harbormaster_buildstep '.
17+
'WHERE buildPlanPHID = %s '.
18+
'ORDER BY id ASC',
1919
$plan->getPHID());
2020

2121
$sequence = 1;
@@ -29,9 +29,9 @@
2929
echo " - {$id} to position {$sequence}...\n";
3030
queryfx(
3131
$conn_w,
32-
"UPDATE harbormaster_buildstep ".
33-
"SET sequence = %d ".
34-
"WHERE id = %d",
32+
'UPDATE harbormaster_buildstep '.
33+
'SET sequence = %d '.
34+
'WHERE id = %d',
3535
$sequence,
3636
$id);
3737
$sequence++;

‎scripts/calendar/import_us_holidays.php

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -7,45 +7,45 @@
77
// http://www.opm.gov/operating_status_schedules/fedhol/
88
$holidays = array(
99
'2014-01-01' => "New Year's Day",
10-
'2014-01-20' => "Birthday of Martin Luther King, Jr.",
10+
'2014-01-20' => 'Birthday of Martin Luther King, Jr.',
1111
'2014-02-17' => "Washington's Birthday",
12-
'2014-05-26' => "Memorial Day",
13-
'2014-07-04' => "Independence Day",
14-
'2014-09-01' => "Labor Day",
15-
'2014-10-13' => "Columbus Day",
16-
'2014-11-11' => "Veterans Day",
17-
'2014-11-27' => "Thanksgiving Day",
18-
'2014-12-25' => "Christmas Day",
12+
'2014-05-26' => 'Memorial Day',
13+
'2014-07-04' => 'Independence Day',
14+
'2014-09-01' => 'Labor Day',
15+
'2014-10-13' => 'Columbus Day',
16+
'2014-11-11' => 'Veterans Day',
17+
'2014-11-27' => 'Thanksgiving Day',
18+
'2014-12-25' => 'Christmas Day',
1919
'2015-01-01' => "New Year's Day",
20-
'2015-01-19' => "Birthday of Martin Luther King, Jr.",
20+
'2015-01-19' => 'Birthday of Martin Luther King, Jr.',
2121
'2015-02-16' => "Washington's Birthday",
22-
'2015-05-25' => "Memorial Day",
23-
'2015-07-03' => "Independence Day",
24-
'2015-09-07' => "Labor Day",
25-
'2015-10-12' => "Columbus Day",
26-
'2015-11-11' => "Veterans Day",
27-
'2015-11-26' => "Thanksgiving Day",
28-
'2015-12-25' => "Christmas Day",
22+
'2015-05-25' => 'Memorial Day',
23+
'2015-07-03' => 'Independence Day',
24+
'2015-09-07' => 'Labor Day',
25+
'2015-10-12' => 'Columbus Day',
26+
'2015-11-11' => 'Veterans Day',
27+
'2015-11-26' => 'Thanksgiving Day',
28+
'2015-12-25' => 'Christmas Day',
2929
'2016-01-01' => "New Year's Day",
30-
'2016-01-18' => "Birthday of Martin Luther King, Jr.",
30+
'2016-01-18' => 'Birthday of Martin Luther King, Jr.',
3131
'2016-02-15' => "Washington's Birthday",
32-
'2016-05-30' => "Memorial Day",
33-
'2016-07-04' => "Independence Day",
34-
'2016-09-05' => "Labor Day",
35-
'2016-10-10' => "Columbus Day",
36-
'2016-11-11' => "Veterans Day",
37-
'2016-11-24' => "Thanksgiving Day",
38-
'2016-12-26' => "Christmas Day",
32+
'2016-05-30' => 'Memorial Day',
33+
'2016-07-04' => 'Independence Day',
34+
'2016-09-05' => 'Labor Day',
35+
'2016-10-10' => 'Columbus Day',
36+
'2016-11-11' => 'Veterans Day',
37+
'2016-11-24' => 'Thanksgiving Day',
38+
'2016-12-26' => 'Christmas Day',
3939
'2017-01-02' => "New Year's Day",
40-
'2017-01-16' => "Birthday of Martin Luther King, Jr.",
40+
'2017-01-16' => 'Birthday of Martin Luther King, Jr.',
4141
'2017-02-10' => "Washington's Birthday",
42-
'2017-05-29' => "Memorial Day",
43-
'2017-07-04' => "Independence Day",
44-
'2017-09-04' => "Labor Day",
45-
'2017-10-09' => "Columbus Day",
46-
'2017-11-10' => "Veterans Day",
47-
'2017-11-23' => "Thanksgiving Day",
48-
'2017-12-25' => "Christmas Day",
42+
'2017-05-29' => 'Memorial Day',
43+
'2017-07-04' => 'Independence Day',
44+
'2017-09-04' => 'Labor Day',
45+
'2017-10-09' => 'Columbus Day',
46+
'2017-11-10' => 'Veterans Day',
47+
'2017-11-23' => 'Thanksgiving Day',
48+
'2017-12-25' => 'Christmas Day',
4949
);
5050

5151
$table = new PhabricatorCalendarHoliday();

‎scripts/mail/mail_handler.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,12 @@
4444
(preg_match('/charset="(.*?)"/', $content_type, $matches) ||
4545
preg_match('/charset=(\S+)/', $content_type, $matches))
4646
) {
47-
$text_body = phutil_utf8_convert($text_body, "UTF-8", $matches[1]);
47+
$text_body = phutil_utf8_convert($text_body, 'UTF-8', $matches[1]);
4848
}
4949

5050
$headers = $parser->getHeaders();
51-
$headers['subject'] = iconv_mime_decode($headers['subject'], 0, "UTF-8");
52-
$headers['from'] = iconv_mime_decode($headers['from'], 0, "UTF-8");
51+
$headers['subject'] = iconv_mime_decode($headers['subject'], 0, 'UTF-8');
52+
$headers['from'] = iconv_mime_decode($headers['from'], 0, 'UTF-8');
5353

5454
if ($args->getArg('process-duplicates')) {
5555
$headers['message-id'] = Filesystem::readRandomCharacters(64);

‎scripts/repository/rebuild_summaries.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
$repository_ids = array_keys($sizes + $maxes);
2424

25-
echo "Updating ".count($repository_ids)." repositories";
25+
echo 'Updating '.count($repository_ids).' repositories';
2626

2727
foreach ($repository_ids as $repository_id) {
2828
$last_commit = queryfx_one(
@@ -48,6 +48,6 @@
4848
$last_commit,
4949
idx($sizes, $repository_id, 0),
5050
idx($maxes, $repository_id, 0));
51-
echo ".";
51+
echo '.';
5252
}
5353
echo "\ndone.\n";

‎scripts/repository/reparse.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@
103103
$min_date = $args->getArg('min-date');
104104

105105
if (!$all_from_repo && !$reparse_what) {
106-
usage("Specify a commit or repository to reparse.");
106+
usage('Specify a commit or repository to reparse.');
107107
}
108108

109109
if ($all_from_repo && $reparse_what) {
@@ -116,8 +116,8 @@
116116

117117
if (!$reparse_message && !$reparse_change && !$reparse_herald &&
118118
!$reparse_owners && !$reparse_harbormaster) {
119-
usage("Specify what information to reparse with --message, --change, ".
120-
"--herald, --harbormaster, and/or --owners");
119+
usage('Specify what information to reparse with --message, --change, '.
120+
'--herald, --harbormaster, and/or --owners');
121121
}
122122

123123
$min_timestamp = false;
@@ -142,9 +142,9 @@
142142

143143
if ($reparse_owners && !$force) {
144144
echo phutil_console_wrap(
145-
"You are about to recreate the relationship entries between the commits ".
146-
"and the packages they touch. This might delete some existing ".
147-
"relationship entries for some old commits.");
145+
'You are about to recreate the relationship entries between the commits '.
146+
'and the packages they touch. This might delete some existing '.
147+
'relationship entries for some old commits.');
148148

149149
if (!phutil_console_confirm('Are you ready to continue?')) {
150150
echo "Cancelled.\n";

‎scripts/repository/save_lint.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,30 +18,30 @@
1818
array(
1919
'name' => 'all',
2020
'help' =>
21-
"Discover problems in the whole repository instead of just changes ".
22-
"since the last run.",
21+
'Discover problems in the whole repository instead of just changes '.
22+
'since the last run.',
2323
),
2424
array(
2525
'name' => 'arc',
2626
'param' => 'path',
2727
'default' => 'arc',
28-
'help' => "Path to Arcanist executable.",
28+
'help' => 'Path to Arcanist executable.',
2929
),
3030
array(
3131
'name' => 'severity',
3232
'param' => 'string',
3333
'default' => ArcanistLintSeverity::SEVERITY_ADVICE,
34-
'help' => "Minimum severity, one of ArcanistLintSeverity constants.",
34+
'help' => 'Minimum severity, one of ArcanistLintSeverity constants.',
3535
),
3636
array(
3737
'name' => 'chunk-size',
3838
'param' => 'number',
3939
'default' => 256,
40-
'help' => "Number of paths passed to `arc` at once.",
40+
'help' => 'Number of paths passed to `arc` at once.',
4141
),
4242
array(
4343
'name' => 'blame',
44-
'help' => "Assign lint errors to authors who last modified the line.",
44+
'help' => 'Assign lint errors to authors who last modified the line.',
4545
),
4646
));
4747

‎scripts/ssh/ssh-auth.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
$ssh_dao->getTableName());
1717

1818
if (!$rows) {
19-
echo pht("No keys found.")."\n";
19+
echo pht('No keys found.')."\n";
2020
exit(1);
2121
}
2222

0 commit comments

Comments
 (0)