Skip to content

Commit 8e2f054

Browse files
author
epriestley
committed
Remove TERM=dumb, which is causing difficult-to-reproduce hangs
Summary: Ref T7119. Three users have now reported that this causes their systems to hang, so it's looking like the cure is worse than the disease. Revert this until we can eventually reproduce and understand the hang. Test Plan: Users running into issues have reported that this resolves things. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7119 Differential Revision: https://secure.phabricator.com/D11644
1 parent d7b9b8b commit 8e2f054

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

scripts/repository/commit_hook.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
1-
#!/usr/bin/env TERM=dumb php
1+
#!/usr/bin/env php
22
<?php
33

4-
// NOTE: Note that we're specifying TERM=dumb above when invoking the PHP
5-
// interpreter. This suppresses an error which looks like this:
4+
// NOTE: This script will sometimes emit a warning like this on startup:
65
//
76
// No entry for terminal type "unknown";
87
// using dumb terminal settings.
98
//
10-
// This arises from somewhere in the PHP startup machinery if TERM is not
11-
// set to a recognized value.
9+
// This can be fixed by adding "TERM=dumb" to the shebang line, but doing so
10+
// causes some systems to hang mysteriously. See T7119.
1211

1312
// Commit hooks execute in an unusual context where the environment may be
1413
// unavailable, particularly in SVN. The first parameter to this script is

0 commit comments

Comments
 (0)