Skip to content

MVVM userinfo: split header and verification components #30214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

MVVM userinfo: split header and verification components #30214

wants to merge 3 commits into from

Conversation

MarcWadai
Copy link
Collaborator

@MarcWadai MarcWadai commented Jun 26, 2025 •
edited
Loading

Part of task #29633 to mvvm right panel

Split main user_info components into mvvm.

Changes

  • Create subcomponents UserInfoHeaderView, UserInfoHeaderVerificationView and their corresponding VM
  • Updated userInfo-test.tsx to remove userinfo header and verification tests
  • Created UserInfoHeaderView-test, UserInfoHeaderVerificationView-test and the VM tests

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jun 26, 2025
@MarcWadai MarcWadai force-pushed the 29633-mvvm-user-info-header branch from 83658aa to bbe8824 Compare June 26, 2025 16:32
@MarcWadai MarcWadai force-pushed the 29633-mvvm-user-info-header branch from 69ccf32 to 6727c0c Compare July 2, 2025 18:46
@MarcWadai MarcWadai force-pushed the 29633-mvvm-user-info-header branch from 6727c0c to 70a2b91 Compare July 3, 2025 08:21
@MarcWadai MarcWadai force-pushed the 29633-mvvm-user-info-header branch from 70a2b91 to 946cc48 Compare July 3, 2025 08:49
@MarcWadai MarcWadai marked this pull request as ready for review July 3, 2025 08:51
@MarcWadai MarcWadai requested a review from a team as a code owner July 3, 2025 08:51
@MarcWadai MarcWadai requested review from dbkr and MidhunSureshR July 3, 2025 08:51
@dbkr dbkr added the T-Task Tasks for the team like planning label Jul 3, 2025
dbkr
dbkr approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the thorough tests.

@dbkr dbkr changed the title Mvvm userinfo split header and verification components MVVM userinfo: split header and verification components Jul 3, 2025
@dbkr dbkr added this pull request to the merge queue Jul 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2025
@dbkr dbkr added this pull request to the merge queue Jul 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2025
@dbkr dbkr added this pull request to the merge queue Jul 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr

@MidhunSureshR MidhunSureshR

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcWadai @dbkr