Skip to content

Commit 61b79b5

Browse files
author
Jason Ge
committed
Use binary_safe_diff from arcanist
Summary: binary_safe_diff is needed in arcanist too. Moved it over to arcanist. See D2915. Test Plan: diffusion page rendered correctly on binary file. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D2916
1 parent dcf3a31 commit 61b79b5

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

scripts/repository/binary_safe_diff.sh

-6
This file was deleted.

src/applications/diffusion/query/rawdiff/DiffusionSvnRawDiffQuery.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ protected function executeQuery() {
2323
$repository = $drequest->getRepository();
2424

2525
$commit = $drequest->getCommit();
26-
$root = phutil_get_library_root('phabricator');
26+
$arc_root = phutil_get_library_root('arcanist');
2727

2828
$future = $repository->getRemoteCommandFuture(
2929
'diff --diff-cmd %s -x -U%d -c %d %s%s@',
30-
$root.'/../scripts/repository/binary_safe_diff.sh',
30+
$arc_root.'/../scripts/repository/binary_safe_diff.sh',
3131
$this->getLinesOfContext(),
3232
$commit,
3333
$repository->getRemoteURI(),

0 commit comments

Comments
 (0)