Remove PhabricatorSetup and make PHABRICATOR_ENV optional

Summary:
  - PHABRICATOR_ENV is now optional. If you don't specify it, we won't load a config file.
  - PhabricatorSetup is now gone.
    - I removed the alternate file domain check for now, see T2380.
  - `phabricator.setup` config is now gone.
  - Rewrote documentation:
    - No more mentions of `phabricator.setup`.
    - Normal install guide no longer mentions PHABRICATOR_ENV. This is now an advanced topic.
    - Clarified that you only need to set up one of apache, nginx or lighttpd.
    - Tweaked a few things I've seen users have difficulty with.

This should have no effect on any existing installs, but make the process much simpler for future installs.

Closes T2221.
Closes T2223.
Closes T2228.

Test Plan:
  - Removed my PHABRICATOR_ENV and went through the install process.
  - Generated and read documentation.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2221, T2223, T2228

Differential Revision: https://secure.phabricator.com/D4596

Author: epriestley

.gitignore

@@ -23,3 +23,4 @@
 /conf/custom/*
 /conf/local/local.json
 /conf/local/ENVIRONMENT
+/conf/local/VERSION

conf/default.conf.php

@@ -1,5 +1,9 @@
 <?php
 
+// IMPORTANT: DO NOT EDIT THIS FILE.
+// This file is no longer read by default, and your efforts will have no effect.
+// Follow the instructions in the documentation to configure Phabricator.
+
 return array(
 
   // The root URI which Phabricator is installed on.
@@ -11,10 +15,6 @@
   // contain the right links.
   'phabricator.production-uri'  => null,
 
-  // Setting this to 'true' will invoke a special setup mode which helps guide
-  // you through setting up Phabricator.
-  'phabricator.setup'           => false,
-
 // -- IMPORTANT! Security! -------------------------------------------------- //
 
   // IMPORTANT: By default, Phabricator serves files from the same domain the

src/__celerity_resource_map__.php

@@ -539,13 +539,6 @@
     'disk' => '/rsrc/image/texture/table_header_hover.png',
     'type' => 'png',
   ),
-  '/rsrc/image/texture/table_header_tall.png' =>
-  array(
-    'hash' => 'b05525601f78d759f1c5e47fd9c1a8aa',
-    'uri' => '/res/b0552560/rsrc/image/texture/table_header_tall.png',
-    'disk' => '/rsrc/image/texture/table_header_tall.png',
-    'type' => 'png',
-  ),
   '/rsrc/swf/aphlict.swf' =>
   array(
     'hash' => '4b9a9d83bebaf254f3790e87b45c1f92',
@@ -600,7 +593,7 @@
   ),
   'aphront-dialog-view-css' =>
   array(
-    'uri' => '/res/215b3ab1/rsrc/css/aphront/dialog-view.css',
+    'uri' => '/res/0ec64c77/rsrc/css/aphront/dialog-view.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -609,7 +602,7 @@
   ),
   'aphront-error-view-css' =>
   array(
-    'uri' => '/res/048ed376/rsrc/css/aphront/error-view.css',
+    'uri' => '/res/410dbe72/rsrc/css/aphront/error-view.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -3254,7 +3247,7 @@
 ), array(
   'packages' =>
   array(
-    '4dff6da8' =>
+    '2b575971' =>
     array(
       'name' => 'core.pkg.css',
       'symbols' =>
@@ -3298,7 +3291,7 @@
         36 => 'phabricator-object-item-list-view-css',
         37 => 'global-drag-and-drop-css',
       ),
-      'uri' => '/res/pkg/4dff6da8/core.pkg.css',
+      'uri' => '/res/pkg/2b575971/core.pkg.css',
       'type' => 'css',
     ),
     'c90b892e' =>
@@ -3488,19 +3481,19 @@
   'reverse' =>
   array(
     'aphront-attached-file-view-css' => '83f07678',
-    'aphront-crumbs-view-css' => '4dff6da8',
-    'aphront-dialog-view-css' => '4dff6da8',
-    'aphront-error-view-css' => '4dff6da8',
-    'aphront-form-view-css' => '4dff6da8',
+    'aphront-crumbs-view-css' => '2b575971',
+    'aphront-dialog-view-css' => '2b575971',
+    'aphront-error-view-css' => '2b575971',
+    'aphront-form-view-css' => '2b575971',
     'aphront-headsup-action-list-view-css' => 'ec01d039',
-    'aphront-headsup-view-css' => '4dff6da8',
-    'aphront-list-filter-view-css' => '4dff6da8',
-    'aphront-pager-view-css' => '4dff6da8',
-    'aphront-panel-view-css' => '4dff6da8',
-    'aphront-table-view-css' => '4dff6da8',
-    'aphront-tokenizer-control-css' => '4dff6da8',
-    'aphront-tooltip-css' => '4dff6da8',
-    'aphront-typeahead-control-css' => '4dff6da8',
+    'aphront-headsup-view-css' => '2b575971',
+    'aphront-list-filter-view-css' => '2b575971',
+    'aphront-pager-view-css' => '2b575971',
+    'aphront-panel-view-css' => '2b575971',
+    'aphront-table-view-css' => '2b575971',
+    'aphront-tokenizer-control-css' => '2b575971',
+    'aphront-tooltip-css' => '2b575971',
+    'aphront-typeahead-control-css' => '2b575971',
     'differential-changeset-view-css' => 'ec01d039',
     'differential-core-view-css' => 'ec01d039',
     'differential-inline-comment-editor' => 'ac53d36a',
@@ -3514,7 +3507,7 @@
     'differential-table-of-contents-css' => 'ec01d039',
     'diffusion-commit-view-css' => 'c8ce2d88',
     'diffusion-icons-css' => 'c8ce2d88',
-    'global-drag-and-drop-css' => '4dff6da8',
+    'global-drag-and-drop-css' => '2b575971',
     'inline-comment-summary-css' => 'ec01d039',
     'javelin-aphlict' => 'c90b892e',
     'javelin-behavior' => 'fbeded59',
@@ -3584,48 +3577,48 @@
     'javelin-util' => 'fbeded59',
     'javelin-vector' => 'fbeded59',
     'javelin-workflow' => 'fbeded59',
-    'lightbox-attachment-css' => '4dff6da8',
+    'lightbox-attachment-css' => '2b575971',
     'maniphest-task-summary-css' => '83f07678',
     'maniphest-transaction-detail-css' => '83f07678',
     'phabricator-busy' => 'c90b892e',
     'phabricator-content-source-view-css' => 'ec01d039',
-    'phabricator-core-buttons-css' => '4dff6da8',
-    'phabricator-core-css' => '4dff6da8',
-    'phabricator-crumbs-view-css' => '4dff6da8',
-    'phabricator-directory-css' => '4dff6da8',
+    'phabricator-core-buttons-css' => '2b575971',
+    'phabricator-core-css' => '2b575971',
+    'phabricator-crumbs-view-css' => '2b575971',
+    'phabricator-directory-css' => '2b575971',
     'phabricator-drag-and-drop-file-upload' => 'ac53d36a',
     'phabricator-dropdown-menu' => 'c90b892e',
     'phabricator-file-upload' => 'c90b892e',
-    'phabricator-filetree-view-css' => '4dff6da8',
-    'phabricator-flag-css' => '4dff6da8',
-    'phabricator-form-view-css' => '4dff6da8',
-    'phabricator-header-view-css' => '4dff6da8',
-    'phabricator-jump-nav' => '4dff6da8',
+    'phabricator-filetree-view-css' => '2b575971',
+    'phabricator-flag-css' => '2b575971',
+    'phabricator-form-view-css' => '2b575971',
+    'phabricator-header-view-css' => '2b575971',
+    'phabricator-jump-nav' => '2b575971',
     'phabricator-keyboard-shortcut' => 'c90b892e',
     'phabricator-keyboard-shortcut-manager' => 'c90b892e',
-    'phabricator-main-menu-view' => '4dff6da8',
+    'phabricator-main-menu-view' => '2b575971',
     'phabricator-menu-item' => 'c90b892e',
-    'phabricator-nav-view-css' => '4dff6da8',
+    'phabricator-nav-view-css' => '2b575971',
     'phabricator-notification' => 'c90b892e',
-    'phabricator-notification-css' => '4dff6da8',
-    'phabricator-notification-menu-css' => '4dff6da8',
-    'phabricator-object-item-list-view-css' => '4dff6da8',
+    'phabricator-notification-css' => '2b575971',
+    'phabricator-notification-menu-css' => '2b575971',
+    'phabricator-object-item-list-view-css' => '2b575971',
     'phabricator-object-selector-css' => 'ec01d039',
     'phabricator-paste-file-upload' => 'c90b892e',
     'phabricator-prefab' => 'c90b892e',
     'phabricator-project-tag-css' => '83f07678',
-    'phabricator-remarkup-css' => '4dff6da8',
+    'phabricator-remarkup-css' => '2b575971',
     'phabricator-shaped-request' => 'ac53d36a',
-    'phabricator-side-menu-view-css' => '4dff6da8',
-    'phabricator-standard-page-view' => '4dff6da8',
+    'phabricator-side-menu-view-css' => '2b575971',
+    'phabricator-standard-page-view' => '2b575971',
     'phabricator-textareautils' => 'c90b892e',
     'phabricator-tooltip' => 'c90b892e',
-    'phabricator-transaction-view-css' => '4dff6da8',
-    'phabricator-zindex-css' => '4dff6da8',
-    'sprite-apps-large-css' => '4dff6da8',
-    'sprite-gradient-css' => '4dff6da8',
-    'sprite-icon-css' => '4dff6da8',
-    'sprite-menu-css' => '4dff6da8',
-    'syntax-highlighting-css' => '4dff6da8',
+    'phabricator-transaction-view-css' => '2b575971',
+    'phabricator-zindex-css' => '2b575971',
+    'sprite-apps-large-css' => '2b575971',
+    'sprite-gradient-css' => '2b575971',
+    'sprite-icon-css' => '2b575971',
+    'sprite-menu-css' => '2b575971',
+    'syntax-highlighting-css' => '2b575971',
   ),
 ));

src/__phutil_library_map__.php

@@ -1210,7 +1210,6 @@
     'PhabricatorSettingsPanelProfile' => 'applications/settings/panel/PhabricatorSettingsPanelProfile.php',
     'PhabricatorSettingsPanelSSHKeys' => 'applications/settings/panel/PhabricatorSettingsPanelSSHKeys.php',
     'PhabricatorSettingsPanelSearchPreferences' => 'applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php',
-    'PhabricatorSetup' => 'infrastructure/PhabricatorSetup.php',
     'PhabricatorSetupCheck' => 'applications/config/check/PhabricatorSetupCheck.php',
     'PhabricatorSetupCheckAPC' => 'applications/config/check/PhabricatorSetupCheckAPC.php',
     'PhabricatorSetupCheckBaseURI' => 'applications/config/check/PhabricatorSetupCheckBaseURI.php',

src/applications/config/option/PhabricatorCoreConfigOptions.php

@@ -125,9 +125,6 @@ public function getOptions() {
       $this->newOption('phabricator.env', 'string', null)
         ->setLocked(true)
         ->setDescription(pht('Internal.')),
-      $this->newOption('phabricator.setup', 'bool', false)
-        ->setLocked(true)
-        ->setDescription(pht('Internal / deprecated.')),
       $this->newOption('test.value', 'wild', null)
         ->setLocked(true)
         ->setDescription(pht('Unit test value.')),