Skip to content

Commit 8069694

Browse files
committed
Fix next_uri
Summary: we were using the "path" as the next_uri and that drops some delicious get parameters Test Plan: see T1140; basically re-ran the steps listed there and they passed! Reviewers: epriestley, njhartwell Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1140, T1009 Differential Revision: https://secure.phabricator.com/D2299
1 parent c53dd99 commit 8069694

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/applications/auth/controller/login/PhabricatorLoginController.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,11 @@ public function processRequest() {
6464
));
6565
}
6666

67-
$next_uri = $this->getRequest()->getPath();
68-
if ($next_uri == '/login/') {
67+
$next_uri_path = $this->getRequest()->getPath();
68+
if ($next_uri_path == '/login/') {
6969
$next_uri = '/';
70+
} else {
71+
$next_uri = $this->getRequest()->getRequestURI();
7072
}
7173

7274
if (!$request->isFormPost()) {

0 commit comments

Comments
 (0)