Resolve implicit fallthrough in Phabricator

Summary: New implicit fallthrough linter detected a few issues; none of these have behavioral impacts but they can clearly be tightened up. See D1824.

Test Plan: Lint; inspection.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1825

Author: epriestley

scripts/repository/reparse.php

@@ -2,7 +2,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -63,6 +63,7 @@
         break;
       default:
         usage("Unknown flag '{$arg}'.");
+        break;
     }
   } else {
     if ($reparse_what) {

src/applications/phid/handle/PhabricatorObjectHandle.php

@@ -223,6 +223,7 @@ public function getLinkName() {
         break;
       default:
         $name = $this->getFullName();
+        break;
     }
     return $name;
   }

src/storage/qsprintf/qsprintf.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -264,6 +264,7 @@ function _qsprintf_check_type($value, $type, $query) {
       break;
     default:
       _qsprintf_check_scalar_type($value, $type, $query);
+      break;
   }
 }
 

webroot/index.php

@@ -220,7 +220,7 @@ function phabricator_detect_bad_base_uri() {
     case 'https':
       break;
     default:
-      phabricator_fatal_config_error(
+      return phabricator_fatal_config_error(
         "'phabricator.base-uri' is set to '{$conf}', which is invalid. ".
         "The URI must start with 'http://' or 'https://'.");
   }