Ignore errors in svn diff

Summary: Otherwise attaching the commit diff doesn't work.

Test Plan: Reparsed previously failing commit message.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2605

Author: vrana

scripts/repository/binary_safe_diff.sh

@@ -0,0 +1,6 @@
+#!/bin/sh
+
+diff "$@"
+if [ "$?" = "2" ]; then
+  exit 1
+fi

src/applications/diffusion/query/rawdiff/DiffusionSvnRawDiffQuery.php

@@ -23,9 +23,11 @@ protected function executeQuery() {
     $repository = $drequest->getRepository();
 
     $commit = $drequest->getCommit();
+    $root = phutil_get_library_root('phabricator');
 
     $future = $repository->getRemoteCommandFuture(
-      'diff --diff-cmd diff -x -U%d -c %d %s%s@',
+      'diff --diff-cmd %s -x -U%d -c %d %s%s@',
+      $root.'/../scripts/repository/binary_safe_diff.sh',
       $this->getLinesOfContext(),
       $commit,
       $repository->getRemoteURI(),