Skip to content

Suppress Warnings in generated classes #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Suppress Warnings in generated classes #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
37ef090
Suppress Warnings in generated classes
Wavesonics Jan 3, 2017
906788b
Added missing import
Wavesonics Jan 4, 2017
3fc213f
Corrected method signature
Wavesonics Jan 4, 2017
08136bf
Fixed method signature
Wavesonics Jan 4, 2017
1c1aa3d
Fixed string escape
Wavesonics Jan 4, 2017
28338f3
Corrected tests
Wavesonics Jan 4, 2017
10b20d2
Fixed all tests
Wavesonics Jan 4, 2017
5b8822e
Style fix
Wavesonics Jan 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dart-processor/src/main/java/com/f2prateek/dart/processor/ExtraInjectionGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import com.squareup.javapoet.MethodSpec;
import com.squareup.javapoet.TypeName;
import com.squareup.javapoet.TypeSpec;
import com.squareup.javapoet.AnnotationSpec;
import java.util.Collection;
import java.util.List;
import javax.lang.model.element.Modifier;
Expand Down Expand Up @@ -64,6 +65,8 @@ public String getFqcn() {

private void emitInject(TypeSpec.Builder builder) {
MethodSpec.Builder injectBuilder = MethodSpec.methodBuilder("inject")
.addAnnotation(AnnotationSpec.builder(SuppressWarnings.class)
.addMember("value", "$L", "{\"unchecked\",\"rawtypes\"}").build())
.addModifiers(Modifier.PUBLIC, Modifier.STATIC)
.addParameter(ClassName.get(Dart.Finder.class), "finder")
.addParameter(ClassName.bestGuess(target.targetClass), "target")
Expand Down
20 changes: 20 additions & 0 deletions dart-processor/src/test/java/com/f2prateek/dart/processor/InjectExtraTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ public class InjectExtraTest {
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.String;", //
"import java.lang.SuppressWarnings;", //
"public class Test$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, Test target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key\");", //
Expand Down Expand Up @@ -96,7 +98,9 @@ public class InjectExtraTest {
"package test;", //
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.SuppressWarnings;", //
"public class Test$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, Test target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key_bool\");", //
Expand Down Expand Up @@ -177,7 +181,9 @@ public class InjectExtraTest {
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.String;", //
"import java.lang.SuppressWarnings;", //
"public class Test$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, Test target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key\");", //
Expand Down Expand Up @@ -218,7 +224,9 @@ public class InjectExtraTest {
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.String;", //
"import java.lang.SuppressWarnings;", //
"public class Test$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, Test target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key\");", //
Expand Down Expand Up @@ -276,7 +284,9 @@ public class InjectExtraTest {
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.String;", //
"import java.lang.SuppressWarnings;", //
"public class Test$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, Test target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key\");", //
Expand Down Expand Up @@ -314,7 +324,9 @@ public class InjectExtraTest {
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.String;", //
"import java.lang.SuppressWarnings;", //
"public class Test$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, Test target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key\");", //
Expand Down Expand Up @@ -440,7 +452,9 @@ public class InjectExtraTest {
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.String;", //
"import java.lang.SuppressWarnings;", //
"public class Test$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, Test target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key\");", //
Expand All @@ -459,7 +473,9 @@ public class InjectExtraTest {
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.String;", //
"import java.lang.SuppressWarnings;", //
"public class TestOne$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, TestOne target, Object source) {", //
" Test$$ExtraInjector.inject(finder, target, source);", //
" Object object;", //
Expand Down Expand Up @@ -502,7 +518,9 @@ public class InjectExtraTest {
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.String;", //
"import java.lang.SuppressWarnings;", //
"public class Test$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, Test target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key\");", //
Expand All @@ -521,7 +539,9 @@ public class InjectExtraTest {
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.String;", //
"import java.lang.SuppressWarnings;", //
"public class TestOne$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, TestOne target, Object source) {",
" Test$$ExtraInjector.inject(finder, target, source);", //
" Object object;", //
Expand Down
13 changes: 13 additions & 0 deletions dart-processor/src/test/java/com/f2prateek/dart/processor/InjectExtraWithParcelerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public class InjectExtraWithParcelerTest {
"import java.lang.String;", //
"import android.util.SparseArray;", //
"public class TestSerializableCollection extends Activity {", //
"@SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" @InjectExtra(\"key\") SparseArray<String> extra;", //
"}" //
));
Expand All @@ -49,7 +50,9 @@ public class InjectExtraWithParcelerTest {
"package test;", //
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.SuppressWarnings;", //
"public class TestSerializableCollection$$ExtraInjector {", //
"@SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, TestSerializableCollection target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key\");", //
Expand Down Expand Up @@ -87,7 +90,9 @@ public class InjectExtraWithParcelerTest {
"package test;", //
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.SuppressWarnings;", //
"public class TestNonSerializableNonParcelableCollection_withoutParceler$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, TestNonSerializableNonParcelableCollection_withoutParceler target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key\");", //
Expand Down Expand Up @@ -126,7 +131,9 @@ public class InjectExtraWithParcelerTest {
"package test;", //
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.SuppressWarnings;", //
"public class TestParcelAnnotated$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, TestParcelAnnotated target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key\");", //
Expand Down Expand Up @@ -166,7 +173,9 @@ public class InjectExtraWithParcelerTest {
"package test;", //
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.SuppressWarnings;", //
"public class TestCollectionParcel$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, TestCollectionParcel target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key\");", //
Expand Down Expand Up @@ -212,7 +221,9 @@ public class InjectExtraWithParcelerTest {
"package test;", //
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.SuppressWarnings;", //
"public class TestParcelExtendsParcelable$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, TestParcelExtendsParcelable target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key\");", //
Expand Down Expand Up @@ -263,7 +274,9 @@ public class InjectExtraWithParcelerTest {
"package test;", //
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.SuppressWarnings;", //
"public class TestParcelableExtendsParcelable$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, TestParcelableExtendsParcelable target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key\");", //
Expand Down
4 changes: 4 additions & 0 deletions ...-processor/src/test/java/com/f2prateek/dart/processor/InjectExtraWithoutParcelerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,10 @@ public class InjectExtraWithoutParcelerTest {
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.String;", //
"import java.lang.SuppressWarnings;", //
"import java.util.ArrayList;", //
"public class TestSerializableCollection$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, TestSerializableCollection target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key\");", //
Expand Down Expand Up @@ -169,7 +171,9 @@ public class InjectExtraWithoutParcelerTest {
"package test;", //
"import com.f2prateek.dart.Dart;", //
"import java.lang.Object;", //
"import java.lang.SuppressWarnings;", //
"public class TestParcelableExtendsParcelable$$ExtraInjector {", //
" @SuppressWarnings({\"unchecked\",\"rawtypes\"})", //
" public static void inject(Dart.Finder finder, TestParcelableExtendsParcelable target, Object source) {", //
" Object object;", //
" object = finder.getExtra(source, \"key\");", //
Expand Down