-
Notifications
You must be signed in to change notification settings - Fork 64
Comparing changes
Open a pull request
base repository: phacility/javelin
base: fb9944cff2e2398ace77d2556f8b65edf88ebd58
head repository: phacility/javelin
compare: 748eac2b2fb3f210dc68506d2bc36f96a6b0d77f
- 9 commits
- 9 files changed
- 7 contributors
Commits on Mar 13, 2012
-
Throw when calling getData() before data has been provided by mergeDa…
…ta() Summary: See https://www.facebook.com/groups/104578302983740/210002262441343/ Test Plan: N/A Reviewers: hedger, tomo, mroch Reviewed By: hedger CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1879
epriestley committedMar 13, 2012 Configuration menu - View commit details
-
Copy full SHA for e19e107 - Browse repository at this point
Copy the full SHA e19e107View commit details
Commits on Mar 26, 2012
-
Fix bug in tic-tac-toe example
Summary: JX.JSON.serialize got renamed to JX.JSON.stringify Test Plan: Played tic-tac-toe Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D2014
Nick Harper committedMar 26, 2012 Configuration menu - View commit details
-
Copy full SHA for ee83d95 - Browse repository at this point
Copy the full SHA ee83d95View commit details -
[javelinsymbols] -- Add support to javelinsymbols for JX.behavior()
Summary: Currently javelinsymbols can detect the installation of a class...but not behaviors. This adds support to the javelinsymbols processor to identify behavior-registrations and specify them using a new '*' directive. I plan to use javelinsymbols for a project to implicitly identify a unique name for a given JS resource based on the JX.install()s and JX.behavior()s calls that exist in the file. Test Plan: Compiled and ran javlinesymbols against a file with a JX.install(), a file with JX.behavior(), and a file with both to verify the output was as expected. Reviewers: leebyron, epriestley, jg Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D2023
Configuration menu - View commit details
-
Copy full SHA for 469619c - Browse repository at this point
Copy the full SHA 469619cView commit details -
Merge pull request #15 from jeffmo/javelinsymbols_behavior_support
[javelinsymbols] -- Add support to javelinsymbols for JX.behavior()
Evan Priestley committedMar 26, 2012 Configuration menu - View commit details
-
Copy full SHA for 005ca26 - Browse repository at this point
Copy the full SHA 005ca26View commit details
Commits on Mar 29, 2012
-
include input elements w/ type="tel" or "number" when encoding form v…
…alue Summary: Right now JX.DOM.convertFormToDictionary will skip over input elements with type="tel" (or type="number"), which are valid values for that attribute according to http://dev.w3.org/html5/markup/input.number.html and http://dev.w3.org/html5/markup/input.tel.html. This makes convertFormToListOfPairs include those input elements. Test Plan: used in subsequent change which uses input type="tel" in conjunction with JX.DOM.convertFormToDictionary.
bhiller committedMar 29, 2012 Configuration menu - View commit details
-
Copy full SHA for 04a9742 - Browse repository at this point
Copy the full SHA 04a9742View commit details -
Merge pull request #16 from benhiller/master
include input elements w/ type="tel" or "number" when encoding form value
Evan Priestley committedMar 29, 2012 Configuration menu - View commit details
-
Copy full SHA for 36c4de4 - Browse repository at this point
Copy the full SHA 36c4de4View commit details
Commits on Apr 2, 2012
-
Typeahead: separate the name field from the field we complete on
Summary: Let typeahead datasources provide an optional field: tokenizable. If present, the typeahead tokenizes and completes on this field instead of name, but still uses the name when inputting data into the <input>. For example, I can have an input for Phabricator commit identifiers, and build typeahead from (commit-identifier, commit-message-summary-line) pairs. The 'display' field formats both prettily, the 'name' is the commit-identifier, and the 'tokenizable' contains both commit-identifier and commit-message concatenated. The typeahead lets me search both, but the resulting value in the <input> is just the commit-identifier. Test Plan: Made an example as described above which queries all my commits to a repo from the past week. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2070
Edward Speyer committedApr 2, 2012 Configuration menu - View commit details
-
Copy full SHA for 85e9369 - Browse repository at this point
Copy the full SHA 85e9369View commit details
Commits on Apr 12, 2012
-
Fix filenames of sync-facebook
Summary: Does this belong to Javelin repository at all? Test Plan: Read. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2212
vrana committedApr 12, 2012 Configuration menu - View commit details
-
Copy full SHA for 851995a - Browse repository at this point
Copy the full SHA 851995aView commit details
Commits on Apr 17, 2012
-
Summary: [[ https://secure.phabricator.com/D714#inline-1387 | D714#inline-1387 ]] Test Plan: Open Phabricator in IE8. Reviewers: tomo, epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D2250
vrana committedApr 17, 2012 Configuration menu - View commit details
-
Copy full SHA for 748eac2 - Browse repository at this point
Copy the full SHA 748eac2View commit details
There are no files selected for viewing