-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controls: Added metadata to the Controls project to enable publishing to NuGet #16611
base: main
Are you sure you want to change the base?
Conversation
We should do this after v4 or even later. What do you think? |
We can move forward with this as soon as the versioning system is agreed on. |
If you'd like to publish when you publish preview or stable thru Files CD, we can add a parameter text box to input the version. If empty, don't publish; otherwise, try publish with that version string. |
This shouldn't be tied to app releases. We may have a newer control ready for release before an app update, and on the other hand, we may want to release the app without updating the controls. It's best to handle this as a separate action. |
@yaira2 when you approve you'll need to give the bot access to the repo |
[skip ci]
[skip ci]
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com> Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
[skip ci] Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com> Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com> Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com> Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I do belive we should not publish yet unless we ultimatelly remove WCT 7 controls (if we do, we should attribute properly) and fiinnsh unfinished controls such as Toolbar and Storage Bar/Ring.
fail-fast: false | ||
env: | ||
WORKING_DIR: '${{ github.workspace }}' # D:\a\Files\Files\ | ||
PROPS_PATH: '${{ github.workspace }}\src\Files.App.Controls\CurrentVersion.props' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PROPS_PATH: '${{ github.workspace }}\src\Files.App.Controls\CurrentVersion.props' | |
VERSION_PROPS_PATH: '${{ github.workspace }}\src\Files.App.Controls\CurrentVersion.props' |
uses: EndBug/add-and-commit@v9 | ||
with: | ||
# The arguments for the `git add` command | ||
# Default: '.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we need these comments
<!-- READ ME BEFORE MODIFYING THIS FILE: | ||
This file is used to track the version of the Files UI Controls package online. | ||
The version is automatically bumped by the 'Bump Files UI Controls' action online. | ||
You can bump the version here in a PR and when it is merged the controls project | ||
will be automatically published to NuGet online. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- READ ME BEFORE MODIFYING THIS FILE: | |
This file is used to track the version of the Files UI Controls package online. | |
The version is automatically bumped by the 'Bump Files UI Controls' action online. | |
You can bump the version here in a PR and when it is merged the controls project | |
will be automatically published to NuGet online. --> | |
<!-- | |
DO NOT MODIFY unless you are knowledgeable about this file: | |
This file is used to track the version of the Files.App.Controls NuGet package online. | |
The version is automatically bumped by a GitHub Action online. | |
--> |
Co-authored-by: 0x5BFA <62196528+0x5bfa@users.noreply.github.com> Signed-off-by: Yair <39923744+yaira2@users.noreply.github.com>
Resolved / Related Issues
Discussed on Discord
Steps used to test these changes
WHEN PR IS ACCEPTED (NOT BEFORE)
NuGet
main
and PR configurationsCurrentVersion.props
files-community-bot[bot]
token