Skip to content

Commit 299b6f4

Browse files
author
epriestley
committedApr 10, 2019
Fix two minor main menu bar CSS issues
Summary: Ref T13263. - Make the user profile section of the "Profile" dropdown menu have a transparent background, not a white background. This is a pre-existing issue. This is normally hard to see, but visible on Workboards with custom background colors. - Fix an alignment issue with the little "V" caret in the search scope dropdown. This is a recent issue caused by some tab-caret CSS I added recently for tabbed dashboard panels. Test Plan: Before: {F6367723} After: {F6367724} Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13263 Differential Revision: https://secure.phabricator.com/D20388
1 parent 1a52c8f commit 299b6f4

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed
 

‎resources/celerity/map.php

+8-8
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
'names' => array(
1010
'conpherence.pkg.css' => '3c8a0668',
1111
'conpherence.pkg.js' => '020aebcf',
12-
'core.pkg.css' => '671b9fae',
12+
'core.pkg.css' => 'dacb981b',
1313
'core.pkg.js' => 'c783d8f6',
1414
'differential.pkg.css' => '8d8360fb',
1515
'differential.pkg.js' => '67e02996',
@@ -37,7 +37,7 @@
3737
'rsrc/css/aphront/typeahead.css' => '8779483d',
3838
'rsrc/css/application/almanac/almanac.css' => '2e050f4f',
3939
'rsrc/css/application/auth/auth.css' => 'add92fd8',
40-
'rsrc/css/application/base/main-menu-view.css' => '8e2d9a28',
40+
'rsrc/css/application/base/main-menu-view.css' => '17b71bbc',
4141
'rsrc/css/application/base/notification-menu.css' => '4df1ee30',
4242
'rsrc/css/application/base/phui-theme.css' => '35883b37',
4343
'rsrc/css/application/base/standard-page-view.css' => '8a295cb9',
@@ -134,7 +134,7 @@
134134
'rsrc/css/phui/object-item/phui-oi-flush-ui.css' => '490e2e2e',
135135
'rsrc/css/phui/object-item/phui-oi-list-view.css' => 'f14f2422',
136136
'rsrc/css/phui/object-item/phui-oi-simple-ui.css' => '6a30fa46',
137-
'rsrc/css/phui/phui-action-list.css' => 'c34af376',
137+
'rsrc/css/phui/phui-action-list.css' => '8862282e',
138138
'rsrc/css/phui/phui-action-panel.css' => '6c386cbf',
139139
'rsrc/css/phui/phui-badge.css' => '666e25ad',
140140
'rsrc/css/phui/phui-basic-nav-view.css' => '56ebd66d',
@@ -757,7 +757,7 @@
757757
'path-typeahead' => 'ad486db3',
758758
'people-picture-menu-item-css' => 'fe8e07cf',
759759
'people-profile-css' => '2ea2daa1',
760-
'phabricator-action-list-view-css' => 'c34af376',
760+
'phabricator-action-list-view-css' => '8862282e',
761761
'phabricator-busy' => '5202e831',
762762
'phabricator-chatlog-css' => 'abdc76ee',
763763
'phabricator-content-source-view-css' => 'cdf0d579',
@@ -779,7 +779,7 @@
779779
'phabricator-flag-css' => '2b77be8d',
780780
'phabricator-keyboard-shortcut' => 'c9749dcd',
781781
'phabricator-keyboard-shortcut-manager' => '37b8a04a',
782-
'phabricator-main-menu-view' => '8e2d9a28',
782+
'phabricator-main-menu-view' => '17b71bbc',
783783
'phabricator-nav-view-css' => 'f8a0c1bf',
784784
'phabricator-notification' => 'a9b91e3f',
785785
'phabricator-notification-css' => '30240bd2',
@@ -1029,6 +1029,9 @@
10291029
'javelin-stratcom',
10301030
'javelin-util',
10311031
),
1032+
'17b71bbc' => array(
1033+
'phui-theme-css',
1034+
),
10321035
'1b6acc2a' => array(
10331036
'javelin-magical-init',
10341037
'javelin-util',
@@ -1645,9 +1648,6 @@
16451648
'javelin-install',
16461649
'javelin-dom',
16471650
),
1648-
'8e2d9a28' => array(
1649-
'phui-theme-css',
1650-
),
16511651
'8f959ad0' => array(
16521652
'javelin-behavior',
16531653
'javelin-dom',

‎webroot/rsrc/css/application/base/main-menu-view.css

+1
Original file line numberDiff line numberDiff line change
@@ -650,6 +650,7 @@ ul.phabricator-core-user-profile-object .phui-oi-content,
650650
ul.phabricator-core-user-profile-object .phui-oi-subhead {
651651
padding: 0;
652652
margin: 0;
653+
background: transparent;
653654
}
654655

655656
ul.phabricator-core-user-profile-object.phui-oi-list-simple .phui-oi-image {

‎webroot/rsrc/css/phui/phui-action-list.css

+2-2
Original file line numberDiff line numberDiff line change
@@ -214,11 +214,11 @@
214214
color: {$sky};
215215
}
216216

217-
.phui-list-item-view.dropdown .phui-list-item-href {
217+
.phui-list-navbar .phui-list-item-view.dropdown .phui-list-item-href {
218218
padding-right: 28px;
219219
}
220220

221-
.phui-list-item-view .caret {
221+
.phui-list-navbar .phui-list-item-view .caret {
222222
position: absolute;
223223
top: 6px;
224224
right: 12px;

0 commit comments

Comments
 (0)
Failed to load comments.