Always pass handles to tokenizers, not <phid -> name> maps

Summary: Ref T1279. Prerequisite for adding icons or other type information to tokenizers, since we don't currently have enough information to prefill them when rendering things from the server side. By passing handles in, the tokenizer can extract type information.

Test Plan:
- Searched by user in Audit.
- Sent Conpherence from profile page.
- Tried to send an empty conpherence.
- Searched Countdown by user.
- Edited CCs in Differential.
- Edited reviewers in Differential.
- Edited a commit's projects.
- Searched lint by owner.
- Searched feed by owner/project.
- Searched files by owner.
- Searched Herald by owner.
- Searched Legalpad by owner.
- Searched Macro by owner.
- Filtered Maniphest reports by project.
- Edited CCs in Maniphest.
- Searched Owners by owner.
- Edited an Owners package.
- Searched Paste by owner.
- Searched activity logs by owner.
- Searched for mocks by owner.
- Edited a mock's CCs.
- Searched Ponder by owner.
- Searched projects by owner.
- Edited a Releeph project's pushers.
- Searched Releeph by requestor.
- Edited "Uses Symbols" for an Arcanist project.
- Edited all tokenizers in main search.
- Searched Slowvote by user.

Reviewers: chad, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1279

Differential Revision: https://secure.phabricator.com/D7248

Author: epriestley

src/applications/audit/controller/PhabricatorAuditListController.php

@@ -139,9 +139,7 @@ private function buildListFilters(PhabricatorObjectHandle $handle = null) {
 
       $tok_value = null;
       if ($handle) {
-        $tok_value = array(
-          $handle->getPHID() => $handle->getFullName(),
-        );
+        $tok_value = array($handle);
       }
 
       $form->appendChild(

src/applications/conpherence/controller/ConpherenceNewController.php

@@ -11,15 +11,12 @@ public function processRequest() {
 
     $title = pht('New Message');
     $participants = array();
+    $participant_prefill = null;
     $message = '';
     $e_participants = null;
     $e_message = null;
 
     // this comes from ajax requests from all over. should be a single phid.
-    $participant_prefill = $request->getStr('participant');
-    if ($participant_prefill) {
-      $participants[] = $participant_prefill;
-    }
 
     if ($request->isFormPost()) {
       $participants = $request->getArr('participants');
@@ -47,15 +44,20 @@ public function processRequest() {
         return id(new AphrontRedirectResponse())
           ->setURI($uri);
       }
+    } else {
+      $participant_prefill = $request->getStr('participant');
+      if ($participant_prefill) {
+        $participants[] = $participant_prefill;
+      }
     }
 
+
     $participant_handles = array();
     if ($participants) {
-      $handles = id(new PhabricatorHandleQuery())
+      $participant_handles = id(new PhabricatorHandleQuery())
         ->setViewer($user)
         ->withPHIDs($participants)
         ->execute();
-      $participant_handles = mpull($handles, 'getFullName', 'getPHID');
     }
 
     $submit_uri = $this->getApplicationURI('new/');
@@ -64,7 +66,7 @@ public function processRequest() {
     // TODO - we can get a better cancel_uri once we get better at crazy
     // ajax jonx T2086
     if ($participant_prefill) {
-      $handle = $handles[$participant_prefill];
+      $handle = $participant_handles[$participant_prefill];
       $cancel_uri = $handle->getURI();
     }
 

src/applications/countdown/query/PhabricatorCountdownSearchEngine.php

@@ -33,11 +33,10 @@ public function buildSearchForm(
     AphrontFormView $form,
     PhabricatorSavedQuery $saved_query) {
     $phids = $saved_query->getParameter('authorPHIDs', array());
-    $handles = id(new PhabricatorHandleQuery())
+    $author_handles = id(new PhabricatorHandleQuery())
       ->setViewer($this->requireViewer())
       ->withPHIDs($phids)
       ->execute();
-    $author_tokens = mpull($handles, 'getFullName', 'getPHID');
 
     $upcoming = $saved_query->getParameter('upcoming');
 
@@ -47,7 +46,7 @@ public function buildSearchForm(
           ->setDatasource('/typeahead/common/users/')
           ->setName('authors')
           ->setLabel(pht('Authors'))
-          ->setValue($author_tokens))
+          ->setValue($author_handles))
       ->appendChild(
         id(new AphrontFormCheckboxControl())
           ->addCheckbox(

src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php

@@ -50,7 +50,7 @@ public function setValueFromRequest(AphrontRequest $request) {
   public function renderEditControl() {
     $cc_map = array();
     foreach ($this->ccs as $phid) {
-      $cc_map[$phid] = $this->getHandle($phid)->getFullName();
+      $cc_map[] = $this->getHandle($phid);
     }
     return id(new AphrontFormTokenizerControl())
       ->setLabel('CC')

src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php

@@ -89,7 +89,7 @@ public function validateField() {
   public function renderEditControl() {
     $reviewer_map = array();
     foreach ($this->reviewers as $phid) {
-      $reviewer_map[$phid] = $this->getHandle($phid)->getFullName();
+      $reviewer_map[] = $this->getHandle($phid);
     }
     return id(new AphrontFormTokenizerControl())
       ->setLabel(pht('Reviewers'))

src/applications/diffusion/controller/DiffusionCommitEditController.php

@@ -27,7 +27,7 @@ public function processRequest() {
       $commit_phid,
       $edge_type);
     $handles = $this->loadViewerHandles($current_proj_phids);
-    $proj_t_values = mpull($handles, 'getFullName', 'getPHID');
+    $proj_t_values = $handles;
 
     if ($request->isFormPost()) {
       $proj_phids = $request->getArr('projects');

src/applications/diffusion/controller/DiffusionLintController.php

@@ -21,18 +21,14 @@ public function processRequest() {
     $owners = array();
     if (!$drequest) {
       if (!$request->getArr('owner')) {
-        if ($user->isLoggedIn()) {
-          $owners[$user->getPHID()] = $user->getFullName();
-        }
+        $owners = array($user->getPHID());
       } else {
-        $phids = $request->getArr('owner');
-        $phid = reset($phids);
-        $handles = $this->loadViewerHandles(array($phid));
-        $owners[$phid] = $handles[$phid]->getFullName();
+        $owners = array(head($request->getArr('owner')));
       }
+      $owner_handles = $this->loadViewerHandles($owners);
     }
 
-    $codes = $this->loadLintCodes(array_keys($owners));
+    $codes = $this->loadLintCodes($owners);
 
     if ($codes && !$drequest) {
       // TODO: Build some real Query classes for this stuff.
@@ -125,7 +121,7 @@ public function processRequest() {
             ->setLimit(1)
             ->setName('owner')
             ->setLabel(pht('Owner'))
-            ->setValue($owners))
+            ->setValue($owner_handles))
         ->appendChild(
           id(new AphrontFormSubmitControl())
             ->setValue('Filter'));

src/applications/feed/query/PhabricatorFeedSearchEngine.php

@@ -66,9 +66,8 @@ public function buildSearchForm(
       ->setViewer($this->requireViewer())
       ->withPHIDs($phids)
       ->execute();
-    $tokens = mpull($handles, 'getFullName', 'getPHID');
-    $user_tokens = array_select_keys($tokens, $user_phids);
-    $proj_tokens = array_select_keys($tokens, $proj_phids);
+    $user_handles = array_select_keys($handles, $user_phids);
+    $proj_handles = array_select_keys($handles, $proj_phids);
 
     $viewer_projects = $saved_query->getParameter('viewerProjects');
 
@@ -78,13 +77,13 @@ public function buildSearchForm(
           ->setDatasource('/typeahead/common/users/')
           ->setName('users')
           ->setLabel(pht('Include Users'))
-          ->setValue($user_tokens))
+          ->setValue($user_handles))
       ->appendChild(
         id(new AphrontFormTokenizerControl())
           ->setDatasource('/typeahead/common/projects/')
           ->setName('projectPHIDs')
           ->setLabel(pht('Include Projects'))
-          ->setValue($proj_tokens))
+          ->setValue($proj_handles))
       ->appendChild(
         id(new AphrontFormCheckboxControl())
           ->addCheckbox(

src/applications/files/query/PhabricatorFileSearchEngine.php

@@ -46,11 +46,10 @@ public function buildSearchForm(
     PhabricatorSavedQuery $saved_query) {
 
     $phids = $saved_query->getParameter('authorPHIDs', array());
-    $handles = id(new PhabricatorHandleQuery())
+    $author_handles = id(new PhabricatorHandleQuery())
       ->setViewer($this->requireViewer())
       ->withPHIDs($phids)
       ->execute();
-    $author_tokens = mpull($handles, 'getFullName', 'getPHID');
 
     $explicit = $saved_query->getParameter('explicit');
 
@@ -60,7 +59,7 @@ public function buildSearchForm(
           ->setDatasource('/typeahead/common/users/')
           ->setName('authors')
           ->setLabel(pht('Authors'))
-          ->setValue($author_tokens))
+          ->setValue($author_handles))
       ->appendChild(
         id(new AphrontFormCheckboxControl())
           ->addCheckbox(

src/applications/herald/query/HeraldRuleSearchEngine.php

@@ -52,11 +52,10 @@ public function buildSearchForm(
     PhabricatorSavedQuery $saved_query) {
 
     $phids = $saved_query->getParameter('authorPHIDs', array());
-    $handles = id(new PhabricatorHandleQuery())
+    $author_handles = id(new PhabricatorHandleQuery())
       ->setViewer($this->requireViewer())
       ->withPHIDs($phids)
       ->execute();
-    $author_tokens = mpull($handles, 'getFullName', 'getPHID');
 
     $content_type = $saved_query->getParameter('contentType');
     $rule_type = $saved_query->getParameter('ruleType');
@@ -67,7 +66,7 @@ public function buildSearchForm(
           ->setDatasource('/typeahead/common/users/')
           ->setName('authors')
           ->setLabel(pht('Authors'))
-          ->setValue($author_tokens))
+          ->setValue($author_handles))
       ->appendChild(
         id(new AphrontFormSelectControl())
           ->setName('contentType')