File list now shows only files which are explicitly uploaded

Summary: Added explicit tags to files which are explicitly uploaded. Fixes T2749

Test Plan: Tested by checking out the files application.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2749

Differential Revision: https://secure.phabricator.com/D5406

Author: afaquejam

src/applications/files/controller/PhabricatorFileDropUploadController.php

@@ -18,6 +18,7 @@ public function processRequest() {
       array(
         'name' => $request->getStr('name'),
         'authorPHID' => $user->getPHID(),
+        'isExplicitUpload' => true,
       ));
 
     $view = new AphrontAttachedFileView();

src/applications/files/controller/PhabricatorFileListController.php

@@ -30,6 +30,7 @@ public function processRequest() {
     switch ($this->getFilter()) {
       case 'my':
         $query->withAuthorPHIDs(array($user->getPHID()));
+        $query->showOnlyExplicitUploads(true);
         $header = pht('Files You Uploaded');
         break;
       case 'all':

src/applications/files/controller/PhabricatorFileUploadController.php

@@ -18,6 +18,7 @@ public function processRequest() {
           array(
             'name'        => $request->getStr('name'),
             'authorPHID'  => $user->getPHID(),
+            'isExplicitUpload' => true,
           ));
       }
 

src/applications/files/query/PhabricatorFileQuery.php

@@ -6,6 +6,7 @@ final class PhabricatorFileQuery
   private $ids;
   private $phids;
   private $authorPHIDs;
+  private $explicitUploads;
 
   public function withIDs(array $ids) {
     $this->ids = $ids;
@@ -22,6 +23,11 @@ public function withAuthorPHIDs(array $phids) {
     return $this;
   }
 
+  public function showOnlyExplicitUploads($explicit_uploads) {
+    $this->explicitUploads = $explicit_uploads;
+    return $this;
+  }
+
   protected function loadPage() {
     $table = new PhabricatorFile();
     $conn_r = $table->establishConnection('r');
@@ -63,6 +69,12 @@ private function buildWhereClause(AphrontDatabaseConnection $conn_r) {
         $this->authorPHIDs);
     }
 
+    if ($this->explicitUploads) {
+      $where[] = qsprintf(
+        $conn_r,
+        'isExplicitUpload = true');
+    }
+
     return $this->formatWhereClause($where);
   }
 

src/applications/files/storage/PhabricatorFile.php

@@ -247,6 +247,7 @@ private static function buildFromFileData($data, array $params = array()) {
     // TODO: This is probably YAGNI, but allows for us to do encryption or
     // compression later if we want.
     $file->setStorageFormat(self::STORAGE_FORMAT_RAW);
+    $file->setIsExplicitUpload(idx($params, 'isExplicitUpload') ? 1 : 0);
 
     if (isset($params['mime-type'])) {
       $file->setMimeType($params['mime-type']);