Fix displaying non-image files.

asherkin · epriestley · commit 27e2198e11fa · 2013-01-18T06:20:33.000-08:00
Summary: The Files application currently tries to render all browser-viewable files in an img tag, not taking into account if they're an image or not. Test Plan: Looked at various image and non-image files. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4511
diff --git a/src/applications/files/controller/PhabricatorFileInfoController.php b/src/applications/files/controller/PhabricatorFileInfoController.php
@@ -136,7 +136,7 @@ private function buildPropertyView(PhabricatorFile $file) {
       }
     }
 
-    if ($file->isViewableInBrowser()) {
+    if ($file->isViewableImage()) {
 
       // TODO: Clean this up after Pholio (dark backgrounds, standardization,
       // etc.)

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ private function buildPropertyView(PhabricatorFile $file) {`
`136`	`136`	`}`
`137`	`137`	`}`
`138`	`138`
`139`		`- if ($file->isViewableInBrowser()) {`
	`139`	`+ if ($file->isViewableImage()) {`
`140`	`140`
`141`	`141`	`// TODO: Clean this up after Pholio (dark backgrounds, standardization,`
`142`	`142`	`// etc.)`